Github user dschneider-pivotal commented on the issue:

    https://github.com/apache/geode/pull/315
  
    I think you should continue to remove code that was only used by 
ReliableMessageQueueFactoryImpl. This included the following:
    1. LocalizedStrings that this class used.
    2. ReliableDistributionData: the methods on this interface were only called 
by ReliableMessageQueueFactoryImpl. So this interface should be removed and all 
the implementations of this interface (lots of *Message classes).
    3. DistributedRegion.sendQueue method: it is only called by 
ReliableMessageQueueFactoryImpl.
    Getting rid of that method lets you delete SendQueueOperation which gets 
rid of SendQueueMessage which lets you get rid of SEND_QUEUE_MESSAGE (you will 
need to also remove some references for this message from DSFIDFactory).
    
    It would be best to remove all this stuff with one checkin. Just just look 
over each class you remove and see what it references that will no longer be 
used.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to