Github user dschneider-pivotal commented on a diff in the pull request:

    https://github.com/apache/geode/pull/610#discussion_r124667734
  
    --- Diff: 
geode-docs/developing/partitioned_regions/set_join_redundancy_recovery.html.md.erb
 ---
    @@ -19,23 +19,38 @@ See the License for the specific language governing 
permissions and
     limitations under the License.
     -->
     
    -Configure whether and how redundancy is recovered in a partition region 
after a member joins.
    +This section covers configuring whether and how redundancy is
    +recovered in a partitioned region, after a member joins.
     
     <a 
id="set_join_redundancy_recovery__section_D6FB0D69CC454B53B9CF1E656A44465C"></a>
     Use the partition attribute `startup-recovery-delay` to specify member 
join redundancy recovery.
     
    -| startup-recovery-delay partition attribute | Effect following a member 
join                                                                            
                                                                                
                                   |
    +| value of `startup-recovery-delay`            | Effect following a member 
join                                                                            
                                                                                
                                   |
     
|--------------------------------------------|------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|
    -| -1                                         | No automatic recovery of 
redundancy after a new member comes online. If you use this and the default 
`recovery-delay` setting, you can only recover redundancy by kicking off 
rebalancing through a cacheserver or API call. |
    -| long greater than or equal to **0**        | Number of milliseconds to 
wait after a member joins before before recovering redundancy. The default is 0 
(zero), which causes immediate redundancy recovery whenever a new partitioned 
region host joins.                   |
    -
    -Setting this to a value higher than the default of 0 allows multiple new 
members to join before redundancy recovery kicks in. With the multiple members 
present during recovery, the system will spread redundancy recovery among them. 
With no delay, if multiple members are started in close succession, the system 
may choose only the first member started for most or all of the redundancy 
recovery.
    -
    -**Note:**
    -Satisfying redundancy is not the same as adding capacity. If redundancy is 
satisfied, new members do not take buckets until you invoke a rebalance.
    +| -1                                         | No automatic recovery of 
redundancy after a new member comes online. With this value and the default 
`recovery-delay` setting, redundancy recovery is only achieved by a rebalance 
operation. |
    +| long integer greater than or equal to **0** | Number of milliseconds to 
wait after a member joins before recovering redundancy. The default is 0 
(zero), which causes immediate redundancy recovery whenever a member that hosts 
the partitioned region joins. |
    --- End diff --
    
    I find "long integer greater" more confusing than the old "long greater". 
"long" and "integer" can both be used to indicate a specific Java ordinal type 
so having both of them is confusing.
    
    In this context I think ">=0" would work. If you want to keep it verbose 
perhaps changing the old "long" to something more generic like "number" or 
"value" would be better.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to