Github user dschneider-pivotal commented on a diff in the pull request:

    https://github.com/apache/geode/pull/488#discussion_r115331339
  
    --- Diff: 
geode-core/src/main/java/org/apache/geode/cache/client/internal/ProxyRegion.java
 ---
    @@ -187,7 +187,7 @@ public void destroyRegion(Object callbackArgument) 
throws CacheWriterException,
       public Set entries(boolean recursive) {
    --- End diff --
    
    I think it is wrong to keep these methods your are removing from Region on 
classes that implement the Region interface. It is too bad that these impls did 
not have @Override on them because that would have caused compilation failures.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to