[GitHub] geode pull request #720: GEODE-3462: FunctionStats Exposed over JMX

Github user dineshakhand commented on a diff in the pull request: https://github.com/apache/geode/pull/720#discussion_r134197931 --- Diff: geode-core/src/main/java/org/apache/geode/management/FunctionStatsMXBean.java --- @@ -0,0 +1,54 @@ +/* + * Licensed to the Apache Soft

[Discuss] FunctionStats over the JMX [GEODE-3462]

Hi Team, We are looking for implementing the function stats over JMX. Currently Function Stats are not part of JMX. We can't see them on JMX server. Can you please assist what is the correct way to implementing it. We have many function which are instanceOf FunctionAdapter. We want to monitor t

[GitHub] geode pull request #726: GEODE-3474: protobuf auth with ExampleSecurityManag...

GitHub user galen-pivotal opened a pull request: https://github.com/apache/geode/pull/726 GEODE-3474: protobuf auth with ExampleSecurityManager It looks like we were using the wrong constants for the username and password strings; ExampleSecurityManager uses some defined constants t

Re: [DISCUSS] authorizing function execution

> On Aug 17, 2017, at 1:41 PM, Dan Smith wrote: > > Which means > the develop needs a way override the permission level *before* the function > executes. I agree. Providing a callback to allow a user to override the default security level seems reasonable. Anthony

Re: [DISCUSS] authorizing function execution

When we speak of "users" here, do we mean normal developers or "administrational users"? My concern is that given the current functionality of "deploy jar" it would be too easy to deploy a jar, containing a function that has "relaxed" user permissions. Which would allow them to execute ANY fu

Re: [Discuss] Compatibility with Apache Xerces

Looking into the legacy repo I can see that the fix for the StringBuffer issue was not brought into Geode. The fix was to specifically request the Oracle/Sun implementation. Since that implementation might not be available in the IBM JDK its probably not a great fix. On Fri, Aug 18, 2017 at 9:28

Re: [Discuss] Compatibility with Apache Xerces

It sounds like these changes ought to be ok. If there is no objection, I will go ahead and pull them in this afternoon. Thanks, Jared > On Aug 21, 2017, at 9:09 AM, Jacob Barrett wrote: > > Looking into the legacy repo I can see that the fix for the StringBuffer > issue was not brought into

[GitHub] geode pull request #726: GEODE-3474: protobuf auth with ExampleSecurityManag...

Github user asfgit closed the pull request at: https://github.com/apache/geode/pull/726 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabl

[GitHub] geode pull request #727: GEODE-3430: fix varargs usage

GitHub user kirklund opened a pull request: https://github.com/apache/geode/pull/727 GEODE-3430: fix varargs usage Also, general cleanup of ConnectCommandTest. You can merge this pull request into a Git repository by running: $ git pull https://github.com/kirklund/geode GEODE-

Re: Review Request 61758: GEODE-3471: Identify NPE in MBeanProxyFactory

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61758/#review183354 --- geode-core/src/main/java/org/apache/geode/management/internal/MBe

Re: Review Request 61758: GEODE-3471: Identify NPE in MBeanProxyFactory

> On Aug. 21, 2017, 5:55 p.m., Patrick Rhomberg wrote: > > geode-core/src/main/java/org/apache/geode/management/internal/MBeanProxyFactory.java > > Lines 83-84 (original), 81-85 (patched) > > > > > > I might be missin

[GitHub] geode pull request #728: Don't download geode 1.2 every time a build runs

GitHub user upthewaterspout opened a pull request: https://github.com/apache/geode/pull/728 Don't download geode 1.2 every time a build runs Setting the overwrite flag on the download tasks to false so that we don't download the old version of geode for every build. Than

Re: Revert gradle upgrade

I have checked in the update to move the Gradle Wrapper to 3.5.1, with the fix for Eclipse IDE, into the develop branch. Hopefully this time we won't need to revert it. --Mark On Tue, Jul 25, 2017 at 2:50 PM, Mark Bretl wrote: > Now that we have 1.2.0 out the door, would I be able to get someo

[GitHub] geode pull request #702: GEODE-3416: Reduce synchronization blockages in Soc...

Github user kohlmu-pivotal commented on a diff in the pull request: https://github.com/apache/geode/pull/702#discussion_r134328545 --- Diff: geode-core/src/main/java/org/apache/geode/internal/net/SocketCloser.java --- @@ -96,46 +99,55 @@ public int getMaxThreads() { return

Review Request 61802: GEODE-3445: Add gfsh connect option --skip-ssl-validation

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61802/ --- Review request for geode, Emily Yeh, Jared Stewart, Ken Howe, Kirk Lund, and Pat

geode-old-versions dependencies is slooooowwww

Why does "geode-old-versions" download previous versions every time I rebuild from the command-line? And why is it s slow? Can't we cache these like other dependencies? :geode-old-versions:compileJava UP-TO-DATE :geode-old-versions:downloadSHAtest120 Download https://www.apache.org/dist/geode/

[GitHub] geode pull request #725: GEODE-3470: Increased serial gateway sender token t...

Github user boglesby closed the pull request at: https://github.com/apache/geode/pull/725 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is ena

Re: geode-old-versions dependencies is slooooowwww

So I gave up after 10 minutes, killed my build and restarted it. Now it finished much faster. I had the same thing happen earlier today around 9:15am. "geode-old-versions" is definitely a problem now... either we're not fetching the previous versions correctly or the infra it's on is broken or we

[GitHub] geode pull request #728: Don't download geode 1.2 every time a build runs

Github user asfgit closed the pull request at: https://github.com/apache/geode/pull/728 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabl

Re: geode-old-versions dependencies is slooooowwww

Hi Kirk, I just pushed a fix for this. It should only download geode.1.2.0 the first time you build. -Dan On Mon, Aug 21, 2017 at 2:19 PM, Kirk Lund wrote: > Why does "geode-old-versions" download previous versions every time I > rebuild from the command-line? And why is it s slow? Can't w

Re: geode-old-versions dependencies is slooooowwww

Awesome! Thank you Dan! On Mon, Aug 21, 2017 at 2:26 PM, Dan Smith wrote: > Hi Kirk, > > I just pushed a fix for this. It should only download geode.1.2.0 the first > time you build. > > -Dan > > On Mon, Aug 21, 2017 at 2:19 PM, Kirk Lund wrote: > > > Why does "geode-old-versions" download prev

[GitHub] geode pull request #724: GEODE-3469: prevent zero pid from AvailablePid for ...

Github user kirklund closed the pull request at: https://github.com/apache/geode/pull/724 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is ena

[GitHub] geode issue #724: GEODE-3469: prevent zero pid from AvailablePid for tests

Github user kirklund commented on the issue: https://github.com/apache/geode/pull/724 Already merged in. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

Re: Review Request 61758: GEODE-3471: Identify NPE in MBeanProxyFactory

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61758/#review183397 --- Ship it! Ship It! - Patrick Rhomberg On Aug. 18, 2017, 9:55

Re: Review Request 61757: GEODE-2859: Fix ShowDeadlockDUnitTest

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61757/#review183396 --- Ship it! Ship It! - Patrick Rhomberg On Aug. 18, 2017, 9:40

Re: Review Request 61802: GEODE-3445: Add gfsh connect option --skip-ssl-validation

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61802/#review183398 --- Ship it! Ship It! - Kirk Lund On Aug. 21, 2017, 9:06 p.m., J

[GitHub] geode pull request #702: GEODE-3416: Reduce synchronization blockages in Soc...

Github user bschuchardt commented on a diff in the pull request: https://github.com/apache/geode/pull/702#discussion_r134339691 --- Diff: geode-core/src/main/java/org/apache/geode/internal/net/SocketCloser.java --- @@ -96,46 +99,55 @@ public int getMaxThreads() { return th

Re: Review Request 61758: GEODE-3471: Identify NPE in MBeanProxyFactory

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61758/#review183399 --- Ship it! Ship It! - Kirk Lund On Aug. 18, 2017, 9:55 p.m., J

Re: Review Request 61757: GEODE-2859: Fix ShowDeadlockDUnitTest

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61757/#review183400 --- Ship it! Ship It! - Kirk Lund On Aug. 18, 2017, 9:40 p.m., J

[GitHub] geode pull request #727: GEODE-3430: fix varargs usage

Github user asfgit closed the pull request at: https://github.com/apache/geode/pull/727 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabl

Re: Review Request 61802: GEODE-3445: Add gfsh connect option --skip-ssl-validation

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61802/#review183401 --- geode-core/src/main/java/org/apache/geode/management/internal/cli

Build failed in Jenkins: Geode-nightly #930

See -- [...truncated 123.55 KB...] :geode-common:integrationTest :geode-core:assemble :geode-core:checkMissedTests :geode-core:spotlessJavaCheck :geode-core:spotlessCheck :geode-core:test :ge

Re: Review Request 61802: GEODE-3445: Add gfsh connect option --skip-ssl-validation

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61802/ --- (Updated Aug. 21, 2017, 10:09 p.m.) Review request for geode, Emily Yeh, Jared

Re: geode-old-versions dependencies is slooooowwww

I am also in favor of skipping the download, but now I'm failing my build with All test reports at /.../build/reports/combined FAILURE: Build failed with an exception. * Where: Build file '/.../geode-old-versions/build.gradle' line: 60 * What went wrong: Execution failed for task ':geode-old-ve

Re: geode-old-versions dependencies is slooooowwww

On Mon, Aug 21, 2017 at 3:14 PM, Patrick Rhomberg wrote: > I am also in favor of skipping the download, but now I'm failing my build > Yes, but the important part is that it didn't download anything :) Sorry about that, it looks like I screwed something up. Can you pull and try again? -Dan

Re: geode-old-versions dependencies is slooooowwww

Victory! Thanks. On Mon, Aug 21, 2017 at 3:30 PM, Dan Smith wrote: > On Mon, Aug 21, 2017 at 3:14 PM, Patrick Rhomberg > wrote: > > > I am also in favor of skipping the download, but now I'm failing my build > > > > Yes, but the important part is that it didn't download anything :) > > Sorry a

[GitHub] geode pull request #729: GEODE-3461: increase test timeouts

GitHub user kirklund opened a pull request: https://github.com/apache/geode/pull/729 GEODE-3461: increase test timeouts You can merge this pull request into a Git repository by running: $ git pull https://github.com/kirklund/geode GEODE-3461-increase-timeouts Alternatively yo

[GitHub] geode pull request #729: GEODE-3461: increase test timeouts

Github user jaredjstewart commented on a diff in the pull request: https://github.com/apache/geode/pull/729#discussion_r134348604 --- Diff: geode-core/src/test/java/org/apache/geode/internal/process/AbstractProcessStreamReaderIntegrationTest.java --- @@ -149,7 +147,7 @@ protected

[Spring CI] Spring Data GemFire > Nightly-ApacheGeode > #654 was SUCCESSFUL (with 2027 tests)

--- Spring Data GemFire > Nightly-ApacheGeode > #654 was successful. --- Scheduled 2029 tests in total. https://build.spring.io/browse/SGF-NAG-654/ -- This

[GitHub] geode pull request #729: GEODE-3461: increase test timeouts

Github user kirklund commented on a diff in the pull request: https://github.com/apache/geode/pull/729#discussion_r134352194 --- Diff: geode-core/src/test/java/org/apache/geode/internal/process/AbstractProcessStreamReaderIntegrationTest.java --- @@ -149,7 +147,7 @@ protected void

[geode-native] branch develop updated: GEODE-3497: Fix failing test on Solaris SPARC

This is an automated email from the ASF dual-hosted git repository. jbarrett pushed a commit to branch develop in repository https://gitbox.apache.org/repos/asf/geode-native.git The following commit(s) were added to refs/heads/develop by this push: new cc6dafe GEODE-3497: Fix failing test

[GitHub] geode pull request #730: GEODE-3472: Remove a great deal of commented-out co...

GitHub user PurelyApplied opened a pull request: https://github.com/apache/geode/pull/730 GEODE-3472: Remove a great deal of commented-out code. * Correct imports in touched files * Correct several misspellings * Removed redundant modifier and specifiers * Corrected modif

[GitHub] geode pull request #716: GEODE-3406: Locator accepts Protobuf requests

Github user galen-pivotal commented on a diff in the pull request: https://github.com/apache/geode/pull/716#discussion_r134023037 --- Diff: geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/ServerConnectionFactory.java --- @@ -49,20 +48,13 @@ private synchroniz

[GitHub] geode pull request #716: GEODE-3406: Locator accepts Protobuf requests

Github user galen-pivotal commented on a diff in the pull request: https://github.com/apache/geode/pull/716#discussion_r134024644 --- Diff: geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/TcpServerFactory.java --- @@ -0,0 +1,39 @@ +package org.apache.geod

[GitHub] geode pull request #716: GEODE-3406: Locator accepts Protobuf requests

Github user galen-pivotal commented on a diff in the pull request: https://github.com/apache/geode/pull/716#discussion_r134026218 --- Diff: geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/TcpServerFactory.java --- @@ -0,0 +1,39 @@ +package org.apache.geod

[GitHub] geode pull request #716: GEODE-3406: Locator accepts Protobuf requests

Github user galen-pivotal commented on a diff in the pull request: https://github.com/apache/geode/pull/716#discussion_r134358612 --- Diff: geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/operations/GetAvailableServersOperationHandler.java --- @@ -50,51 +37,23 @@

[GitHub] geode pull request #716: GEODE-3406: Locator accepts Protobuf requests

Github user galen-pivotal commented on a diff in the pull request: https://github.com/apache/geode/pull/716#discussion_r134022599 --- Diff: geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/ClientProtoclMessageHandlerLoader.java --- @@ -0,0 +1,64 @@ +/*

[GitHub] geode pull request #716: GEODE-3406: Locator accepts Protobuf requests

Github user galen-pivotal commented on a diff in the pull request: https://github.com/apache/geode/pull/716#discussion_r134270934 --- Diff: geode-core/src/test/java/org/apache/geode/test/dunit/standalone/DUnitLauncher.java --- @@ -297,6 +297,8 @@ public Object call() throws IOExce

Re: Native commit messages going to dev instead of commit list

Oops...that was my copy-paste error on the request. I have opened a new ticket to update the commit mail, https://issues.apache.org/jira/browse/INFRA-14924. --Mark On Thu, Aug 17, 2017 at 1:43 PM, Dan Smith wrote: > Was: Re: [geode-native] branch develop updated: GEODE-3455: Update Solaris > bu

Re: Native commit messages going to dev instead of commit list

Mark, I opened https://issues.apache.org/jira/browse/INFRA-14900 last week. Do you know if we can get permissions to edit repo settings ourselves? I’d like to change the description so it doesn’t say mirror. Hate interrupting infra for every minor change we may have along the way. Thanks, Jake

Build failed in Jenkins: Geode-nightly #931

See Changes: [ukohlmeyer] GEODE-3474: protobuf auth with ExampleSecurityManager. This closes #726 [klund] GEODE-3322: delete empty javadocs to fix javadoc warning [abaker] GEODE-3495 Bump log4j to v2.8.2 [mbretl]