----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61758/#review183354 -----------------------------------------------------------
geode-core/src/main/java/org/apache/geode/management/internal/MBeanProxyFactory.java Lines 83-84 (original), 81-85 (patched) <https://reviews.apache.org/r/61758/#comment259386> I might be missing context, but this just a spike to see which of these methods is returning `null`, yeah? Is receiving `null` in this context indicative of failure, or should there be some null checks and handling? Should we formally check against null and throw instead of allowing an NPE to bubble up? Would that be a more meaningful error than an NPE? - Patrick Rhomberg On Aug. 18, 2017, 9:55 p.m., Jared Stewart wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61758/ > ----------------------------------------------------------- > > (Updated Aug. 18, 2017, 9:55 p.m.) > > > Review request for geode, Emily Yeh, Jared Stewart, Ken Howe, Kirk Lund, and > Patrick Rhomberg. > > > Repository: geode > > > Description > ------- > > GEODE-3471: Identify NPE in MBeanProxyFactory > > > Diffs > ----- > > > geode-core/src/main/java/org/apache/geode/management/internal/MBeanProxyFactory.java > 0cce0be22323cf47dd6f90691bb068b3aaa77372 > > > Diff: https://reviews.apache.org/r/61758/diff/1/ > > > Testing > ------- > > Precheckin running > > > Thanks, > > Jared Stewart > >
