[GitHub] geode pull request #532: GEODE-2950: Adding validation checks on create Luce...

2017-05-24 Thread DivineEnder
GitHub user DivineEnder opened a pull request: https://github.com/apache/geode/pull/532 GEODE-2950: Adding validation checks on create Lucene index parameter… … names Thank you for submitting a contribution to Apache Geode. In order to streamline the review of t

[jira] [Commented] (GEODE-2950) Lucene index names should be restricted to valid region names since the index name becomes part of a region

2017-05-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2950?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16023875#comment-16023875 ] ASF GitHub Bot commented on GEODE-2950: --- GitHub user DivineEnder opened a pull reque

[GitHub] geode issue #532: GEODE-2950: Adding validation checks on create Lucene inde...

2017-05-24 Thread DivineEnder
Github user DivineEnder commented on the issue: https://github.com/apache/geode/pull/532 @ladyVader @nabarunnag @boglesby @jhuynh1 @upthewaterspout @gesterzhou --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your proj

[jira] [Commented] (GEODE-2950) Lucene index names should be restricted to valid region names since the index name becomes part of a region

2017-05-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2950?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16023877#comment-16023877 ] ASF GitHub Bot commented on GEODE-2950: --- Github user DivineEnder commented on the is

[GitHub] geode issue #525: GEODE-2962: Add more messages for compact disk-store

2017-05-24 Thread AkihiroKitada
Github user AkihiroKitada commented on the issue: https://github.com/apache/geode/pull/525 Hello Darrel, I'm sorry to make this PR confused. I updated this PR from other environment and it made this PR cause some differences in terms of my fork. I'll close this PR and

[GitHub] geode pull request #525: GEODE-2962: Add more messages for compact disk-stor...

2017-05-24 Thread AkihiroKitada
Github user AkihiroKitada closed the pull request at: https://github.com/apache/geode/pull/525 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature i

[jira] [Assigned] (GEODE-2944) lucene queries on String values (vs. objects) requires obscure/undocumented defaultField (__REGION_VALUE_FIELD)

2017-05-24 Thread David Anuta (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2944?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Anuta reassigned GEODE-2944: -- Assignee: David Anuta > lucene queries on String values (vs. objects) requires obscure/undocume

[jira] [Commented] (GEODE-2962) Need more friendly locator's log message when executing "gfsh compact disk-store" command

2017-05-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16023878#comment-16023878 ] ASF GitHub Bot commented on GEODE-2962: --- Github user AkihiroKitada commented on the

[jira] [Commented] (GEODE-2962) Need more friendly locator's log message when executing "gfsh compact disk-store" command

2017-05-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16023879#comment-16023879 ] ASF GitHub Bot commented on GEODE-2962: --- Github user AkihiroKitada closed the pull r

[jira] [Updated] (GEODE-2981) Fix the line feed code of the test expected value

2017-05-24 Thread Bruce Schuchardt (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2981?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruce Schuchardt updated GEODE-2981: Component/s: management > Fix the line feed code of the test expected value > --

[jira] [Commented] (GEODE-2981) Fix the line feed code of the test expected value

2017-05-24 Thread Bruce Schuchardt (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16023895#comment-16023895 ] Bruce Schuchardt commented on GEODE-2981: - This test is also consistently failing

Geode Nightly build is consistently RED

2017-05-24 Thread Kirk Lund
Geode Nightly build is staying consistently RED... each night the tests that fail vary some. Do we still want to not add FlakyTest category to these tests and just live with a RED nightly build? What do you all want to do? Any ideas what to do to get it consistently GREEN? The only way I know to

[GitHub] geode issue #515: GEODE-240: Remove deprecated methods on TransactionEvent

2017-05-24 Thread shankarh
Github user shankarh commented on the issue: https://github.com/apache/geode/pull/515 Thanks @ameybarve15 @dschneider-pivotal @davinash for the review. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[jira] [Commented] (GEODE-240) Remove deprecated methods on TransactionEvent

2017-05-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16023899#comment-16023899 ] ASF GitHub Bot commented on GEODE-240: -- Github user shankarh commented on the issue:

[GitHub] geode issue #507: GEODE-231 : Remove deprecated AttributesMutator.setCacheLi...

2017-05-24 Thread shankarh
Github user shankarh commented on the issue: https://github.com/apache/geode/pull/507 Thanks @ameybarve15 @dschneider-pivotal for review. Do I need to resubmit this PR after resolving conflicts? or we resolve conflicts while merging? --- If your project is set up for it, you

Re: Geode Nightly build is consistently RED

2017-05-24 Thread Kirk Lund
If other people are ignoring the results of the flakyTest target and that's the reason that people do not want to add FlakyTest category to tests that aren't currently marked with FlakyTest then here's my proposal... we delete FlakyTest category (well actually just rename it) and replace it with Te

[jira] [Commented] (GEODE-231) Remove deprecated AttributesMutator.setCacheListener

2017-05-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16023905#comment-16023905 ] ASF GitHub Bot commented on GEODE-231: -- Github user shankarh commented on the issue:

[GitHub] geode pull request #533: GEODE-2944: Added __REGION_VALUE_FIELD explanation ...

2017-05-24 Thread DivineEnder
GitHub user DivineEnder opened a pull request: https://github.com/apache/geode/pull/533 GEODE-2944: Added __REGION_VALUE_FIELD explanation to Lucene create i… …ndex help Thank you for submitting a contribution to Apache Geode. In order to streamline the review o

[jira] [Commented] (GEODE-2944) lucene queries on String values (vs. objects) requires obscure/undocumented defaultField (__REGION_VALUE_FIELD)

2017-05-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16023924#comment-16023924 ] ASF GitHub Bot commented on GEODE-2944: --- GitHub user DivineEnder opened a pull reque

[GitHub] geode issue #533: GEODE-2944: Added __REGION_VALUE_FIELD explanation to Luce...

2017-05-24 Thread DivineEnder
Github user DivineEnder commented on the issue: https://github.com/apache/geode/pull/533 @ladyVader @nabarunnag @boglesby @jhuynh1 @upthewaterspout @gesterzhou --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your proj

[jira] [Commented] (GEODE-2944) lucene queries on String values (vs. objects) requires obscure/undocumented defaultField (__REGION_VALUE_FIELD)

2017-05-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16023926#comment-16023926 ] ASF GitHub Bot commented on GEODE-2944: --- Github user DivineEnder commented on the is

[jira] [Commented] (GEODE-2913) Update Lucene documentation

2017-05-24 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16023929#comment-16023929 ] ASF subversion and git services commented on GEODE-2913: Commit 09

[GitHub] geode issue #518: GEODE-2913 Update Lucene index documentation

2017-05-24 Thread karensmolermiller
Github user karensmolermiller commented on the issue: https://github.com/apache/geode/pull/518 Closed by merge: 096c22d5c73dc609651caf2887b4d95f162230ad. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project doe

[GitHub] geode pull request #518: GEODE-2913 Update Lucene index documentation

2017-05-24 Thread karensmolermiller
Github user karensmolermiller closed the pull request at: https://github.com/apache/geode/pull/518 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the featu

[jira] [Commented] (GEODE-2913) Update Lucene documentation

2017-05-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16023933#comment-16023933 ] ASF GitHub Bot commented on GEODE-2913: --- Github user karensmolermiller closed the pu

[jira] [Commented] (GEODE-2913) Update Lucene documentation

2017-05-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16023932#comment-16023932 ] ASF GitHub Bot commented on GEODE-2913: --- Github user karensmolermiller commented on

What to do with the geode-spark-connector

2017-05-24 Thread Dan Smith
Our geode-spark-connector needs some work. It's currently building against geode 1.0.0-incubating, because it has it's own separate build process. It's also somewhat out of date, we're building against spark 1.3. Is anyone actually using the spark connector? I think we need to get the spark connec

Review Request 59562: GEODE-2941 Pulse documentation is outdated

2017-05-24 Thread Dave Barnes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59562/ --- Review request for geode, Jinmei Liao and Joey McAllister. Repository: geode

Re: What to do with the geode-spark-connector

2017-05-24 Thread Anilkumar Gingade
The spark has come a long way after 1.3...The connector needs to be upgraded to be meaningful +1 for A The existing code could be used as a reference in the future... -Anil. On Wed, May 24, 2017 at 5:17 PM, Dan Smith wrote: > Our geode-spark-connector needs some work. It's currently buildi

Re: What to do with the geode-spark-connector

2017-05-24 Thread Jianxia Chen
I prefer option A: Move it into it's own repository, with it's own release cycle. On Wed, May 24, 2017 at 5:17 PM, Dan Smith wrote: > Our geode-spark-connector needs some work. It's currently building against > geode 1.0.0-incubating, because it has it's own separate build process. > It's also s

Re: Review Request 59404: GEODE-2939: make sure event tracker is initiated from the GII provider

2017-05-24 Thread Eric Shu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59404/ --- (Updated May 25, 2017, 12:51 a.m.) Review request for geode, anilkumar gingade,

Re: Review Request 59404: GEODE-2939: make sure event tracker is initiated from the GII provider

2017-05-24 Thread Eric Shu
> On May 24, 2017, 4:59 p.m., Darrel Schneider wrote: > > geode-core/src/main/java/org/apache/geode/internal/cache/CreateRegionProcessor.java > > Lines 209 (patched) > > > > > > Why is this Map ? > > I can see o

Re: Review Request 59404: GEODE-2939: make sure event tracker is initiated from the GII provider

2017-05-24 Thread Eric Shu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59404/#review175971 --- geode-core/src/main/java/org/apache/geode/internal/cache/BucketRe

[jira] [Created] (GEODE-2986) Need not to log message when executing "gfsh compact disk-store" command successfully

2017-05-24 Thread Akihiro Kitada (JIRA)
Akihiro Kitada created GEODE-2986: - Summary: Need not to log message when executing "gfsh compact disk-store" command successfully Key: GEODE-2986 URL: https://issues.apache.org/jira/browse/GEODE-2986

Re: What to do with the geode-spark-connector

2017-05-24 Thread Kirk Lund
+1 for A On Wed, May 24, 2017 at 5:50 PM, Jianxia Chen wrote: > I prefer option A: Move it into it's own repository, with it's own release > cycle. > > On Wed, May 24, 2017 at 5:17 PM, Dan Smith wrote: > > > Our geode-spark-connector needs some work. It's currently building > against > > geode

[GitHub] geode pull request #534: GEODE-2962: Added null check to log message

2017-05-24 Thread AkihiroKitada
GitHub user AkihiroKitada opened a pull request: https://github.com/apache/geode/pull/534 GEODE-2962: Added null check to log message Just log message if "notExecutedMembers" is not null and not empty. Thank you for submitting a contribution to Apache Geode. In orde

[jira] [Commented] (GEODE-2962) Need more friendly locator's log message when executing "gfsh compact disk-store" command

2017-05-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16024028#comment-16024028 ] ASF GitHub Bot commented on GEODE-2962: --- GitHub user AkihiroKitada opened a pull req

[GitHub] geode issue #534: GEODE-2986: Added null check to log message

2017-05-24 Thread AkihiroKitada
Github user AkihiroKitada commented on the issue: https://github.com/apache/geode/pull/534 Create by mistake. Close this one. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enab

[GitHub] geode pull request #534: GEODE-2986: Added null check to log message

2017-05-24 Thread AkihiroKitada
Github user AkihiroKitada closed the pull request at: https://github.com/apache/geode/pull/534 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature i

[jira] [Commented] (GEODE-2986) Need not to log message when executing "gfsh compact disk-store" command successfully

2017-05-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16024032#comment-16024032 ] ASF GitHub Bot commented on GEODE-2986: --- Github user AkihiroKitada closed the pull r

[jira] [Commented] (GEODE-2986) Need not to log message when executing "gfsh compact disk-store" command successfully

2017-05-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16024031#comment-16024031 ] ASF GitHub Bot commented on GEODE-2986: --- Github user AkihiroKitada commented on the

[GitHub] geode issue #534: GEODE-2986: Added null check to log message

2017-05-24 Thread AkihiroKitada
Github user AkihiroKitada commented on the issue: https://github.com/apache/geode/pull/534 I create this PR by mistake. Close this PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this fea

[jira] [Commented] (GEODE-2986) Need not to log message when executing "gfsh compact disk-store" command successfully

2017-05-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16024039#comment-16024039 ] ASF GitHub Bot commented on GEODE-2986: --- Github user AkihiroKitada commented on the

[GitHub] geode pull request #535: GEODE-2986: Remove redundant log message

2017-05-24 Thread AkihiroKitada
GitHub user AkihiroKitada opened a pull request: https://github.com/apache/geode/pull/535 GEODE-2986: Remove redundant log message Just log message if "notExecutedMembers" is not null and not empty. Thank you for submitting a contribution to Apache Geode. In order t

[jira] [Commented] (GEODE-2986) Need not to log message when executing "gfsh compact disk-store" command successfully

2017-05-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16024064#comment-16024064 ] ASF GitHub Bot commented on GEODE-2986: --- GitHub user AkihiroKitada opened a pull req

[jira] [Resolved] (GEODE-2962) Need more friendly locator's log message when executing "gfsh compact disk-store" command

2017-05-24 Thread Akihiro Kitada (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2962?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Akihiro Kitada resolved GEODE-2962. --- Resolution: Duplicate Duplicate of GEODE-2986 > Need more friendly locator's log message when

Re: Review Request 59542: GEODE-2974: rename ResultBuilder methods: GemFire -> Geode

2017-05-24 Thread Jinmei Liao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59542/#review176037 --- I really don't think this set of changes is necessary, there is no

Re: What to do with the geode-spark-connector

2017-05-24 Thread Jared Stewart
+1 for A On May 24, 2017 6:48 PM, "Kirk Lund" wrote: > +1 for A > > On Wed, May 24, 2017 at 5:50 PM, Jianxia Chen wrote: > > > I prefer option A: Move it into it's own repository, with it's own > release > > cycle. > > > > On Wed, May 24, 2017 at 5:17 PM, Dan Smith wrote: > > > > > Our geode-s

<    1   2