----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59542/#review176037 -----------------------------------------------------------
I really don't think this set of changes is necessary, there is no attempt changing the internal method name from using "gemfire" to using "geode" at all. Just my 2 cents. - Jinmei Liao On May 24, 2017, 10:20 p.m., Ken Howe wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59542/ > ----------------------------------------------------------- > > (Updated May 24, 2017, 10:20 p.m.) > > > Review request for geode, Emily Yeh, Jinmei Liao, Jared Stewart, Kirk Lund, > and Patrick Rhomberg. > > > Repository: geode > > > Description > ------- > > Change GemFire to Geode in method names and message string > > This is change to simply correct the Gfsh command error strings where > "GemFire" appears. With additional work on Gfsh command error handling > pending (see GEODE-2984), no attempt has been made within the scope of this > issue to reorganize or otherwise improve Gfsh command error messages. > > > Diffs > ----- > > > geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/ClientCommands.java > 18940fc0c6c0f36a7dd5cab5723d426d80df3cb9 > > geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/ConfigCommands.java > 6d3f50ff2bcdf9d0450dd40a8defb83c2f2f6e04 > > geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/CreateAlterDestroyRegionCommands.java > b8ebc4917d88ce089ec2a19d606e004c1e5c6b33 > > geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/DataCommands.java > a38e54504e949905f222d9891f624e373219364b > > geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/DeployCommands.java > 4018beb8dfbd4bb639aec559991452226f15c908 > > geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/DiskStoreCommands.java > 4232d91edc9a74db144d49542d79f7cfd9f4a98b > > geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/DurableClientCommands.java > bcbfcf0ca72876dbfb3d41613159aa051726870e > > geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/ExportImportClusterConfigurationCommands.java > ea101826493bfbc9211b4c673c596d7514a7f431 > > geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/ExportLogsCommand.java > b824bc915d453defe1c665eb7811a782f2c72fdf > > geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/ExportLogsInterceptor.java > 5f2184889d28f441eb639d7ddf4ec2b7abfa293b > > geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/FunctionCommands.java > 2007e4af516274ac815cc3b06b9928f1aaed313f > > geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/IndexCommands.java > a4ba64c608f184fb130eb5ca3a05822f6cf82818 > > geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/LauncherLifecycleCommands.java > 74acfd6e03613ac4d0c62fcdd4ea859d1c74d2f2 > > geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/MemberCommands.java > 415dd691cc6ed14bc67626881eecf65d5e446c99 > > geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/MiscellaneousCommands.java > 0d714f4c295e2aded0c0fd28bbf4f72ffcdd14a7 > > geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/PDXCommands.java > 0ce8ec272eee9f07a05aa0ac478e136163ee41e6 > > geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/QueueCommands.java > 6208adb63cc29f213c035849c78c3809f61b3f16 > > geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/RegionCommands.java > 561d4b8514c5b4500bf870e0b9d0ef3bcdbaf40d > > geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/ShellCommands.java > ad344ff598db5474846d1b6b334d377e01c5fbd7 > > geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/WanCommands.java > feeb3533e84fafbf22e5f9283690fe2ef0edf27e > > geode-core/src/main/java/org/apache/geode/management/internal/cli/domain/DataCommandResult.java > fe88fc98d397fa748f8f54b900b1511eb114c0b6 > > geode-core/src/main/java/org/apache/geode/management/internal/cli/remote/CommandProcessor.java > c2c6e1425d71af9d2ea59046b17afd70ad30dd68 > > geode-core/src/main/java/org/apache/geode/management/internal/cli/result/ResultBuilder.java > 6332540aa4ff6d210ed7f3ba167057de9a0a5023 > > geode-core/src/main/java/org/apache/geode/management/internal/cli/shell/GfshExecutionStrategy.java > 2b39bedd1bcceef50e3f4933e17581048142a29b > > geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/cli/LuceneIndexCommands.java > 5e17f6e55e6726f22cc39ddaba1ec608ca5cab9d > > > Diff: https://reviews.apache.org/r/59542/diff/1/ > > > Testing > ------- > > precheckin is running > > > Thanks, > > Ken Howe > >
