> On May 24, 2017, 4:59 p.m., Darrel Schneider wrote: > > geode-core/src/main/java/org/apache/geode/internal/cache/CreateRegionProcessor.java > > Lines 209 (patched) > > <https://reviews.apache.org/r/59404/diff/3/?file=1730477#file1730477line215> > > > > Why is this Map <?,?> ? > > I can see on EventTracker.recordState we have: Map<ThreadIdentifier, > > EventSeqnoHolder> > > > > But then on LocalRegion.recordEventState we just have "Map". Would it > > be hard to fix this to consistently use Map<ThreadIdentifier, > > EventSeqnoHolder>?
Will not be able to change the LocalRegion impl as HARegionQueue overrides the LocalRegion.recordEventState, and it does not uses Map<ThreadIdentifier, EventSeqnoHolder>. - Eric ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59404/#review175956 ----------------------------------------------------------- On May 25, 2017, 12:51 a.m., Eric Shu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59404/ > ----------------------------------------------------------- > > (Updated May 25, 2017, 12:51 a.m.) > > > Review request for geode, anilkumar gingade, Darrel Schneider, and Lynn > Gallinat. > > > Bugs: GEODE-2939 > https://issues.apache.org/jira/browse/GEODE-2939 > > > Repository: geode > > > Description > ------- > > Event tracker initilization for bucket region is delayed until after GII, and > will be initialized from the GII provider. > > > Diffs > ----- > > geode-core/src/main/java/org/apache/geode/internal/cache/BucketRegion.java > 886d678 > > geode-core/src/main/java/org/apache/geode/internal/cache/CacheDistributionAdvisee.java > e4a7957 > > geode-core/src/main/java/org/apache/geode/internal/cache/CreateRegionProcessor.java > c1d1e77 > > geode-core/src/main/java/org/apache/geode/internal/cache/DistributedRegion.java > 485835b > geode-core/src/main/java/org/apache/geode/internal/cache/EventTracker.java > 2c86aed > > geode-core/src/main/java/org/apache/geode/internal/cache/InitialImageOperation.java > fb5f0cf > > geode-core/src/test/java/org/apache/geode/internal/cache/EventTrackerDUnitTest.java > 3faf41f > > > Diff: https://reviews.apache.org/r/59404/diff/4/ > > > Testing > ------- > > precheckin. > > > Thanks, > > Eric Shu > >
