Re: Review Request 59850: GEODE-3023: TcpServer thread can be blocked in processRequest

2017-06-09 Thread Udo Kohlmeyer
> On June 9, 2017, 1:06 a.m., Galen O'Sullivan wrote: > > geode-core/src/test/java/org/apache/geode/distributed/internal/tcpserver/TCPServerSSLJUnitTest.java > > Lines 82 (patched) > > > > > > I'm missing the time del

Re: Review Request 59850: GEODE-3023: TcpServer thread can be blocked in processRequest

2017-06-08 Thread Galen O'Sullivan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59850/#review177427 --- Fix it, then Ship it! I had a couple of minor comments about th

Re: Review Request 59850: GEODE-3023: TcpServer thread can be blocked in processRequest

2017-06-07 Thread Udo Kohlmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59850/ --- (Updated June 8, 2017, 12:20 a.m.) Review request for geode, Alexander Murmann,

Re: Review Request 59850: GEODE-3023: TcpServer thread can be blocked in processRequest

2017-06-07 Thread Udo Kohlmeyer
> On June 7, 2017, 11:48 p.m., Hitesh Khamesra wrote: > > geode-core/src/main/java/org/apache/geode/distributed/internal/tcpserver/TcpServer.java > > Line 171 (original) > > > > > > Is that code moved inside/will nev

Re: Review Request 59850: GEODE-3023: TcpServer thread can be blocked in processRequest

2017-06-07 Thread Hitesh Khamesra
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59850/#review177256 --- Fix it, then Ship it! Ship It! geode-core/src/main/java/org/a

Re: Review Request 59850: GEODE-3023: TcpServer thread can be blocked in processRequest

2017-06-07 Thread Galen O'Sullivan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59850/#review177224 --- Code looks good. I haven't taken a particularly thorough look thro

Re: Review Request 59850: GEODE-3023: TcpServer thread can be blocked in processRequest

2017-06-06 Thread Bruce Schuchardt
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59850/#review177121 --- Ship it! Ship It! - Bruce Schuchardt On June 6, 2017, 11:21

Re: Review Request 59850: GEODE-3023: TcpServer thread can be blocked in processRequest

2017-06-06 Thread Udo Kohlmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59850/ --- (Updated June 6, 2017, 11:21 p.m.) Review request for geode, Bruce Schuchardt,

Re: Review Request 59850: GEODE-3023: TcpServer thread can be blocked in processRequest

2017-06-06 Thread Bruce Schuchardt
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59850/#review177094 --- geode-core/src/test/java/org/apache/geode/distributed/internal/tc

Re: Review Request 59850: GEODE-3023: TcpServer thread can be blocked in processRequest

2017-06-06 Thread Udo Kohlmeyer
> On June 6, 2017, 6:54 p.m., Anthony Baker wrote: > > geode-core/src/main/java/org/apache/geode/distributed/internal/tcpserver/TcpServer.java > > Line 354 (original), 356 (patched) > > > > > > Did you mean to leave

Re: Review Request 59850: GEODE-3023: TcpServer thread can be blocked in processRequest

2017-06-06 Thread Anthony Baker
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59850/#review177068 --- geode-core/src/main/java/org/apache/geode/distributed/internal/tc

Review Request 59850: GEODE-3023: TcpServer thread can be blocked in processRequest

2017-06-06 Thread Udo Kohlmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59850/ --- Review request for geode, Bruce Schuchardt, Galen O'Sullivan, and Hitesh Khamesr