> On June 9, 2017, 1:06 a.m., Galen O'Sullivan wrote: > > geode-core/src/test/java/org/apache/geode/distributed/internal/tcpserver/TCPServerSSLJUnitTest.java > > Lines 82 (patched) > > <https://reviews.apache.org/r/59850/diff/2/?file=1743382#file1743382line82> > > > > I'm missing the time delay here. Can you show me where it gets delayed? > > > > ... ah, it looks like you copied this from `TcpServerJUnitTest`. Would > > you mind renaming this function to something that makes more sense in this > > context?
There used to be a delayed TcpServer, the method name did not change. Updating to something more meaningful. > On June 9, 2017, 1:06 a.m., Galen O'Sullivan wrote: > > geode-core/src/test/java/org/apache/geode/distributed/internal/tcpserver/TCPServerSSLJUnitTest.java > > Lines 133 (patched) > > <https://reviews.apache.org/r/59850/diff/2/?file=1743382#file1743382line133> > > > > We can reasonably set a very small timeout here, even less than the > > timeout of the socket (since we're mocking it). That (and setting the > > timeout to some silly number like 31337) would also help us verify that > > we're mocking correctly. This is the timeout on the client pool connection. Has no bearing on this test. > On June 9, 2017, 1:06 a.m., Galen O'Sullivan wrote: > > geode-core/src/test/java/org/apache/geode/distributed/internal/tcpserver/TCPServerSSLJUnitTest.java > > Lines 143 (patched) > > <https://reviews.apache.org/r/59850/diff/2/?file=1743382#file1743382line143> > > > > What's the GemStoneAddition about? Legacy code reuse. Not required anymore. It's mocked away. - Udo ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59850/#review177427 ----------------------------------------------------------- On June 8, 2017, 12:20 a.m., Udo Kohlmeyer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59850/ > ----------------------------------------------------------- > > (Updated June 8, 2017, 12:20 a.m.) > > > Review request for geode, Alexander Murmann, Bruce Schuchardt, Galen > O'Sullivan, Hitesh Khamesra, and Brian Rowe. > > > Repository: geode > > > Description > ------- > > Moved the socket.setSoTimeout setting to be before the SSL handshake. This is > to avoid the timeout to never be set in the case of a SSLException. Added a > test to test that the socket timeout is correctly set upon failure within the > SSL configuration and handshake. > > > Diffs > ----- > > > geode-core/src/main/java/org/apache/geode/distributed/internal/tcpserver/TcpServer.java > 86fe53261 > > geode-core/src/test/java/org/apache/geode/distributed/internal/tcpserver/TCPServerSSLJUnitTest.java > PRE-CREATION > > geode-core/src/test/java/org/apache/geode/distributed/internal/tcpserver/TcpServerJUnitTest.java > 7c7a2b376 > > geode-core/src/test/java/org/apache/geode/internal/net/DelaySocketCreator.java > PRE-CREATION > > > Diff: https://reviews.apache.org/r/59850/diff/2/ > > > Testing > ------- > > Junit test - done > precheckin - done > > > Thanks, > > Udo Kohlmeyer > >
