> On June 7, 2017, 11:48 p.m., Hitesh Khamesra wrote: > > geode-core/src/main/java/org/apache/geode/distributed/internal/tcpserver/TcpServer.java > > Line 171 (original) > > <https://reviews.apache.org/r/59850/diff/2/?file=1743381#file1743381line198> > > > > Is that code moved inside/will never happen?
With the changes we made in the new SSL configuration, we have a SocketCreatorFactory that will ensure that we only ever have 1 SocketCreator per SecureCommunicationChannel (LOCATOR,SERVER,CLUSTER,etc..) So in short, this will not happen anymore - Udo ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59850/#review177256 ----------------------------------------------------------- On June 7, 2017, 11:32 p.m., Udo Kohlmeyer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59850/ > ----------------------------------------------------------- > > (Updated June 7, 2017, 11:32 p.m.) > > > Review request for geode, Alexander Murmann, Bruce Schuchardt, Galen > O'Sullivan, Hitesh Khamesra, and Brian Rowe. > > > Repository: geode > > > Description > ------- > > Moved the socket.setSoTimeout setting to be before the SSL handshake. This is > to avoid the timeout to never be set in the case of a SSLException. Added a > test to test that the socket timeout is correctly set upon failure within the > SSL configuration and handshake. > > > Diffs > ----- > > > geode-core/src/main/java/org/apache/geode/distributed/internal/tcpserver/TcpServer.java > 86fe53261 > > geode-core/src/test/java/org/apache/geode/distributed/internal/tcpserver/TCPServerSSLJUnitTest.java > PRE-CREATION > > geode-core/src/test/java/org/apache/geode/distributed/internal/tcpserver/TcpServerJUnitTest.java > 7c7a2b376 > > geode-core/src/test/java/org/apache/geode/internal/net/DelaySocketCreator.java > PRE-CREATION > > > Diff: https://reviews.apache.org/r/59850/diff/2/ > > > Testing > ------- > > Junit test - done > precheckin - in progress > > > Thanks, > > Udo Kohlmeyer > >
