----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59850/ -----------------------------------------------------------
(Updated June 6, 2017, 11:21 p.m.) Review request for geode, Bruce Schuchardt, Galen O'Sullivan, and Hitesh Khamesra. Changes ------- Removing TODO and System.err Repository: geode Description ------- Moved the socket.setSoTimeout setting to be before the SSL handshake. This is to avoid the timeout to never be set in the case of a SSLException. Added a test to test that the socket timeout is correctly set upon failure within the SSL configuration and handshake. Diffs (updated) ----- geode-core/src/main/java/org/apache/geode/distributed/internal/tcpserver/TcpServer.java 86fe53261 geode-core/src/test/java/org/apache/geode/distributed/internal/tcpserver/TCPServerSSLJUnitTest.java PRE-CREATION geode-core/src/test/java/org/apache/geode/distributed/internal/tcpserver/TcpServerJUnitTest.java 7c7a2b376 geode-core/src/test/java/org/apache/geode/internal/net/DelaySocketCreator.java PRE-CREATION Diff: https://reviews.apache.org/r/59850/diff/2/ Changes: https://reviews.apache.org/r/59850/diff/1-2/ Testing ------- Junit test - done precheckin - in progress Thanks, Udo Kohlmeyer
