[GitHub] geode pull request #429: Geode-2686

2017-03-22 Thread jaredjstewart
Github user jaredjstewart closed the pull request at: https://github.com/apache/geode/pull/429 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature i

[GitHub] geode pull request #429: Geode-2686

2017-03-21 Thread jaredjstewart
Github user jaredjstewart commented on a diff in the pull request: https://github.com/apache/geode/pull/429#discussion_r107221701 --- Diff: geode-core/src/test/java/org/apache/geode/internal/JarDeployerIntegrationTest.java --- @@ -126,14 +111,16 @@ public void testDeployToInvalidD

[GitHub] geode pull request #429: Geode-2686

2017-03-21 Thread jaredjstewart
Github user jaredjstewart commented on a diff in the pull request: https://github.com/apache/geode/pull/429#discussion_r107195082 --- Diff: geode-core/src/test/java/org/apache/geode/internal/JarDeployerIntegrationTest.java --- @@ -144,40 +131,99 @@ public void run() { T

[GitHub] geode pull request #429: Geode-2686

2017-03-21 Thread jaredjstewart
Github user jaredjstewart commented on a diff in the pull request: https://github.com/apache/geode/pull/429#discussion_r107195612 --- Diff: geode-core/src/test/java/org/apache/geode/internal/ClassPathLoaderTest.java --- @@ -65,6 +65,26 @@ public void testLatestExists() throws Excep

[GitHub] geode pull request #429: Geode-2686

2017-03-21 Thread jaredjstewart
Github user jaredjstewart commented on a diff in the pull request: https://github.com/apache/geode/pull/429#discussion_r107194282 --- Diff: geode-core/src/test/java/org/apache/geode/internal/JarDeployerIntegrationTest.java --- @@ -126,14 +111,16 @@ public void testDeployToInvalidD

[GitHub] geode pull request #429: Geode-2686

2017-03-21 Thread jaredjstewart
Github user jaredjstewart commented on a diff in the pull request: https://github.com/apache/geode/pull/429#discussion_r107192575 --- Diff: geode-core/src/test/java/org/apache/geode/internal/JarDeployerIntegrationTest.java --- @@ -39,83 +44,63 @@ @Rule public Tempora

[GitHub] geode pull request #429: Geode-2686

2017-03-21 Thread jaredjstewart
Github user jaredjstewart commented on a diff in the pull request: https://github.com/apache/geode/pull/429#discussion_r107192442 --- Diff: geode-core/src/main/java/org/apache/geode/internal/cache/ClusterConfigurationLoader.java --- @@ -67,18 +68,16 @@ public static void deployJa

[GitHub] geode pull request #429: Geode-2686

2017-03-20 Thread kirklund
Github user kirklund commented on a diff in the pull request: https://github.com/apache/geode/pull/429#discussion_r107045761 --- Diff: geode-core/src/main/java/org/apache/geode/internal/cache/ClusterConfigurationLoader.java --- @@ -67,18 +68,16 @@ public static void deployJarsRec

[GitHub] geode pull request #429: Geode-2686

2017-03-20 Thread kirklund
Github user kirklund commented on a diff in the pull request: https://github.com/apache/geode/pull/429#discussion_r107046157 --- Diff: geode-core/src/test/java/org/apache/geode/internal/JarDeployerIntegrationTest.java --- @@ -39,83 +44,63 @@ @Rule public TemporaryFol

[GitHub] geode pull request #429: Geode-2686

2017-03-20 Thread kirklund
Github user kirklund commented on a diff in the pull request: https://github.com/apache/geode/pull/429#discussion_r107045945 --- Diff: geode-core/src/test/java/org/apache/geode/internal/ClassPathLoaderTest.java --- @@ -65,6 +65,26 @@ public void testLatestExists() throws Exception

[GitHub] geode pull request #429: Geode-2686

2017-03-20 Thread kirklund
Github user kirklund commented on a diff in the pull request: https://github.com/apache/geode/pull/429#discussion_r107048991 --- Diff: geode-core/src/test/java/org/apache/geode/internal/JarDeployerIntegrationTest.java --- @@ -144,40 +131,99 @@ public void run() { Thread

[GitHub] geode pull request #429: Geode-2686

2017-03-20 Thread kirklund
Github user kirklund commented on a diff in the pull request: https://github.com/apache/geode/pull/429#discussion_r107048816 --- Diff: geode-core/src/test/java/org/apache/geode/internal/JarDeployerIntegrationTest.java --- @@ -126,14 +111,16 @@ public void testDeployToInvalidDirect

[GitHub] geode pull request #429: Geode-2686

2017-03-17 Thread jaredjstewart
GitHub user jaredjstewart opened a pull request: https://github.com/apache/geode/pull/429 Geode-2686 GEODE-2686: Remove JarClassLoader … - Remove JarClassLoader - Replace ClassPathLoader's collection of JarClassLoaders with a single URLClassLoader - Change naming s