Github user kirklund commented on a diff in the pull request:
https://github.com/apache/geode/pull/429#discussion_r107048991
--- Diff:
geode-core/src/test/java/org/apache/geode/internal/JarDeployerIntegrationTest.java
---
@@ -144,40 +131,99 @@ public void run() {
Thread.sleep(500);
alternateDir.mkdir();
thread.join();
- } catch (Exception e) {
- fail(e);
+ } catch (InterruptedException iex) {
+ fail("Interrupted while waiting.");
--- End diff --
In particular, this is the worst thing we as developers can do in a JUnit
Test. This eats the exception and then throws an entirely new Exception stack
without the original stack trace. All JUnit @Test methods should simple have
"throws Exception" and then avoid this stuff.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
