Github user kirklund commented on a diff in the pull request:
https://github.com/apache/geode/pull/429#discussion_r107045945
--- Diff:
geode-core/src/test/java/org/apache/geode/internal/ClassPathLoaderTest.java ---
@@ -65,6 +65,26 @@ public void testLatestExists() throws Exception {
assertNotNull(ClassPathLoader.getLatest());
}
+ @Test
+ public void testZeroLengthFile() throws IOException,
ClassNotFoundException {
+ try {
+ ClassPathLoader.getLatest().getJarDeployer().deploy(new String[]
{"JarDeployerDUnitZLF.jar"},
+ new byte[][] {new byte[0]});
+ fail("Zero length files are not deployable");
+ } catch (IllegalArgumentException expected) {
--- End diff --
Better to use AssertJ assertThatThrownBy or CatchException. This is ok
though.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
