Github user ggreen closed the pull request at:
https://github.com/apache/geode/pull/404
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabl
GitHub user ggreen reopened a pull request:
https://github.com/apache/geode/pull/404
Geode 2469
The updated Geode Redis Adapter now works with a sample Spring Data Redis
Example
[GEODE-2469.pdf](https://github.com/apache/geode/files/785580/GEODE-2469.pdf)
These change
Github user galen-pivotal commented on a diff in the pull request:
https://github.com/apache/geode/pull/404#discussion_r105510564
--- Diff:
geode-core/src/main/java/org/apache/geode/redis/internal/executor/hash/HSetExecutor.java
---
@@ -55,9 +69,11 @@ public void executeCommand(Co
Github user galen-pivotal commented on a diff in the pull request:
https://github.com/apache/geode/pull/404#discussion_r105008854
--- Diff:
geode-core/src/main/java/org/apache/geode/redis/internal/ExecutionHandlerContext.java
---
@@ -135,8 +135,14 @@ private void writeToChannel(By
Github user galen-pivotal commented on a diff in the pull request:
https://github.com/apache/geode/pull/404#discussion_r105060019
--- Diff:
geode-core/src/main/java/org/apache/geode/redis/internal/executor/set/SRandMemberExecutor.java
---
@@ -42,9 +42,8 @@ public void executeComma
Github user galen-pivotal commented on a diff in the pull request:
https://github.com/apache/geode/pull/404#discussion_r105010837
--- Diff:
geode-core/src/main/java/org/apache/geode/redis/internal/RegionProvider.java ---
@@ -289,7 +331,9 @@ public void
createRemoteRegionReferenceL
Github user galen-pivotal commented on a diff in the pull request:
https://github.com/apache/geode/pull/404#discussion_r105059140
--- Diff:
geode-core/src/main/java/org/apache/geode/redis/internal/executor/set/SPopExecutor.java
---
@@ -36,24 +37,26 @@ public void executeCommand(Co
Github user galen-pivotal commented on a diff in the pull request:
https://github.com/apache/geode/pull/404#discussion_r105046939
--- Diff:
geode-core/src/main/java/org/apache/geode/redis/internal/executor/set/SMembersExecutor.java
---
@@ -39,16 +39,18 @@ public void executeComman
Github user galen-pivotal commented on a diff in the pull request:
https://github.com/apache/geode/pull/404#discussion_r105009858
--- Diff:
geode-core/src/main/java/org/apache/geode/redis/internal/RegionProvider.java ---
@@ -95,18 +98,38 @@ public RegionProvider(Region stringsRegio
Github user galen-pivotal commented on a diff in the pull request:
https://github.com/apache/geode/pull/404#discussion_r104552749
--- Diff:
geode-core/src/main/java/org/apache/geode/redis/internal/executor/hash/HashExecutor.java
---
@@ -75,14 +96,76 @@
}
/**
Github user galen-pivotal commented on a diff in the pull request:
https://github.com/apache/geode/pull/404#discussion_r105061296
--- Diff:
geode-core/src/main/java/org/apache/geode/redis/internal/executor/set/SetOpExecutor.java
---
@@ -47,23 +44,23 @@ public void executeCommand(C
Github user galen-pivotal commented on a diff in the pull request:
https://github.com/apache/geode/pull/404#discussion_r105053042
--- Diff:
geode-core/src/main/java/org/apache/geode/redis/internal/executor/set/SMoveExecutor.java
---
@@ -45,30 +48,44 @@ public void executeCommand(C
Github user galen-pivotal commented on a diff in the pull request:
https://github.com/apache/geode/pull/404#discussion_r105048647
--- Diff:
geode-core/src/main/java/org/apache/geode/redis/internal/executor/set/SIsMemberExecutor.java
---
@@ -40,23 +42,35 @@ public void executeComma
Github user galen-pivotal commented on a diff in the pull request:
https://github.com/apache/geode/pull/404#discussion_r105008897
--- Diff:
geode-core/src/main/java/org/apache/geode/redis/internal/ExecutionHandlerContext.java
---
@@ -235,6 +242,8 @@ private void executeWithoutTran
Github user galen-pivotal commented on a diff in the pull request:
https://github.com/apache/geode/pull/404#discussion_r105060205
--- Diff:
geode-core/src/main/java/org/apache/geode/redis/internal/executor/set/SRandMemberExecutor.java
---
@@ -42,9 +42,8 @@ public void executeComma
Github user galen-pivotal commented on a diff in the pull request:
https://github.com/apache/geode/pull/404#discussion_r105010443
--- Diff:
geode-core/src/main/java/org/apache/geode/redis/internal/RegionProvider.java ---
@@ -187,8 +215,18 @@ public boolean removeKey(ByteArrayWrappe
Github user ggreen commented on a diff in the pull request:
https://github.com/apache/geode/pull/404#discussion_r104974260
--- Diff:
geode-core/src/main/java/org/apache/geode/redis/internal/executor/hash/HashInterpreter.java
---
@@ -0,0 +1,126 @@
+/*
+ * Licensed to the Ap
And correcting the spelling of "SEPERATOR" would be a plus while changing
the code.
*Wes Williams | Pivotal Advisory **Data Engineer*
781.606.0325
http://pivotal.io/big-data/pivotal-gemfire
On Mon, Mar 6, 2017 at 6:14 PM, galen-pivotal wrote:
> Github user galen-pivotal commented on a diff in t
Github user galen-pivotal commented on a diff in the pull request:
https://github.com/apache/geode/pull/404#discussion_r104549703
--- Diff:
geode-core/src/main/java/org/apache/geode/redis/internal/executor/hash/HashInterpreter.java
---
@@ -0,0 +1,126 @@
+/*
+ * Licensed to
Github user ggreen commented on a diff in the pull request:
https://github.com/apache/geode/pull/404#discussion_r104402728
--- Diff:
geode-core/src/main/java/org/apache/geode/redis/internal/executor/hash/HashInterpreter.java
---
@@ -0,0 +1,126 @@
+/*
+ * Licensed to the Ap
Github user galen-pivotal commented on a diff in the pull request:
https://github.com/apache/geode/pull/404#discussion_r104059948
--- Diff:
geode-core/src/main/java/org/apache/geode/redis/internal/executor/hash/HashInterpreter.java
---
@@ -0,0 +1,126 @@
+/*
+ * Licensed to
Github user galen-pivotal commented on a diff in the pull request:
https://github.com/apache/geode/pull/404#discussion_r104041093
--- Diff:
geode-core/src/main/java/org/apache/geode/redis/internal/executor/hash/HDelExecutor.java
---
@@ -40,25 +38,25 @@ public void executeCommand(C
Github user galen-pivotal commented on a diff in the pull request:
https://github.com/apache/geode/pull/404#discussion_r104041266
--- Diff:
geode-core/src/main/java/org/apache/geode/redis/internal/RegionProvider.java ---
@@ -442,9 +502,10 @@ protected void checkDataType(ByteArrayWr
Github user galen-pivotal commented on a diff in the pull request:
https://github.com/apache/geode/pull/404#discussion_r104031973
--- Diff:
geode-core/src/main/java/org/apache/geode/redis/internal/RegionProvider.java ---
@@ -442,9 +502,10 @@ protected void checkDataType(ByteArrayWr
We generally do use separate regions for separate data types that have
different qualities of service.
As long as we don't think there will be a proliferation of regions due to
the ":" convention it shouldn't be too bad.
There is an issue with dynamic creation of regions in general.
New nodes that
Github user ggreen commented on a diff in the pull request:
https://github.com/apache/geode/pull/404#discussion_r104033312
--- Diff:
geode-core/src/main/java/org/apache/geode/redis/internal/RegionProvider.java ---
@@ -259,6 +307,16 @@ public void
createRemoteRegionReferenceLocally
Github user ggreen commented on a diff in the pull request:
https://github.com/apache/geode/pull/404#discussion_r103993535
--- Diff:
geode-core/src/main/java/org/apache/geode/redis/internal/RegionProvider.java ---
@@ -187,8 +217,26 @@ public boolean removeKey(ByteArrayWrapper key,
Github user ggreen commented on a diff in the pull request:
https://github.com/apache/geode/pull/404#discussion_r103928210
--- Diff:
geode-core/src/main/java/org/apache/geode/redis/internal/RegionProvider.java ---
@@ -259,6 +307,16 @@ public void
createRemoteRegionReferenceLocally
Github user hiteshk25 commented on a diff in the pull request:
https://github.com/apache/geode/pull/404#discussion_r103499836
--- Diff:
geode-core/src/main/java/org/apache/geode/redis/internal/RegionProvider.java ---
@@ -259,6 +307,16 @@ public void
createRemoteRegionReferenceLoca
Github user hiteshk25 commented on a diff in the pull request:
https://github.com/apache/geode/pull/404#discussion_r103497182
--- Diff:
geode-core/src/main/java/org/apache/geode/redis/internal/RegionProvider.java ---
@@ -187,8 +217,26 @@ public boolean removeKey(ByteArrayWrapper ke
Thanks Gregory. I will look this further.
From: Gregory Green
To: dev@geode.apache.org
Sent: Tuesday, February 21, 2017 12:21 PM
Subject: Re: [GitHub] geode pull request #404: Geode 2469
Hello Everyone,
I just wanted to clarify something with this pull request.
The main benefit
Hello Everyone,
I just wanted to clarify something with this pull request.
The main benefit of the pull request changes is the 99.9% performance
improvements for SET and HASH related Redis command processing.
FYI - In order to support HA as has previously implemented, the default
region type has
GitHub user ggreen opened a pull request:
https://github.com/apache/geode/pull/404
Geode 2469
The updated Geode Redis Adapter now works with a sample Spring Data Redis
Example
[GEODE-2469.pdf](https://github.com/apache/geode/files/785580/GEODE-2469.pdf)
These changes
33 matches
Mail list logo
