Github user ggreen commented on a diff in the pull request:
https://github.com/apache/geode/pull/404#discussion_r103993535
--- Diff:
geode-core/src/main/java/org/apache/geode/redis/internal/RegionProvider.java ---
@@ -187,8 +217,26 @@ public boolean removeKey(ByteArrayWrapper key,
RedisDataType type, boolean cance
return this.stringsRegion.remove(key) != null;
} else if (type == RedisDataType.REDIS_HLL) {
return this.hLLRegion.remove(key) != null;
+ } else if (type == RedisDataType.REDIS_LIST) {
+ return this.destroyRegion(key, type);
} else {
- return destroyRegion(key, type);
+
+
+ // Check hash
+ ByteArrayWrapper regionName =
HashInterpreter.toRegionNameByteArray(key);
+ Region<?, ?> region = this.getRegion(regionName);
+ if (region != null) {
+ region.remove(HashInterpreter.toEntryKey(key));
--- End diff --
We could return true, but that is what the next line after the if statement
already returns true
.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
