Github user galen-pivotal commented on a diff in the pull request:
https://github.com/apache/geode/pull/404#discussion_r105510564
--- Diff:
geode-core/src/main/java/org/apache/geode/redis/internal/executor/hash/HSetExecutor.java
---
@@ -55,9 +69,11 @@ public void executeCommand(Command command,
ExecutionHandlerContext context) {
Object oldValue;
if (onlySetOnAbsent())
- oldValue = keyRegion.putIfAbsent(field, new ByteArrayWrapper(value));
+ oldValue = map.putIfAbsent(field, new ByteArrayWrapper(value));
--- End diff --
This will fail with `ConcurrentModificationException` if other connections
try to access the same hash at the same time. I think we need to clone and then
put, which will give us eventual consistency but not ACID.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
