Github user galen-pivotal commented on a diff in the pull request:
https://github.com/apache/geode/pull/404#discussion_r105048647
--- Diff:
geode-core/src/main/java/org/apache/geode/redis/internal/executor/set/SIsMemberExecutor.java
---
@@ -40,23 +42,35 @@ public void executeCommand(Command command,
ExecutionHandlerContext context) {
return;
}
+ RegionProvider regionProvider = context.getRegionProvider();
+
+ // check by meta data key
+ // SISMEMBER companies ea64fe8c-e0a0-4439-a05d-d0738dd5ef80
ByteArrayWrapper key = command.getKey();
+ if (!regionProvider.existsKey(key)) {
+
command.setResponse(Coder.getIntegerResponse(context.getByteBufAllocator(),
NOT_EXISTS));
+ return;
+ }
+
--- End diff --
We should check the data type here, as Redis gives a different error for a
key that is of the wrong datatype than it does for a nonexistent key.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
