Github user pivotal-amurmann commented on the issue:
https://github.com/apache/geode/pull/747
**DO NOT MERGE THIS YET. THIS IS STILL BASED ON A RED DEVELOP CHECKOUT**
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
GitHub user pivotal-amurmann opened a pull request:
https://github.com/apache/geode/pull/747
GEODE-3514: Clean up locator and protobuf related code
* Check for feature flag only once
* Simplify TcpServerFactory
* Indicate RoundTripLocatorConnection test properly as DUnit
Github user pivotal-amurmann commented on a diff in the pull request:
https://github.com/apache/geode/pull/719#discussion_r135550580
--- Diff:
geode-core/src/main/java/org/apache/geode/security/StreamAuthenticator.java ---
@@ -46,6 +44,14 @@ void receiveMessage(InputStream
Github user pivotal-amurmann commented on a diff in the pull request:
https://github.com/apache/geode/pull/737#discussion_r135156514
--- Diff:
geode-protobuf/src/test/java/org/apache/geode/protocol/RoundTripCacheConnectionJUnitTest.java
---
@@ -119,7 +119,14 @@ public void setup
Github user pivotal-amurmann commented on a diff in the pull request:
https://github.com/apache/geode/pull/719#discussion_r135154701
--- Diff:
geode-protobuf/src/test/java/org/apache/geode/protocol/AuthorizationIntegrationTest.java
---
@@ -0,0 +1,206 @@
+/*
+ * Licensed
Github user pivotal-amurmann commented on a diff in the pull request:
https://github.com/apache/geode/pull/719#discussion_r135153058
--- Diff:
geode-core/src/main/java/org/apache/geode/security/StreamAuthenticator.java ---
@@ -46,6 +44,14 @@ void receiveMessage(InputStream
Github user pivotal-amurmann commented on a diff in the pull request:
https://github.com/apache/geode/pull/719#discussion_r135153161
--- Diff:
geode-core/src/main/java/org/apache/geode/security/StreamAuthorizer.java ---
@@ -0,0 +1,19 @@
+/*
+ * Licensed to the Apache
Github user pivotal-amurmann commented on a diff in the pull request:
https://github.com/apache/geode/pull/719#discussion_r135153564
--- Diff:
geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/ProtobufSimpleAuthenticator.java
---
@@ -41,20 +43,29 @@ public void
Github user pivotal-amurmann commented on a diff in the pull request:
https://github.com/apache/geode/pull/719#discussion_r135153452
--- Diff:
geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/ProtobufOpsProcessor.java
---
@@ -44,9 +46,15 @@ public
Github user pivotal-amurmann commented on the issue:
https://github.com/apache/geode/pull/742
This looks good. However, I'd like to understand what the plan is for
moving the files to the location suggested by the package name/path. Maybe the
Commit message could clarify
Github user pivotal-amurmann commented on a diff in the pull request:
https://github.com/apache/geode/pull/716#discussion_r135089666
--- Diff:
geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/operations/GetAvailableServersOperationHandler.java
---
@@ -50,51 +37,23
Github user pivotal-amurmann commented on a diff in the pull request:
https://github.com/apache/geode/pull/716#discussion_r135087207
--- Diff:
geode-core/src/test/java/org/apache/geode/test/dunit/standalone/DUnitLauncher.java
---
@@ -297,6 +297,8 @@ public Object call() throws
Github user pivotal-amurmann commented on a diff in the pull request:
https://github.com/apache/geode/pull/716#discussion_r134066027
--- Diff:
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/InvalidExecutionContextException.java
---
@@ -0,0 +1,33
Github user pivotal-amurmann commented on a diff in the pull request:
https://github.com/apache/geode/pull/716#discussion_r134053063
--- Diff:
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/InvalidExecutionContextException.java
---
@@ -0,0 +1,33
Github user pivotal-amurmann commented on a diff in the pull request:
https://github.com/apache/geode/pull/716#discussion_r134005011
--- Diff:
geode-core/src/test/java/org/apache/geode/cache/client/internal/AutoConnectionSourceImplJUnitTest.java
---
@@ -392,7 +388,7 @@ public
Github user pivotal-amurmann commented on a diff in the pull request:
https://github.com/apache/geode/pull/716#discussion_r134002721
--- Diff:
geode-core/src/test/java/org/apache/geode/cache/client/internal/AutoConnectionSourceImplJUnitTest.java
---
@@ -392,7 +388,7 @@ public
Github user pivotal-amurmann commented on a diff in the pull request:
https://github.com/apache/geode/pull/716#discussion_r133847775
--- Diff:
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/ClientProtoclMessageHandlerLoader.java
---
@@ -0,0 +1,64
Github user pivotal-amurmann commented on a diff in the pull request:
https://github.com/apache/geode/pull/716#discussion_r133847176
--- Diff:
geode-protobuf/src/test/java/org/apache/geode/protocol/protobuf/operations/GetAvailableServersOperationHandlerJUnitTest.java
Github user pivotal-amurmann commented on a diff in the pull request:
https://github.com/apache/geode/pull/716#discussion_r133844781
--- Diff:
geode-core/src/main/java/org/apache/geode/distributed/internal/tcpserver/TcpServer.java
---
@@ -334,42 +342,46 @@ protected void run
Github user pivotal-amurmann commented on a diff in the pull request:
https://github.com/apache/geode/pull/716#discussion_r133777949
--- Diff:
geode-core/src/main/java/org/apache/geode/distributed/internal/tcpserver/TcpServer.java
---
@@ -334,42 +342,46 @@ protected void run
GitHub user pivotal-amurmann opened a pull request:
https://github.com/apache/geode/pull/716
GEODE-3406: Locator accepts Protobuf requests
Also addresses GEODE-3400, GEODE-3399
This allows the locator to respond to Protobuf requests. Currently it
will only be able to respond
Github user pivotal-amurmann commented on a diff in the pull request:
https://github.com/apache/geode/pull/702#discussion_r133252327
--- Diff:
geode-core/src/main/java/org/apache/geode/internal/net/SocketCloser.java ---
@@ -96,46 +99,56 @@ public int getMaxThreads
Github user pivotal-amurmann commented on a diff in the pull request:
https://github.com/apache/geode/pull/707#discussion_r133246611
--- Diff:
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/ServerConnectionFactory.java
---
@@ -22,59 +22,89
Github user pivotal-amurmann commented on a diff in the pull request:
https://github.com/apache/geode/pull/700#discussion_r133001811
--- Diff:
geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/operations/PutAllRequestOperationHandler.java
---
@@ -79,9 +81,10
Github user pivotal-amurmann commented on a diff in the pull request:
https://github.com/apache/geode/pull/700#discussion_r133000153
--- Diff:
geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/operations/GetAllRequestOperationHandler.java
---
@@ -59,13 +59,14
GitHub user pivotal-amurmann opened a pull request:
https://github.com/apache/geode/pull/700
GEODE-3386 - Make KeyedErrorResponse & ErrorResponse siblings
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we
GitHub user pivotal-amurmann opened a pull request:
https://github.com/apache/geode/pull/698
Mark ProtoBuf interface as experimental
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the
Github user pivotal-amurmann commented on a diff in the pull request:
https://github.com/apache/geode/pull/683#discussion_r131974883
--- Diff:
geode-core/src/main/java/org/apache/geode/distributed/internal/locks/DLockService.java
---
@@ -74,17 +73,6 @@
public static final
Github user pivotal-amurmann commented on a diff in the pull request:
https://github.com/apache/geode/pull/683#discussion_r131977004
--- Diff:
geode-core/src/main/java/org/apache/geode/distributed/internal/locks/DLockService.java
---
@@ -1433,29 +1412,7 @@ public boolean
Github user pivotal-amurmann commented on a diff in the pull request:
https://github.com/apache/geode/pull/676#discussion_r130920986
--- Diff:
geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/ProtocolErrorCode.java
---
@@ -0,0 +1,39 @@
+/*
+ * Licensed to
Github user pivotal-amurmann commented on a diff in the pull request:
https://github.com/apache/geode/pull/673#discussion_r130647800
--- Diff:
geode-protobuf/src/test/java/org/apache/geode/protocol/protobuf/operations/GetAvailableServersOperationHandlerJUnitTest.java
---
@@ -0,0
Github user pivotal-amurmann commented on a diff in the pull request:
https://github.com/apache/geode/pull/673#discussion_r130646935
--- Diff:
geode-protobuf/src/test/java/org/apache/geode/protocol/GetAvailableServersDUnitTest.java
---
@@ -0,0 +1,108 @@
+/*
+ * Licensed
Github user pivotal-amurmann commented on a diff in the pull request:
https://github.com/apache/geode/pull/673#discussion_r130646564
--- Diff:
geode-protobuf/src/test/java/org/apache/geode/protocol/GetAvailableServersDUnitTest.java
---
@@ -0,0 +1,108 @@
+/*
+ * Licensed
Github user pivotal-amurmann commented on a diff in the pull request:
https://github.com/apache/geode/pull/673#discussion_r130646340
--- Diff: geode-protobuf/src/main/proto/clientProtocol.proto ---
@@ -43,13 +43,12 @@ message Request {
GetAllRequest getAllRequest = 5
Github user pivotal-amurmann commented on a diff in the pull request:
https://github.com/apache/geode/pull/673#discussion_r130646425
--- Diff: geode-protobuf/src/main/proto/clientProtocol.proto ---
@@ -64,15 +63,14 @@ message Response {
GetAllResponse getAllResponse
Github user pivotal-amurmann commented on a diff in the pull request:
https://github.com/apache/geode/pull/673#discussion_r130646177
--- Diff:
geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/utilities/ProtobufUtilities.java
---
@@ -140,7 +141,7
Github user pivotal-amurmann commented on a diff in the pull request:
https://github.com/apache/geode/pull/673#discussion_r130645759
--- Diff:
geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/operations/GetAvailableServersOperationHandler.java
---
@@ -0,0 +1,98
Github user pivotal-amurmann commented on a diff in the pull request:
https://github.com/apache/geode/pull/673#discussion_r130644766
--- Diff:
geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/operations/GetAvailableServersOperationHandler.java
---
@@ -0,0 +1,98
Github user pivotal-amurmann commented on a diff in the pull request:
https://github.com/apache/geode/pull/673#discussion_r130642543
--- Diff:
geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/operations/GetAvailableServersOperationHandler.java
---
@@ -0,0 +1,98
Github user pivotal-amurmann commented on the issue:
https://github.com/apache/geode/pull/663
I am sure it would be hard, but could we please write a unit test for the
change that was made to `DLockService#unlock`?
---
If your project is set up for it, you can reply to this email
Github user pivotal-amurmann commented on a diff in the pull request:
https://github.com/apache/geode/pull/657#discussion_r129689404
--- Diff:
geode-core/src/main/java/org/apache/geode/internal/tcp/ConnectionTable.java ---
@@ -279,26 +280,29 @@ protected void acceptConnection
Github user pivotal-amurmann commented on a diff in the pull request:
https://github.com/apache/geode/pull/646#discussion_r128793895
--- Diff:
geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/utilities/ProtobufResponseUtilities.java
---
@@ -50,47 +38,14
Github user pivotal-amurmann commented on a diff in the pull request:
https://github.com/apache/geode/pull/646#discussion_r128648851
--- Diff:
geode-protobuf/src/main/java/org/apache/geode/protocol/operations/Failure.java
---
@@ -0,0 +1,47 @@
+/*
+ * Licensed to the
Github user pivotal-amurmann commented on a diff in the pull request:
https://github.com/apache/geode/pull/646#discussion_r128618059
--- Diff:
geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/ProtobufOpsProcessor.java
---
@@ -15,32 +15,35 @@
package
Github user pivotal-amurmann commented on the issue:
https://github.com/apache/geode/pull/646
@kohlmu-pivotal @WireBaron @hiteshk25 @galen-pivotal @bschuchardt
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
GitHub user pivotal-amurmann opened a pull request:
https://github.com/apache/geode/pull/646
GEODE-3213: Refactor ProtoBuf handler flow
Signed-off-by: Alexander Murmann
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of
Github user pivotal-amurmann commented on the issue:
https://github.com/apache/geode/pull/634
Should this be squashed?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user pivotal-amurmann commented on a diff in the pull request:
https://github.com/apache/geode/pull/630#discussion_r127285154
--- Diff:
geode-protobuf/src/test/java/org/apache/geode/protocol/RoundTripCacheConnectionJUnitTest.java
---
@@ -278,6 +278,31 @@ public void
GitHub user pivotal-amurmann opened a pull request:
https://github.com/apache/geode/pull/624
GEODE-2998: Add remove operation
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the
Github user pivotal-amurmann closed the pull request at:
https://github.com/apache/geode/pull/611
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
GitHub user pivotal-amurmann opened a pull request:
https://github.com/apache/geode/pull/611
GEODE-3145 Add new protocol to Geode JAR
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the
51 matches
Mail list logo
