GitHub user pivotal-amurmann opened a pull request:
https://github.com/apache/geode/pull/716
GEODE-3406: Locator accepts Protobuf requests
Also addresses GEODE-3400, GEODE-3399
This allows the locator to respond to Protobuf requests. Currently it
will only be able to respond to getAvailableServers.
To enable this we are introducing a new value of "0" that will be sent
in place of the Gossip version. After it we expect the same magic byte
("110") as in AcceptorImpl.
This also is gated by the `geode.feature-protobuf-protocol` system
property.
The getAvailableServers request handler now uses the locator directly,
since we are on the locator.
Signed-off-by: Brian Rowe <[email protected]>
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [âï¸ ] Is there a JIRA ticket associated with this PR? Is it
referenced in the commit message?
GEODE-3400, GEODE-3399, GEODE-3406
- [âï¸ ] Has your PR been rebased against the latest commit within the
target branch (typically `develop`)?
- [âï¸] Is your initial contribution a single, squashed commit?
- [âï¸] Does `gradlew build` run cleanly?
- [âï¸] Have you written or updated unit tests to verify your changes?
- [x] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
N/A
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and
submit an update to your PR as soon as possible. If you need help, please
send an
email to [email protected].
@kohlmu-pivotal @bschuchardt @galen-pivotal @WireBaron @hiteshk25
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/pivotal-amurmann/geode
feature/GEODE-3400/locator_support_protobuf
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/geode/pull/716.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #716
----
commit a1d10ffdc6eda365eafa11d055cbce5096abcec2
Author: Alexander Murmann <[email protected]>
Date: 2017-08-14T22:08:14Z
GEODE-3406: Locator accepts Protobuf requests
Also addresses GEODE-3400, GEODE-3399
This allows the locator to respond to Protobuf requests. Currently it
will only be able to respond to getAvailableServers.
To enable this we are introducing a new value of "0" that will be sent
in place of the Gossip version. After it we expect the same magic byte
("110") as in AcceptorImpl.
This also is gated by the `geode.feature-protobuf-protocol` system
property.
The getAvailableServers request handler now uses the locator directly,
since we are on the locator.
Signed-off-by: Brian Rowe <[email protected]>
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
