Github user pivotal-amurmann commented on a diff in the pull request:
https://github.com/apache/geode/pull/683#discussion_r131977004
--- Diff:
geode-core/src/main/java/org/apache/geode/distributed/internal/locks/DLockService.java
---
@@ -1433,29 +1412,7 @@ public boolean lockInterruptibly(final Object name,
final long waitTimeMillis,
int lockId = -1;
incActiveLocks();
- int loopCount = 0;
while (keepTrying) {
--- End diff --
This `keepTrying` thing is very unclear because it hides what the actual
decision is based on. It seems like we keep trying until either the `waitLimit`
has been exceeded or the lock has been acquired. Could we split `keepTrying`
out into `boolean lockAcquired` and `boolean waitLimitExceeded`? Maybe the
check for `waitTimeLimit` doesn't even need a variable but could be checked by
the `while`?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
