Github user pivotal-amurmann commented on a diff in the pull request:
https://github.com/apache/geode/pull/630#discussion_r127285154
--- Diff:
geode-protobuf/src/test/java/org/apache/geode/protocol/RoundTripCacheConnectionJUnitTest.java
---
@@ -278,6 +278,31 @@ public void
useSSL_testNewProtocolHeaderLeadsToNewProtocolServerConnection() thr
testNewProtocolHeaderLeadsToNewProtocolServerConnection();
}
+ @Test
+ public void testNewProtocolGetRegionCallSucceeds() throws Exception {
+ System.setProperty("geode.feature-protobuf-protocol", "true");
+
+ Socket socket = new Socket("localhost", cacheServerPort);
+ Awaitility.await().atMost(5,
TimeUnit.SECONDS).until(socket::isConnected);
+ OutputStream outputStream = socket.getOutputStream();
+ outputStream.write(110);
+
+
+ ProtobufProtocolSerializer protobufProtocolSerializer = new
ProtobufProtocolSerializer();
+ ClientProtocol.Message getRegionMessage =
+ MessageUtil.makeGetRegionRequestMessage(TEST_REGION,
ClientProtocol.MessageHeader.newBuilder().build());
+ protobufProtocolSerializer.serialize(getRegionMessage, outputStream);
+
+ ClientProtocol.Message message =
+ protobufProtocolSerializer.deserialize(socket.getInputStream());
+ assertEquals(ClientProtocol.Message.MessageTypeCase.RESPONSE,
message.getMessageTypeCase());
+ ClientProtocol.Response response = message.getResponse();
+ assertEquals(ClientProtocol.Response.ResponseAPICase.GETREGIONRESPONSE,
+ response.getResponseAPICase());
+ response.getGetRegionResponse();
+ //TODO add some assertions for Region data
--- End diff --
Can we either add the assertions or put a chore in the backlog to backfill
this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
