[GitHub] geode-native pull request #76: GEODE-2726: Add Packer Build Files for VS 201...

2017-04-05 Thread mmartell
Github user mmartell closed the pull request at: https://github.com/apache/geode-native/pull/76 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] geode-native pull request #76: GEODE-2726: Add Packer Build Files for VS 201...

2017-03-28 Thread mmartell
GitHub user mmartell opened a pull request: https://github.com/apache/geode-native/pull/76 GEODE-2726: Add Packer Build Files for VS 2017 Added new packer files to support building Visual Studio 2017 environments. You can merge this pull request into a Git repository by running

[GitHub] geode-native issue #70: GEODE-2470: Fix for Solaris regex short comings.

2017-03-23 Thread mmartell
Github user mmartell commented on the issue: https://github.com/apache/geode-native/pull/70 This PR has been merged. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] geode-native pull request #70: GEODE-2470: Fix for Solaris regex short comin...

2017-03-23 Thread mmartell
Github user mmartell closed the pull request at: https://github.com/apache/geode-native/pull/70 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] geode-native pull request #70: GEODE-2470: Fix for Solaris regex short comin...

2017-03-22 Thread mmartell
GitHub user mmartell opened a pull request: https://github.com/apache/geode-native/pull/70 GEODE-2470: Fix for Solaris regex short comings. You can merge this pull request into a Git repository by running: $ git pull https://github.com/mmartell/geode-native feature/GEODE-2470

[GitHub] geode-native pull request #68: GEODE-2470: Fix for Solaris regex short comin...

2017-03-22 Thread mmartell
Github user mmartell closed the pull request at: https://github.com/apache/geode-native/pull/68 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] geode-native pull request #68: GEODE-2470: Fix for Solaris regex short comin...

2017-03-22 Thread mmartell
GitHub user mmartell opened a pull request: https://github.com/apache/geode-native/pull/68 GEODE-2470: Fix for Solaris regex short comings. You can merge this pull request into a Git repository by running: $ git pull https://github.com/mmartell/geode-native feature/GEODE-2470

[GitHub] geode-native pull request #62: GEODE-2513 Unbrand Connection Pools section o...

2017-03-20 Thread mmartell
Github user mmartell commented on a diff in the pull request: https://github.com/apache/geode-native/pull/62#discussion_r106943344 --- Diff: docs/geode-native-docs/connection-pools/native-client-pool-api.html.md.erb --- @@ -19,14 +19,14 @@ See the License for the specific language

[GitHub] geode-native pull request #63: GEODE-2657 - Fixes and tests Function Executi...

2017-03-20 Thread mmartell
Github user mmartell commented on a diff in the pull request: https://github.com/apache/geode-native/pull/63#discussion_r106929025 --- Diff: src/clicache/integration-test/ThinClientAppDomainFunctionExecutionTests.cs --- @@ -0,0 +1,282

[GitHub] geode-native issue #30: GEODE-2532: Create config files in runtime directory...

2017-02-24 Thread mmartell
Github user mmartell commented on the issue: https://github.com/apache/geode-native/pull/30 @pivotal-jbarrett It seems like a very good suggestion to keep all test files local to each test subdirectory. That would avoid potential name collision of these configured xml files. It looks

[GitHub] geode-native issue #30: GEODE-2532: Create config files in runtime directory...

2017-02-23 Thread mmartell
Github user mmartell commented on the issue: https://github.com/apache/geode-native/pull/30 @echobravopapa There is an inconsistency in how a few of the tests compute the path for the configured xml file. After inspection, there didn't appear to be a simple high level way to fix

[GitHub] geode-native issue #30: GEODE-2532: Create config files in runtime directory...

2017-02-23 Thread mmartell
Github user mmartell commented on the issue: https://github.com/apache/geode-native/pull/30 The xml files are created in the runtime working directory. For a Debug build this is: BUILD_DIR\clicache\integration-test\Debug, where BUILD_DIR is the cmake build directory

[GitHub] geode-native pull request #30: GEODE-2532: Create config files in runtime di...

2017-02-23 Thread mmartell
GitHub user mmartell opened a pull request: https://github.com/apache/geode-native/pull/30 GEODE-2532: Create config files in runtime directory. Some config xml files were being created in the source directory instead of the runtime test directory. You can merge this pull request

[GitHub] geode-native pull request #28: Feature/geode 2440

2017-02-23 Thread mmartell
Github user mmartell commented on a diff in the pull request: https://github.com/apache/geode-native/pull/28#discussion_r102771536 --- Diff: src/cppcache/src/ClientMetadata.cpp --- @@ -344,7 +344,7 @@ int ClientMetadata::assignFixedBucketId(const char* partitionName

[GitHub] geode-native pull request #28: Feature/geode 2440

2017-02-22 Thread mmartell
GitHub user mmartell opened a pull request: https://github.com/apache/geode-native/pull/28 Feature/geode 2440 Convert hashcode from unsigned to signed and remove static_casts that are no longer necessary. You can merge this pull request into a Git repository by running: $ git

[GitHub] geode-native pull request #17: GEODE-2440: Switch hashcode() return type.

2017-02-22 Thread mmartell
Github user mmartell closed the pull request at: https://github.com/apache/geode-native/pull/17 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] geode-native issue #17: GEODE-2440: Switch hashcode() return type.

2017-02-22 Thread mmartell
Github user mmartell commented on the issue: https://github.com/apache/geode-native/pull/17 Close for now. Resubmit after implementing jbarrett's recommendations. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] geode-native pull request #22: GEODE-2516: Fix quickstart install to retain ...

2017-02-22 Thread mmartell
GitHub user mmartell opened a pull request: https://github.com/apache/geode-native/pull/22 GEODE-2516: Fix quickstart install to retain permissions. - By default cmake install unsets the execute bit. To retain it add USE_SOURCE_PERMISSIONS flag. You can merge this pull request

[GitHub] geode-native pull request #15: GEODE-2484: Fix snprintf error. Need #include...

2017-02-17 Thread mmartell
Github user mmartell closed the pull request at: https://github.com/apache/geode-native/pull/15 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] geode-native pull request #17: GEODE-2440: Switch hashcode() return type.

2017-02-17 Thread mmartell
GitHub user mmartell opened a pull request: https://github.com/apache/geode-native/pull/17 GEODE-2440: Switch hashcode() return type. - Convert from uint32_t to int32_t to match server. You can merge this pull request into a Git repository by running: $ git pull https

[GitHub] geode-native pull request #13: GEODE-2476: Replace gfcpp with geode.

2017-02-17 Thread mmartell
Github user mmartell commented on a diff in the pull request: https://github.com/apache/geode-native/pull/13#discussion_r101783052 --- Diff: src/cppcache/include/geode/AttributesFactory.hpp --- @@ -20,7 +20,7 @@ * limitations under the License. */ -#include

[GitHub] geode-native pull request #13: GEODE-2476: Replace gfcpp with geode.

2017-02-17 Thread mmartell
Github user mmartell commented on a diff in the pull request: https://github.com/apache/geode-native/pull/13#discussion_r101782908 --- Diff: src/cppcache/include/geode/AttributesFactory.hpp --- @@ -1,7 +1,7 @@ #pragma once -#ifndef GEODE_GFCPP_ATTRIBUTESFACTORY_H_

[GitHub] geode-native issue #15: GEODE-2484: Fix snprintf error. Need #include

2017-02-16 Thread mmartell
Github user mmartell commented on the issue: https://github.com/apache/geode-native/pull/15 On Thu, Feb 16, 2017 at 12:09 PM Michael Martell wrote: > Something is screwed up in our #includes. TcrMessage.cpp compiles fine > leaving the std:: in there. However,

[GitHub] geode-native issue #15: GEODE-2484: Fix snprintf error. Need #include

2017-02-16 Thread mmartell
Github user mmartell commented on the issue: https://github.com/apache/geode-native/pull/15 Something is screwed up in our #includes. TcrMessage.cpp compiles fine leaving the std:: in there. However, other classes that include it don't compile (like Distributed S

[GitHub] geode-native issue #15: GEODE-2484: Fix snprintf error. Need #include

2017-02-16 Thread mmartell
Github user mmartell commented on the issue: https://github.com/apache/geode-native/pull/15 David, I had to remove the std:: to get it to build on Windows. I tested my fix on Windows and Mac only. On Thu, Feb 16, 2017 at 9:41 AM, Anthony Baker wrote

[GitHub] geode-native issue #15: GEODE-2484: Fix snprintf error. Need #include

2017-02-16 Thread mmartell
Github user mmartell commented on the issue: https://github.com/apache/geode-native/pull/15 Whoops. Forgot to format. Fixing now. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] geode-native pull request #15: GEODE-2484: Fix snprintf error. Need #include...

2017-02-16 Thread mmartell
GitHub user mmartell opened a pull request: https://github.com/apache/geode-native/pull/15 GEODE-2484: Fix snprintf error. Need #include . You can merge this pull request into a Git repository by running: $ git pull https://github.com/mmartell/geode-native feature/GEODE-2484

[GitHub] geode-native issue #6: GEODE-2470: Replace sed dependency with standard C++.

2017-02-14 Thread mmartell
Github user mmartell commented on the issue: https://github.com/apache/geode-native/pull/6 As per your suggestions, switched to using assign with istreambuf_iterators. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] geode-native pull request #6: GEODE-2470: Replace sed dependency with standa...

2017-02-14 Thread mmartell
Github user mmartell commented on a diff in the pull request: https://github.com/apache/geode-native/pull/6#discussion_r101071068 --- Diff: src/cppcache/integration-test/CacheHelper.cpp --- @@ -1382,6 +1377,31 @@ void CacheHelper::createDuplicateXMLFile(std::string& original

[GitHub] geode-native pull request #7: Feature/geode 2467

2017-02-13 Thread mmartell
Github user mmartell commented on a diff in the pull request: https://github.com/apache/geode-native/pull/7#discussion_r100968353 --- Diff: src/dependencies/xerces-c/CMakeLists.txt --- @@ -32,10 +32,10 @@ if (WIN32) set( _BUILD_DIR Build/Win32/VC${MSVC_VERSION

[GitHub] geode-native issue #7: Feature/geode 2467

2017-02-13 Thread mmartell
Github user mmartell commented on the issue: https://github.com/apache/geode-native/pull/7 Removed the extraneous commit. This PR now only has the commit to change the Xerces CMakeLists.txt. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] geode-native issue #6: GEODE-2470: Replace sed dependency with standard C++.

2017-02-13 Thread mmartell
Github user mmartell commented on the issue: https://github.com/apache/geode-native/pull/6 Simplified by switching to regex_replace instead custom function. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] geode-native pull request #7: Feature/geode 2467

2017-02-12 Thread mmartell
GitHub user mmartell opened a pull request: https://github.com/apache/geode-native/pull/7 Feature/geode 2467 You can merge this pull request into a Git repository by running: $ git pull https://github.com/mmartell/geode-native feature/GEODE-2467 Alternatively you can review

[GitHub] geode-native pull request #6: GEODE-2470: Replace sed dependency with standa...

2017-02-12 Thread mmartell
GitHub user mmartell opened a pull request: https://github.com/apache/geode-native/pull/6 GEODE-2470: Replace sed dependency with standard C++. - sed is used in CacheHelper to do string replacement of port number variables in the input xml configuration files. You can merge

[GitHub] geode-native pull request #2: GEODE-2423: Remove unused keystore files and r...

2017-02-10 Thread mmartell
GitHub user mmartell opened a pull request: https://github.com/apache/geode-native/pull/2 GEODE-2423: Remove unused keystore files and rename to geode.keystore The keystore files are used by the security related integration tests. You can merge this pull request into a Git

[GitHub] geode-native pull request #1: GEODE-2357: Replace gemfire with geode (all ca...

2017-02-09 Thread mmartell
GitHub user mmartell opened a pull request: https://github.com/apache/geode-native/pull/1 GEODE-2357: Replace gemfire with geode (all case variants) in C# quickstarts You can merge this pull request into a Git repository by running: $ git pull https://github.com/mmartell/geode

[GitHub] geode pull request #391: GEODE-2422: Switch remaining GemFire strings to Geo...

2017-02-09 Thread mmartell
Github user mmartell closed the pull request at: https://github.com/apache/geode/pull/391 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] geode issue #391: GEODE-2422: Switch remaining GemFire strings to Geode.

2017-02-09 Thread mmartell
Github user mmartell commented on the issue: https://github.com/apache/geode/pull/391 This closes #391. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] geode issue #391: GEODE-2422: Switch remaining GemFire strings to Geode.

2017-02-06 Thread mmartell
Github user mmartell commented on the issue: https://github.com/apache/geode/pull/391 Good catch that must not be used. So we should remove it. Please create a new ticket for that. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] geode pull request #391: GEODE-2422: Switch remaining GemFire strings to Geo...

2017-02-04 Thread mmartell
GitHub user mmartell opened a pull request: https://github.com/apache/geode/pull/391 GEODE-2422: Switch remaining GemFire strings to Geode. - includes rename GemFireCache.hpp to GeodeCache.hpp - GemFire, Gemfire, and gemfire replaced with Geode, Geode, geode - includes

[GitHub] geode issue #375: GEODE-2365: Replace gemfire with geode in clicache src.

2017-02-02 Thread mmartell
Github user mmartell commented on the issue: https://github.com/apache/geode/pull/375 This closes #375. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] geode pull request #375: GEODE-2365: Replace gemfire with geode in clicache ...

2017-02-02 Thread mmartell
Github user mmartell closed the pull request at: https://github.com/apache/geode/pull/375 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] geode issue #375: GEODE-2365: Replace gemfire with geode in clicache src.

2017-02-01 Thread mmartell
Github user mmartell commented on the issue: https://github.com/apache/geode/pull/375 Fixed one failing clicache (ThinClientCSTXN) due to an invalid gfsh arg. Apparently gfsh still requires gemfire terminology: gemfire.ALLOW_PERSISTENT_TRANSACTIONS not

[GitHub] geode pull request #375: GEODE-2365: Replace gemfire with geode in clicache ...

2017-01-30 Thread mmartell
GitHub user mmartell opened a pull request: https://github.com/apache/geode/pull/375 GEODE-2365: Replace gemfire with geode in clicache src. Note: There are some reformats being done by Visual Studio in both the csharp and the c++/cli sources. You can merge this pull request into

[GitHub] geode pull request #369: Feature/geode 2373

2017-01-30 Thread mmartell
Github user mmartell closed the pull request at: https://github.com/apache/geode/pull/369 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] geode issue #369: Feature/geode 2373

2017-01-30 Thread mmartell
Github user mmartell commented on the issue: https://github.com/apache/geode/pull/369 This closes #369. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] geode issue #370: Feature/geode 2351

2017-01-30 Thread mmartell
Github user mmartell commented on the issue: https://github.com/apache/geode/pull/370 This closes #370. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] geode issue #372: Feature/geode 2342

2017-01-30 Thread mmartell
Github user mmartell commented on the issue: https://github.com/apache/geode/pull/372 This closes #372. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] geode pull request #372: Feature/geode 2342

2017-01-30 Thread mmartell
Github user mmartell closed the pull request at: https://github.com/apache/geode/pull/372 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] geode pull request #372: Feature/geode 2342

2017-01-30 Thread mmartell
GitHub user mmartell opened a pull request: https://github.com/apache/geode/pull/372 Feature/geode 2342 Fix formatting of earlier PR. You can merge this pull request into a Git repository by running: $ git pull https://github.com/mmartell/geode feature/GEODE-2342

[GitHub] geode pull request #358: GEODE-2342: Rename GemfireTypeIds class to GeodeTyp...

2017-01-30 Thread mmartell
Github user mmartell closed the pull request at: https://github.com/apache/geode/pull/358 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] geode pull request #370: Feature/geode 2351

2017-01-28 Thread mmartell
GitHub user mmartell opened a pull request: https://github.com/apache/geode/pull/370 Feature/geode 2351 You can merge this pull request into a Git repository by running: $ git pull https://github.com/mmartell/geode feature/GEODE-2351 Alternatively you can review and apply

[GitHub] geode pull request #369: Feature/geode 2373

2017-01-27 Thread mmartell
GitHub user mmartell opened a pull request: https://github.com/apache/geode/pull/369 Feature/geode 2373 You can merge this pull request into a Git repository by running: $ git pull https://github.com/mmartell/geode feature/GEODE-2373 Alternatively you can review and apply

[GitHub] geode pull request #356: GEODE-2351: Update the cpp quickstarts to use geode...

2017-01-27 Thread mmartell
Github user mmartell closed the pull request at: https://github.com/apache/geode/pull/356 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] geode pull request #356: GEODE-2351: Update the cpp quickstarts to use geode...

2017-01-27 Thread mmartell
GitHub user mmartell reopened a pull request: https://github.com/apache/geode/pull/356 GEODE-2351: Update the cpp quickstarts to use geode instead of gemfire You can merge this pull request into a Git repository by running: $ git pull https://github.com/mmartell/geode feature

[GitHub] geode pull request #357: GEODE-2351: Update the cpp quickstarts to use geode...

2017-01-27 Thread mmartell
Github user mmartell closed the pull request at: https://github.com/apache/geode/pull/357 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] geode issue #357: GEODE-2351: Update the cpp quickstarts to use geode instea...

2017-01-26 Thread mmartell
Github user mmartell commented on the issue: https://github.com/apache/geode/pull/357 This is a duplicate of PR #356. Closing this one and reopening #356 instead. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] geode pull request #356: GEODE-2351: Update the cpp quickstarts to use geode...

2017-01-25 Thread mmartell
Github user mmartell closed the pull request at: https://github.com/apache/geode/pull/356 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] geode pull request #358: GEODE-2342: Rename GemfireTypeIds class to GeodeTyp...

2017-01-25 Thread mmartell
GitHub user mmartell opened a pull request: https://github.com/apache/geode/pull/358 GEODE-2342: Rename GemfireTypeIds class to GeodeTypeIds to match corr… …esponding file name change. Note, this was missed in the intitial commit. You can merge this pull request into a Git

[GitHub] geode pull request #357: GEODE-2351: Update the cpp quickstarts to use geode...

2017-01-25 Thread mmartell
GitHub user mmartell opened a pull request: https://github.com/apache/geode/pull/357 GEODE-2351: Update the cpp quickstarts to use geode instead of gemfire You can merge this pull request into a Git repository by running: $ git pull https://github.com/mmartell/geode feature

[GitHub] geode pull request #356: GEODE-2351: Update the cpp quickstarts to use geode...

2017-01-24 Thread mmartell
GitHub user mmartell opened a pull request: https://github.com/apache/geode/pull/356 GEODE-2351: Update the cpp quickstarts to use geode instead of gemfire You can merge this pull request into a Git repository by running: $ git pull https://github.com/mmartell/geode feature

[GitHub] geode pull request #354: GEODE-2342: Update GemfireTypeIds (files and refere...

2017-01-24 Thread mmartell
Github user mmartell closed the pull request at: https://github.com/apache/geode/pull/354 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] geode issue #354: GEODE-2342: Update GemfireTypeIds (files and references) t...

2017-01-24 Thread mmartell
Github user mmartell commented on the issue: https://github.com/apache/geode/pull/354 This closes feature/GEODE-2342. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] geode pull request #345: GEODE-2311: Add cmake support for building the C# s...

2017-01-24 Thread mmartell
Github user mmartell closed the pull request at: https://github.com/apache/geode/pull/345 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] geode issue #350: Feature/geode 2316

2017-01-23 Thread mmartell
Github user mmartell commented on the issue: https://github.com/apache/geode/pull/350 +1 on the groups of changes identified above by echobravopapa. In particular, in addition to the namespace rename, I like the switch to nested namespaces, which will be even simpler in C++17

[GitHub] geode pull request #345: GEODE-2311: Add cmake support for building the C# s...

2017-01-18 Thread mmartell
GitHub user mmartell opened a pull request: https://github.com/apache/geode/pull/345 GEODE-2311: Add cmake support for building the C# security dll used b… …y the C# security quickstarts. You can merge this pull request into a Git repository by running: $ git pull https