Github user mmartell commented on the issue:
https://github.com/apache/geode-native/pull/15
On Thu, Feb 16, 2017 at 12:09 PM Michael Martell <mmart...@pivotal.io>
wrote:
> Something is screwed up in our #includes. TcrMessage.cpp compiles fine
> leaving the std:: in there. However, other classes that include it don't
> compile (like DistributedSystem).
>
> I'd rather spend time switching to newer constructs (<stream> and
> <iostream>). Simple change, and for now we can convert the streamstrimg
> back to char* when passing to logger.
>
> On Thu, Feb 16, 2017 at 11:50 AM Jacob Barrett <notificati...@github.com>
> wrote:
>
> *@pivotal-jbarrett* requested changes on this pull request.
> ------------------------------
>
> In src/cppcache/src/TcrMessage.hpp
> <https://github.com/apache/geode-native/pull/15#discussion_r101610701>:
>
> > @@ -1114,10 +1116,10 @@ class TcrMessageHelper {
> } else if (!isObj) {
> // otherwise we're currently always expecting an object
> char exMsg[256];
> - std::snprintf(exMsg, 255,
> - "TcrMessageHelper::readChunkPartHeader: "
> - "%s: part is not object",
> - methodName);
> + snprintf(exMsg, 255,
>
> If you had to remove std:: to make this work then it isn't working like
> you think it is. Let's figure out why and fix correctly,
>
> â
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
>
<https://github.com/apache/geode-native/pull/15#pullrequestreview-22345908>,
> or mute the thread
>
<https://github.com/notifications/unsubscribe-auth/AP6jX5v5lFuHm4O8jYJ90Gf12XL1Bq1eks5rdKiSgaJpZM4MDMYN>
> .
>
>
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
