Github user mmartell commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/7#discussion_r100968353
--- Diff: src/dependencies/xerces-c/CMakeLists.txt ---
@@ -32,10 +32,10 @@ if (WIN32)
set( _BUILD_DIR Build/Win32/VC${MSVC_VERSION}/${_DEBUG_OR_RELEASE} )
endif()
- if (MSVC_VERSION GREATER 12)
- # Only have project files for VS12 and older
- set(MSVC_VERSION 12)
- endiF()
+ #if (MSVC_VERSION GREATER 12)
--- End diff --
It actually builds fine with Visual Studio 2017. They probably just don't
test with release candidates, so they haven't update their docs. Official
release date is Mar 7.
I left the code in but commented out in case we wanted to put it back in
for some reason.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
