[GitHub] geode pull request #707: GEODE-3412: Add simple authentication flow to proto...

Github user galen-pivotal commented on a diff in the pull request: https://github.com/apache/geode/pull/707#discussion_r132878512 --- Diff: geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/ServerConnectionFactory.java --- @@ -72,9 +99,15 @@ public static Serve

[GitHub] geode pull request #707: GEODE-3412: Add simple authentication flow to proto...

Github user galen-pivotal commented on a diff in the pull request: https://github.com/apache/geode/pull/707#discussion_r132878378 --- Diff: geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/ServerConnectionFactory.java --- @@ -63,6 +65,31 @@ private static Clie

[GitHub] geode pull request #707: GEODE-3412: Add simple authentication flow to proto...

Github user galen-pivotal commented on a diff in the pull request: https://github.com/apache/geode/pull/707#discussion_r132878110 --- Diff: geode-core/src/main/java/org/apache/geode/distributed/internal/DistributionConfig.java --- @@ -2433,6 +2433,25 @@ String getRedundancy

[GitHub] geode pull request #707: GEODE-3412: Add simple authentication flow to proto...

Github user galen-pivotal commented on a diff in the pull request: https://github.com/apache/geode/pull/707#discussion_r132877993 --- Diff: geode-core/src/main/java/org/apache/geode/distributed/ConfigurationProperties.java --- @@ -1378,6 +1379,18 @@ */ String NAME =

Jenkins build is back to normal : Geode-nightly-flaky #90

See

Build failed in Jenkins: Geode-nightly #922

See -- [...truncated 127.20 KB...] at java.net.ServerSocket.bind(ServerSocket.java:375) at org.apache.geode.internal.net.SocketCreator.createServerSocket(Sock

[GitHub] geode pull request #702: GEODE-3416: Reduce synchronization blockages in Soc...

Github user galen-pivotal commented on a diff in the pull request: https://github.com/apache/geode/pull/702#discussion_r132869478 --- Diff: geode-book/master_middleman/bookbinder_helpers.rb --- @@ -1,298 +0,0 @@ -# Licensed to the Apache Software Foundation (ASF) under one -

[GitHub] geode pull request #683: GEODE-3314 - additional refactoring for developer Q...

Github user galen-pivotal commented on a diff in the pull request: https://github.com/apache/geode/pull/683#discussion_r132864196 --- Diff: geode-core/src/main/java/org/apache/geode/distributed/internal/locks/DLockService.java --- @@ -74,17 +73,6 @@ public static final long

Re: Reverting all Commands changes

I have completed reverting all changes from Friday that introduced build failures. My latest precheckin was GREEN. Please feel free to commit changes to GFSH Command classes or tests again. I did see two flaky failures involving Command tests but those were not introduced on Friday. Thanks, Kirk

[Spring CI] Spring Data GemFire > Nightly-ApacheGeode > #646 was SUCCESSFUL (with 2027 tests)

--- Spring Data GemFire > Nightly-ApacheGeode > #646 was successful. --- Scheduled 2029 tests in total. https://build.spring.io/browse/SGF-NAG-646/ -- This

Reverting all Commands changes

Please do NOT commit any further changes to GFSH Commands classes or their tests. I have a commit ready to vert all Commands changes from Friday. Unfortunately two more commits are now adding to the problems and now I'm going to have to revert these as well in order to revert the other commits I w