[GitHub] geode issue #515: GEODE-240: Remove deprecated methods on TransactionEvent

Github user shankarh commented on the issue: https://github.com/apache/geode/pull/515 Can this PR be merged? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes s

[GitHub] geode pull request #646: GEODE-3213: Refactor ProtoBuf handler flow

Github user galen-pivotal commented on a diff in the pull request: https://github.com/apache/geode/pull/646#discussion_r128678978 --- Diff: geode-protobuf/src/test/java/org/apache/geode/protocol/protobuf/operations/PutRequestOperationHandlerJUnitTest.java --- @@ -124,20 +128,19 @@

[GitHub] geode pull request #646: GEODE-3213: Refactor ProtoBuf handler flow

Github user galen-pivotal commented on a diff in the pull request: https://github.com/apache/geode/pull/646#discussion_r128678905 --- Diff: geode-protobuf/src/test/java/org/apache/geode/protocol/protobuf/operations/GetRequestOperationHandlerJUnitTest.java --- @@ -144,21 +138,22 @@

[GitHub] geode pull request #646: GEODE-3213: Refactor ProtoBuf handler flow

Github user galen-pivotal commented on a diff in the pull request: https://github.com/apache/geode/pull/646#discussion_r128677601 --- Diff: geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/utilities/ProtobufResponseUtilities.java --- @@ -50,47 +38,14 @@ * @p

Build failed in Jenkins: Geode-nightly-flaky #71

See Changes: [jiliao] GEODE-2818: Making "groups" a valid option when starting locators or [klund] GEODE-3156: add AcceptanceTest gradle target and junit category [ukohlmeyer] GetServersResponse number of serv

Re: Avoid mutating standard Java System Properties (even in tests)

I have had a lot of tests fail because mcast-port is nonzero. So now I set that system property in a lot of new tests. Maybe the tests that set it to something other than the default should be passing a Properties object to CacheFactory rather than messing with system properties. I think the Cache

Build failed in Jenkins: Geode-nightly #902

See Changes: [jiliao] GEODE-2920: handle non-existent role in ExampleSecurityManager [jiliao] GEODE-2707: Removing TXLockToken class and entry in [kmiller] GEODE-3272 Doc update: .gfsh.history goes into .geode dir

[GitHub] geode-native pull request #107: GEODE-3019: Refactor Struct class

Github user dgkimura commented on a diff in the pull request: https://github.com/apache/geode-native/pull/107#discussion_r128660879 --- Diff: src/cppcache/src/StructSetImpl.cpp --- @@ -66,25 +66,22 @@ SelectResultsIterator StructSetImpl::getIterator() { return SelectResultsIt

[GitHub] geode-native pull request #107: GEODE-3019: Refactor Struct class

Github user dgkimura commented on a diff in the pull request: https://github.com/apache/geode-native/pull/107#discussion_r128661186 --- Diff: src/cppcache/test/StructSetTest.cpp --- @@ -0,0 +1,91 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more

[GitHub] geode-native issue #107: GEODE-3019: Refactor Struct class

Github user echobravopapa commented on the issue: https://github.com/apache/geode-native/pull/107 @dgkimura @pivotal-jbarrett I think this is all ready for final inspection --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] geode pull request #649: GEODE-2997: Change new protocol GetAllResponse.

Github user WireBaron commented on a diff in the pull request: https://github.com/apache/geode/pull/649#discussion_r128652774 --- Diff: geode-protobuf/src/main/proto/basicTypes.proto --- @@ -62,4 +62,14 @@ message Region { message Server { string url = 1; -}

[GitHub] geode pull request #639: GEODE-3112: Fixing improper ordering of client time...

Github user asfgit closed the pull request at: https://github.com/apache/geode/pull/639 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabl

[GitHub] geode pull request #646: GEODE-3213: Refactor ProtoBuf handler flow

Github user galen-pivotal commented on a diff in the pull request: https://github.com/apache/geode/pull/646#discussion_r128649982 --- Diff: geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/OperationContext.java --- @@ -0,0 +1,57 @@ +/* + * Licensed to the Ap

[GitHub] geode pull request #646: GEODE-3213: Refactor ProtoBuf handler flow

Github user galen-pivotal commented on a diff in the pull request: https://github.com/apache/geode/pull/646#discussion_r128649664 --- Diff: geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/OperationContext.java --- @@ -0,0 +1,57 @@ +/* + * Licensed to the Ap

[GitHub] geode pull request #646: GEODE-3213: Refactor ProtoBuf handler flow

Github user galen-pivotal commented on a diff in the pull request: https://github.com/apache/geode/pull/646#discussion_r128649345 --- Diff: geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/OperationContext.java --- @@ -0,0 +1,57 @@ +/* + * Licensed to the Ap

[GitHub] geode pull request #646: GEODE-3213: Refactor ProtoBuf handler flow

Github user galen-pivotal commented on a diff in the pull request: https://github.com/apache/geode/pull/646#discussion_r128647952 --- Diff: geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/OperationContext.java --- @@ -0,0 +1,57 @@ +/* + * Licensed to the Ap

[GitHub] geode pull request #646: GEODE-3213: Refactor ProtoBuf handler flow

Github user galen-pivotal commented on a diff in the pull request: https://github.com/apache/geode/pull/646#discussion_r128648216 --- Diff: geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/ProtobufOpsProcessor.java --- @@ -15,32 +15,33 @@ package org.apache.geo

[GitHub] geode pull request #646: GEODE-3213: Refactor ProtoBuf handler flow

Github user galen-pivotal commented on a diff in the pull request: https://github.com/apache/geode/pull/646#discussion_r128649165 --- Diff: geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/OperationContext.java --- @@ -0,0 +1,57 @@ +/* + * Licensed to the Ap

[GitHub] geode pull request #646: GEODE-3213: Refactor ProtoBuf handler flow

Github user galen-pivotal commented on a diff in the pull request: https://github.com/apache/geode/pull/646#discussion_r128649824 --- Diff: geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/OperationContext.java --- @@ -0,0 +1,57 @@ +/* + * Licensed to the Ap

[GitHub] geode pull request #646: GEODE-3213: Refactor ProtoBuf handler flow

Github user pivotal-amurmann commented on a diff in the pull request: https://github.com/apache/geode/pull/646#discussion_r128648851 --- Diff: geode-protobuf/src/main/java/org/apache/geode/protocol/operations/Failure.java --- @@ -0,0 +1,47 @@ +/* + * Licensed to the Apache

[Spring CI] Spring Data GemFire > Nightly-ApacheGeode > #622 was SUCCESSFUL (with 1984 tests). Change made by John Blum.

--- Spring Data GemFire > Nightly-ApacheGeode > #622 was successful. --- Scheduled with changes by John Blum. 1986 tests in total. https://build.spring.io/browse

[GitHub] geode issue #649: GEODE-2997: Change new protocol GetAllResponse.

Github user galen-pivotal commented on the issue: https://github.com/apache/geode/pull/649 Some other thoughts from today: * make GetAllResponse return a collection of Entries and a collection of errors. * make Get and GetAll return the same type of response, as mentioned abov

Re: Proposal: Lucene indexing/searching for nested objects

Good point! Sounds good then. Sent from my iPhone > On Jul 20, 2017, at 11:15 AM, Dan Smith wrote: > >> On Thu, Jul 20, 2017 at 10:57 AM, Jacob Barrett wrote: >> >> I really feel like an annotation would make the most sense. How likely is >> it that the object could not be annotated or the se

[GitHub] geode pull request #649: GEODE-2997: Change new protocol GetAllResponse.

GitHub user galen-pivotal opened a pull request: https://github.com/apache/geode/pull/649 GEODE-2997: Change new protocol GetAllResponse. @kohlmu-pivotal @hiteshk25 @WireBaron @pivotal-amurmann @bschuchardt I think it's better to return the errors and the successful keys so

Re: Review Request 60974: GEODE-3231: do not log to file by default when using the member starter rules

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60974/ --- (Updated July 20, 2017, 9:51 p.m.) Review request for geode, Emily Yeh, Jared S

[GitHub] geode pull request #590: GEODE-3090: Fixing gfsh help message (and a lot of ...

Github user asfgit closed the pull request at: https://github.com/apache/geode/pull/590 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabl

[GitHub] geode pull request #644: GEODE-3208 Revise docs with outdated JAR references

Github user asfgit closed the pull request at: https://github.com/apache/geode/pull/644 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabl

[GitHub] geode pull request #646: GEODE-3213: Refactor ProtoBuf handler flow

Github user pivotal-amurmann commented on a diff in the pull request: https://github.com/apache/geode/pull/646#discussion_r128618059 --- Diff: geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/ProtobufOpsProcessor.java --- @@ -15,32 +15,35 @@ package org.apache.

[GitHub] geode pull request #646: GEODE-3213: Refactor ProtoBuf handler flow

Github user WireBaron commented on a diff in the pull request: https://github.com/apache/geode/pull/646#discussion_r128597628 --- Diff: geode-protobuf/src/main/java/org/apache/geode/protocol/operations/Failure.java --- @@ -0,0 +1,47 @@ +/* + * Licensed to the Apache Softwa

[GitHub] geode pull request #646: GEODE-3213: Refactor ProtoBuf handler flow

Github user WireBaron commented on a diff in the pull request: https://github.com/apache/geode/pull/646#discussion_r128591891 --- Diff: geode-protobuf/src/main/java/org/apache/geode/protocol/operations/Result.java --- @@ -0,0 +1,28 @@ +/* + * Licensed to the Apache Softwar

[GitHub] geode pull request #646: GEODE-3213: Refactor ProtoBuf handler flow

Github user WireBaron commented on a diff in the pull request: https://github.com/apache/geode/pull/646#discussion_r128600182 --- Diff: geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/ProtobufOpsProcessor.java --- @@ -15,32 +15,35 @@ package org.apache.geode.p

Re: Avoid mutating standard Java System Properties (even in tests)

Indeed, this is frowned upon by the JDK authors: http://bugs.java.com/bugdatabase/view_bug.do?bug_id=4045688 In the long term, we need to change our code to no longer assume that “user.dir” is the working directory of a given server/

Re: Avoid mutating standard Java System Properties (even in tests)

Oops. Correction on #3: Looks like the caller of ManagementAdapter#handleCacheCreation(InternalCache) DOES log any caught exceptions. But because the test uses a log-file that lives in a JUnit TemporaryFolder, we have no visibility of the logged exception after the test completes. This is one time

Avoid mutating standard Java System Properties (even in tests)

We found the cause of DiskStoreMXBeanSecurityJUnitTest failing in CI: https://issues.apache.org/jira/browse/GEODE-3251. I think we should avoid setting or clearing any standard Java System properties during runtime (even in tests). These are the properties that JVM automatically sets: https://docs

Re: Proposal: Lucene indexing/searching for nested objects

On Thu, Jul 20, 2017 at 10:57 AM, Jacob Barrett wrote: > I really feel like an annotation would make the most sense. How likely is > it that the object could not be annotated or the serializer for the object > is not tightly coupled with the object? Having to map objects to > serializers external

Re: Review Request 60985: GEODE-3217: Reimplement gfsh query as a single-step command

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60985/#review181069 --- Ship it! Ship It! - Ken Howe On July 20, 2017, 5:54 p.m., Ja

Re: Review Request 60985: GEODE-3217: Reimplement gfsh query as a single-step command

> On July 20, 2017, 2:52 p.m., Ken Howe wrote: > > geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/QueryCommandUnitTest.java > > Lines 24 (patched) > > > > > > Seems there's opportunity for

Re: Review Request 61003: GEODE-393: GetRegionFunction uses the cache in the FunctionContext

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61003/#review181066 --- Ship it! geode-core/src/test/java/org/apache/geode/management/

Re: Proposal: Lucene indexing/searching for nested objects

I really feel like an annotation would make the most sense. How likely is it that the object could not be annotated or the serializer for the object is not tightly coupled with the object? Having to map objects to serializers externally then becomes a lot more complicated to keep consistent. Se

Re: Review Request 60985: GEODE-3217: Reimplement gfsh query as a single-step command

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60985/ --- (Updated July 20, 2017, 5:54 p.m.) Review request for geode, Emily Yeh, Jared S

[GitHub] geode pull request #609: GEODE-2886 : sent IllegalStateException instead of ...

Github user jhuynh1 commented on a diff in the pull request: https://github.com/apache/geode/pull/609#discussion_r128584677 --- Diff: geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/LuceneServiceImpl.java --- @@ -472,12 +478,20 @@ public boolean waitUntilFlushed(

[GitHub] geode pull request #609: GEODE-2886 : sent IllegalStateException instead of ...

Github user jhuynh1 commented on a diff in the pull request: https://github.com/apache/geode/pull/609#discussion_r128585366 --- Diff: geode-lucene/src/test/java/org/apache/geode/cache/lucene/LuceneQueriesIntegrationTest.java --- @@ -290,6 +295,24 @@ public void queryJsonObject() t

[GitHub] geode pull request #609: GEODE-2886 : sent IllegalStateException instead of ...

Github user jhuynh1 commented on a diff in the pull request: https://github.com/apache/geode/pull/609#discussion_r128586252 --- Diff: geode-lucene/src/test/java/org/apache/geode/cache/lucene/LuceneQueriesIntegrationTest.java --- @@ -290,6 +295,24 @@ public void queryJsonObject() t

[GitHub] geode pull request #609: GEODE-2886 : sent IllegalStateException instead of ...

Github user jhuynh1 commented on a diff in the pull request: https://github.com/apache/geode/pull/609#discussion_r128584345 --- Diff: geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/distributed/WaitUntilFlushedFunction.java --- @@ -85,8 +72,8 @@ public void execu

Review Request 61003: GEODE-393: GetRegionFunction uses the cache in the FunctionContext

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61003/ --- Review request for geode, Emily Yeh, Jared Stewart, Ken Howe, Kirk Lund, and Pat

Re: Proposal: Lucene indexing/searching for nested objects

This proposal doesn't really talk about XML or gfsh support. The XML should probably just be a nested xml element, like this. It should have the same support for declarables that other callbacks in the xml do. com.mycompany.MySerializer The gfsh command to create an index should also accep

[GitHub] geode pull request #641: GetServersResponse number of servers was redundant.

Github user asfgit closed the pull request at: https://github.com/apache/geode/pull/641 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabl

[GitHub] geode issue #450: GEODE-2632: create ClientCachePutBench

Github user kirklund commented on the issue: https://github.com/apache/geode/pull/450 I'll wrap up this PR soon. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishe

[GitHub] geode pull request #623: GEODE-3156: add AcceptanceTest gradle target and ju...

Github user kirklund closed the pull request at: https://github.com/apache/geode/pull/623 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is ena

Geode PR pile up

Hi there fellow Geode devs. I've just been cleaning up some PR's, and I'm seeing that we 33 odd PR's open, 20 of them older than 30 days. Not beat on the pedantic drum, but it would be really nice to have the PR's either applied, addressed or closed(rejected). Does anyone have any ideas how

[GitHub] geode pull request #646: GEODE-3213: Refactor ProtoBuf handler flow

Github user kohlmu-pivotal commented on a diff in the pull request: https://github.com/apache/geode/pull/646#discussion_r128567505 --- Diff: geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/utilities/ProtobufResponseUtilities.java --- @@ -67,30 +68,27 @@ *

[GitHub] geode issue #623: GEODE-3156: add AcceptanceTest gradle target and junit cat...

Github user kirklund commented on the issue: https://github.com/apache/geode/pull/623 Pulling this PR in now. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes s

[GitHub] geode pull request #646: GEODE-3213: Refactor ProtoBuf handler flow

Github user kohlmu-pivotal commented on a diff in the pull request: https://github.com/apache/geode/pull/646#discussion_r128386349 --- Diff: geode-protobuf/src/test/java/org/apache/geode/protocol/protobuf/operations/PutRequestOperationHandlerJUnitTest.java --- @@ -124,20 +128,19 @

[GitHub] geode pull request #646: GEODE-3213: Refactor ProtoBuf handler flow

Github user kohlmu-pivotal commented on a diff in the pull request: https://github.com/apache/geode/pull/646#discussion_r128386432 --- Diff: geode-protobuf/src/test/java/org/apache/geode/protocol/protobuf/operations/PutRequestOperationHandlerJUnitTest.java --- @@ -99,23 +105,21 @@

[GitHub] geode pull request #646: GEODE-3213: Refactor ProtoBuf handler flow

Github user kohlmu-pivotal commented on a diff in the pull request: https://github.com/apache/geode/pull/646#discussion_r128388403 --- Diff: geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/utilities/ProtobufResponseUtilities.java --- @@ -35,10 +37,9 @@ * @p

[GitHub] geode pull request #646: GEODE-3213: Refactor ProtoBuf handler flow

Github user kohlmu-pivotal commented on a diff in the pull request: https://github.com/apache/geode/pull/646#discussion_r128387458 --- Diff: geode-protobuf/src/main/java/org/apache/geode/protocol/operations/OperationContext.java --- @@ -0,0 +1,57 @@ +/* + * Licensed to the

[GitHub] geode pull request #646: GEODE-3213: Refactor ProtoBuf handler flow

Github user kohlmu-pivotal commented on a diff in the pull request: https://github.com/apache/geode/pull/646#discussion_r128386591 --- Diff: geode-protobuf/src/test/java/org/apache/geode/protocol/protobuf/operations/PutRequestOperationHandlerJUnitTest.java --- @@ -64,11 +72,10 @@

[GitHub] geode pull request #598: GEODE-2818: Completing implementation/testing of al...

Github user asfgit closed the pull request at: https://github.com/apache/geode/pull/598 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabl

Re: Review Request 60985: GEODE-3217: Reimplement gfsh query as a single-step command

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60985/#review181043 --- geode-core/src/main/java/org/apache/geode/management/internal/cli

RE: need information about SerialGatewaySenderQueue/ParallelGatewaySenderQueue Clear

Thanks Dan, I have updated the Clear method for parallel queue. @Override public void clearQueue() { this.sender.pause(); try{ this.sender.getLifeCycleLock().readLock().lock(); for (PartitionedRegion prQ : this.userRegionNameToshadowPRMap.values(

RE: Geode-Native Windows build

In VS2017 installer I had to install the following components: .NetFramework targeting pack 4.5.2 VC++ 2015.3 v140 toolset VC++ 2017 v141 toolset Windows 10 SDK for Desktop c++ x86 and x64 JavaScript and TypeScript language support TypeScript 2.2 SDK Daniel -Original Message- From: Jacob