----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60985/#review181069 -----------------------------------------------------------
Ship it! Ship It! - Ken Howe On July 20, 2017, 5:54 p.m., Jared Stewart wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60985/ > ----------------------------------------------------------- > > (Updated July 20, 2017, 5:54 p.m.) > > > Review request for geode, Emily Yeh, Jared Stewart, Ken Howe, Kirk Lund, and > Patrick Rhomberg. > > > Repository: geode > > > Description > ------- > > GEODE-3217: Reimplement gfsh query as a single-step command > > > Diffs > ----- > > > geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/DataCommands.java > 3f4397b > > geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/QueryCommand.java > PRE-CREATION > > geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/QueryInterceptor.java > PRE-CREATION > > geode-core/src/main/java/org/apache/geode/management/internal/cli/domain/DataCommandResult.java > fe88fc9 > > geode-core/src/main/java/org/apache/geode/management/internal/cli/functions/DataCommandFunction.java > 41cc171 > > geode-core/src/main/java/org/apache/geode/management/internal/cli/shell/Gfsh.java > 8ab7c93 > > geode-core/src/main/java/org/apache/geode/management/internal/web/controllers/DataCommandsController.java > fb63184 > > geode-core/src/test/java/org/apache/geode/management/DataCommandMBeanTest.java > e5d6ce8 > > geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/QueryCommandTest.java > PRE-CREATION > > geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/QueryCommandUnitTest.java > PRE-CREATION > > geode-core/src/test/java/org/apache/geode/management/internal/cli/result/ResultBuilderTest.java > PRE-CREATION > > > Diff: https://reviews.apache.org/r/60985/diff/2/ > > > Testing > ------- > > Precheckin passed (except for some flaky failures that appear to be unrelated) > > > Thanks, > > Jared Stewart > >
