Github user kohlmu-pivotal commented on a diff in the pull request:
https://github.com/apache/geode/pull/646#discussion_r128567505
--- Diff:
geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/utilities/ProtobufResponseUtilities.java
---
@@ -67,30 +68,27 @@
* {@link ProtobufUtilities}
* @return A response indicating the passed value was found for a
incoming GetRequest
*/
- public static ClientProtocol.Response
createGetResponse(BasicTypes.EncodedValue resultValue) {
- RegionAPI.GetResponse getResponse =
- RegionAPI.GetResponse.newBuilder().setResult(resultValue).build();
- return
ClientProtocol.Response.newBuilder().setGetResponse(getResponse).build();
+ public static Success<RegionAPI.GetResponse> createGetResult(
+ BasicTypes.EncodedValue resultValue) {
+ return new
Success<>(RegionAPI.GetResponse.newBuilder().setResult(resultValue).build());
--- End diff --
could we replace these types of calls with inline `Success.of(EncodedValue)`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
