[GitHub] geode pull request #577: Feature/geode 3049

Github user nreich commented on a diff in the pull request: https://github.com/apache/geode/pull/577#discussion_r121828113 --- Diff: geode-core/src/main/java/org/apache/geode/internal/cache/BucketRedundancyTracker.java --- @@ -0,0 +1,108 @@ +/* + * Licensed to the Apache S

Please Update or Verify Your IDE Style Scheme.

Hello, all. A recent update to the develop branch (a561bd...) resolves the disagreement between IntelliJ and Eclipse import ordering. The IntelliJ style xml present in geode/etc was inconsistent with the Eclipse import ordering file located in the same directory. IntelliJ users, please update yo

[GitHub] geode pull request #579: GEODE-3070: Fix gemfire.jar to be geode-dependencie...

GitHub user karensmolermiller opened a pull request: https://github.com/apache/geode/pull/579 GEODE-3070: Fix gemfire.jar to be geode-dependencies.jar Updated a few other errors found along the way, including the name of the RAR file for JTA transactions, and outdated output

[Spring CI] Spring Data GemFire > Nightly-ApacheGeode > #584 was SUCCESSFUL (with 1868 tests)

--- Spring Data GemFire > Nightly-ApacheGeode > #584 was successful. --- Scheduled 1870 tests in total. https://build.spring.io/browse/SGF-NAG-584/ -- This

Fwd: [GitHub] geode pull request #569: Resolve Eclipse/IntelliJ import order disagreement

This is just pulled on to develop to resolve the import order difference between intelliJ and Eclipse. For IntelliJ users, please go to your settings->Code Style->Java and click the little gear symbol beside the "Scheme" box to import the new intellJ sytle xml into your IDEA, the xml is in under o

Re: [VOTE] Using Pull Requests over Review Board

On Mon, Jun 12, 2017 at 4:20 PM Udo Kohlmeyer wrote:\ > * -1 for PR: I fear that given the huge amount of incoming PR's we > might loose sight/oversight of any PR's that need to be approved > from external submitters. How does having to check review board and PR help this situation?

[GitHub] geode pull request #569: Resolve Eclipse/IntelliJ import order disagreement

Github user asfgit closed the pull request at: https://github.com/apache/geode/pull/569 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabl

Re: [DISCUSS] Using Pull Requests over Review Board

On Mon, Jun 12, 2017 at 9:37 AM Dave Barnes wrote: > Proposal as written says "...for changes that would require peer review > before committing...". > If this means that minor changes (in my case, typo repairs are the common > case) can be checked in without going through a PR process, I can go

Re: [DISCUSS] Using Pull Requests over Review Board

On Mon, Jun 12, 2017 at 7:57 AM Bruce Schuchardt wrote: > It places an unnecessary burden on committers Considering committers need to use PR to commit changes from non-committers how does reducing the number of review systems increase the burden on committers? > and git history is the > defi

Re: Review Request 60051: GEODE-2301: Deprecate JTA TransactionManagerImpl

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60051/#review177814 --- All of these changes are to classes in an "internal" package. Do w

Re: Review Request 60051: GEODE-2301: Deprecate JTA TransactionManagerImpl

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60051/#review177813 --- geode-core/src/main/java/org/apache/geode/internal/jta/GlobalTran

Re: Review Request 60028: GEODE-2632: consolidate different types of SecurityService

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60028/ --- (Updated June 13, 2017, 9:28 p.m.) Review request for geode, Emily Yeh, Jared S

[GitHub] geode pull request #578: GEODE-1958: Removing/deprecating PasswordUtil

Github user PurelyApplied commented on a diff in the pull request: https://github.com/apache/geode/pull/578#discussion_r121799720 --- Diff: geode-core/src/main/java/org/apache/geode/internal/SystemAdmin.java --- @@ -1909,10 +1900,7 @@ private static boolean needsSysDir(String cmd)

[GitHub] geode pull request #578: GEODE-1958: Removing/deprecating PasswordUtil

Github user PurelyApplied commented on a diff in the pull request: https://github.com/apache/geode/pull/578#discussion_r121798399 --- Diff: geode-core/src/main/java/org/apache/geode/internal/util/PasswordUtil.java --- @@ -44,72 +42,29 @@ private static byte[] init = "string"

Re: Review Request 60052: GEODE-2294: revert to avoid rest protocol change

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60052/#review177805 --- Ship it! Ship It! - Jared Stewart On June 13, 2017, 5:29 p.m

Re: Review Request 60025: GEODE-3060: Introduce JUnit rule for testing the fully-assembled GFSH

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60025/#review177795 --- geode-assembly/src/test/java/org/apache/geode/test/dunit/rules/gf

Re: Review Request 60028: GEODE-2632: consolidate different types of SecurityService

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60028/ --- (Updated June 13, 2017, 8:26 p.m.) Review request for geode, Emily Yeh, Jared S

Re: Review Request 60028: GEODE-2632: consolidate different types of SecurityService

> On June 13, 2017, 7 p.m., Kirk Lund wrote: > > -1 I don't see why these changes are needed other than to wipe out what I > > did? For example, you've undone my introduction of RealmInitializer and > > ConfigInitializer. I introduced those so I can continue writing more > > mocking tests for

[GitHub] geode pull request #577: Feature/geode 3049

Github user dschneider-pivotal commented on a diff in the pull request: https://github.com/apache/geode/pull/577#discussion_r121776319 --- Diff: geode-core/src/main/java/org/apache/geode/internal/cache/PartitionedRegionRedundancyTracker.java --- @@ -0,0 +1,133 @@ +/* + * L

[GitHub] geode pull request #577: Feature/geode 3049

Github user dschneider-pivotal commented on a diff in the pull request: https://github.com/apache/geode/pull/577#discussion_r121751707 --- Diff: geode-core/src/main/java/org/apache/geode/internal/cache/BucketRedundancyTracker.java --- @@ -0,0 +1,108 @@ +/* + * Licensed to

[GitHub] geode pull request #577: Feature/geode 3049

Github user dschneider-pivotal commented on a diff in the pull request: https://github.com/apache/geode/pull/577#discussion_r121742105 --- Diff: geode-core/src/main/java/org/apache/geode/internal/cache/BucketRedundancyTracker.java --- @@ -0,0 +1,108 @@ +/* + * Licensed to

Re: Review Request 60030: GEODE-2925: finer security for disk management

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60030/#review177787 --- geode-core/src/main/java/org/apache/geode/management/internal/cli

Re: Review Request 60010: GEODE-3062: replace SecurityService after loading cluster config

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60010/#review177784 --- geode-core/src/test/java/org/apache/geode/management/internal/con

Re: Review Request 60010: GEODE-3062: replace SecurityService after loading cluster config

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60010/#review177783 --- Ship it! Ship It! - Patrick Rhomberg On June 13, 2017, 4:29

Re: Review Request 60028: GEODE-2632: consolidate different types of SecurityService

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60028/#review177781 --- -1 I don't see why these changes are needed other than to wipe out

Re: Review Request 60010: GEODE-3062: replace SecurityService after loading cluster config

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60010/#review19 --- Ship it! Ship It! - Emily Yeh On June 13, 2017, 4:29 p.m., K

Build failed in Jenkins: Geode-release #62

See Changes: [dbarnes] Update geode-book README instructions -- [...truncated 119.41 KB...] :geode-old-client-support:jar :geode-old-client-support:javadoc :geode-old-client-su

Re: Review Request 60052: GEODE-2294: revert to avoid rest protocol change

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60052/#review177767 --- Ship it! Ship It! - Emily Yeh On June 13, 2017, 5:29 p.m., J

Re: Review Request 59811: GEODE-2420: add file-size-limit param to the ExportLogsController

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59811/#review177765 --- Ship it! Ship It! - Emily Yeh On June 8, 2017, 9:08 p.m., Ke

[GitHub] geode issue #573: GEODE-2622: Fix test failures caused by upgrade to Mockito...

Github user srikanthmanvi commented on the issue: https://github.com/apache/geode/pull/573 Thank you Kirk, I will close this PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] geode pull request #573: GEODE-2622: Fix test failures caused by upgrade to ...

Github user srikanthmanvi closed the pull request at: https://github.com/apache/geode/pull/573 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature i

Re: Review Request 60052: GEODE-2294: revert to avoid rest protocol change

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60052/#review177763 --- Ship it! Ship It! - Anthony Baker On June 13, 2017, 5:29 p.m

Re: Build failed in Jenkins: Geode-nightly #865

Thanks Mark! On Tue, Jun 13, 2017 at 10:11 AM, Mark Bretl wrote: > Done > > --Mark > > On Tue, Jun 13, 2017 at 9:58 AM, Kirk Lund wrote: > > > Can someone with Jenkins permissions please excluded mesos2 from being > used > > for our nightly builds? > > > > ERROR: JAVA_HOME is set to an invalid

Review Request 60052: GEODE-2294: revert to avoid rest protocol change

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60052/ --- Review request for geode, Anthony Baker, Emily Yeh, Jared Stewart, Ken Howe, Kir

[GitHub] geode issue #578: GEODE-1958: Removing PasswordUtil

Github user YehEmily commented on the issue: https://github.com/apache/geode/pull/578 Precheckin is mostly green, with one (seemingly unrelated) test failure! I'm rerunning the test and looking into the failure now. --- If your project is set up for it, you can reply to this email an

[GitHub] geode pull request #578: GEODE-1958: Removing PasswordUtil

GitHub user YehEmily opened a pull request: https://github.com/apache/geode/pull/578 GEODE-1958: Removing PasswordUtil [View the original JIRA ticket here.](https://issues.apache.org/jira/browse/GEODE-1958) `PasswordUtil.java` contained methods used to encrypt a password to

Re: Build failed in Jenkins: Geode-nightly #865

Done --Mark On Tue, Jun 13, 2017 at 9:58 AM, Kirk Lund wrote: > Can someone with Jenkins permissions please excluded mesos2 from being used > for our nightly builds? > > ERROR: JAVA_HOME is set to an invalid directory: /home/jenkins/tools/java/ > latest1.8 > > -- Forwarded message -

Re: Review Request 60030: GEODE-2925: finer security for disk management

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60030/#review177760 --- Ship it! Ship It! - Emily Yeh On June 12, 2017, 9:14 p.m., J

Re: Review Request 60025: GEODE-3060: Introduce JUnit rule for testing the fully-assembled GFSH

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60025/#review177759 --- Fix it, then Ship it! I had a teeny tiny nitpick, but otherwise

Fwd: Build failed in Jenkins: Geode-nightly #865

Can someone with Jenkins permissions please excluded mesos2 from being used for our nightly builds? ERROR: JAVA_HOME is set to an invalid directory: /home/jenkins/tools/java/ latest1.8 -- Forwarded message -- From: Apache Jenkins Server Date: Mon, Jun 12, 2017 at 8:42 PM Subject:

Review Request 60051: GEODE-2301: Deprecate JTA TransactionManagerImpl

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60051/ --- Review request for geode, anilkumar gingade, Darrel Schneider, Lynn Gallinat, an

Re: Review Request 60028: GEODE-2632: consolidate different types of SecurityService

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60028/ --- (Updated June 13, 2017, 4:49 p.m.) Review request for geode, Emily Yeh, Jared S

Re: Review Request 60010: GEODE-3062: replace SecurityService after loading cluster config

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60010/#review177755 --- Ship it! Ship It! - Jinmei Liao On June 13, 2017, 4:29 p.m.,

Re: release 1.2

Vahram, Thanks for advocating for this issue! While the release it pretty locked down for changes, this looks like a low risk change for an important issue. I’ll cherry-pick the changes onto release/1.2.0. I also see that a breaking change to the REST API was made in ‘c39585395a’. Can some

Re: Review Request 60030: GEODE-2925: finer security for disk management

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60030/#review177754 --- Fix it, then Ship it! Fix it and ship it! geode-core/src/test

Re: Review Request 60010: GEODE-3062: replace SecurityService after loading cluster config

> On June 12, 2017, 7:59 p.m., Jared Stewart wrote: > > geode-core/src/main/java/org/apache/geode/internal/cache/GemFireCacheImpl.java > > Lines 327 (patched) > > > > > > Are you sure that we want to keep this respon

Re: Review Request 60010: GEODE-3062: replace SecurityService after loading cluster config

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60010/ --- (Updated June 13, 2017, 4:29 p.m.) Review request for geode, Emily Yeh, Jinmei

[GitHub] geode pull request #575: GEODE-3048: Editing tests requiring Gradle test run...

Github user YehEmily commented on a diff in the pull request: https://github.com/apache/geode/pull/575#discussion_r121717861 --- Diff: geode-assembly/src/test/java/org/apache/geode/management/internal/cli/commands/LauncherLifecycleCommandsIntegrationTest.java --- @@ -39,6 +39,8 @@

[GitHub] geode pull request #575: GEODE-3048: Editing tests requiring Gradle test run...

Github user pdxrunner commented on a diff in the pull request: https://github.com/apache/geode/pull/575#discussion_r121690753 --- Diff: geode-assembly/src/test/java/org/apache/geode/management/internal/cli/commands/LauncherLifecycleCommandsIntegrationTest.java --- @@ -39,6 +39,8 @

[GitHub] geode pull request #575: GEODE-3048: Editing tests requiring Gradle test run...

Github user pdxrunner commented on a diff in the pull request: https://github.com/apache/geode/pull/575#discussion_r121690706 --- Diff: geode-assembly/src/test/java/org/apache/geode/rest/internal/web/controllers/RestAPIOnRegionFunctionExecutionDUnitTest.java --- @@ -26,7 +26,9 @@

Re: Review Request 60025: GEODE-3060: Introduce JUnit rule for testing the fully-assembled GFSH

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60025/#review177737 --- Ship it! Ship It! - Ken Howe On June 12, 2017, 9:50 p.m., Ja