----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60025/#review177759 -----------------------------------------------------------
Fix it, then Ship it! I had a teeny tiny nitpick, but otherwise, it looks great! Ship it! geode-assembly/src/test/java/org/apache/geode/test/dunit/rules/gfsh/GfshRule.java Lines 83-84 (patched) <https://reviews.apache.org/r/60025/#comment251471> It may (or may not?) be helpful to include a comment here to explain why nothing happens when the exception is caught, like in line 99 of `GfshScript.java` (`// ignore since we are waiting *quietly*`). - Emily Yeh On June 12, 2017, 9:50 p.m., Jared Stewart wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60025/ > ----------------------------------------------------------- > > (Updated June 12, 2017, 9:50 p.m.) > > > Review request for geode, Emily Yeh, Jared Stewart, Ken Howe, Kirk Lund, and > Patrick Rhomberg. > > > Repository: geode > > > Description > ------- > > GEODE-3060: Introduce JUnit rule for testing the fully-assembled GFSH > > > Diffs > ----- > > > geode-assembly/src/test/java/org/apache/geode/management/internal/cli/commands/StatusLocatorRealGfshTest.java > PRE-CREATION > > geode-assembly/src/test/java/org/apache/geode/test/dunit/rules/gfsh/GfshRule.java > PRE-CREATION > > geode-assembly/src/test/java/org/apache/geode/test/dunit/rules/gfsh/GfshScript.java > PRE-CREATION > > > Diff: https://reviews.apache.org/r/60025/diff/2/ > > > Testing > ------- > > Precheckin started (still running) > > > Thanks, > > Jared Stewart > >
