[GitHub] geode issue #568: GEODE-290 : Removed deprecated method stopWithPort from Lo...

Github user ameybarve15 commented on the issue: https://github.com/apache/geode/pull/568 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the fea

Re: Review Request 59852: GEODE-2632: make SecurityService immutable to improve client/server performance

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59852/#review177439 --- Ship it! Ship It! - Jinmei Liao On June 8, 2017, 9:22 p.m.,

Re: [DISCUSS] Using Pull Requests over Review Board

One feature I like about PRs on GitHub that I haven't figured out how to do on Review Board is breaking up a large changeset (which I would like to have reviewed together) into multiple commits. It can be a useful way to tell a story about your changes, but keep the review for them in one place. I

Re: Review Request 59850: GEODE-3023: TcpServer thread can be blocked in processRequest

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59850/#review177427 --- Fix it, then Ship it! I had a couple of minor comments about th

Re: release 1.2

Sounds good. Please cherry-pick these changes onto release/1.2.0 when ready. Anthony > On Jun 8, 2017, at 3:15 PM, Jared Stewart wrote: > > I think we probably ought to include GEODE-3045 > as well. > >> On Jun 8, 2017, at 3:12 PM, Kennet

[GitHub] geode issue #571: GEODE-2601: Fixing banner being logged twice during locato...

Github user YehEmily commented on the issue: https://github.com/apache/geode/pull/571 Precheckin is in progress! Some failures so far that also exist on the develop branch - will take a look at those soon. --- If your project is set up for it, you can reply to this email and have you

[GitHub] geode pull request #571: GEODE-2601: Fixing banner being logged twice during...

GitHub user YehEmily opened a pull request: https://github.com/apache/geode/pull/571 GEODE-2601: Fixing banner being logged twice during locator startup Now only logs once if both locator and distributed systems are started! There appear to be some minor changes in various places

Re: Review Request 59925: GEODE-3052 Restarting 2 locators within 1s of each other causes potential locator split brain

> On June 8, 2017, 11:45 p.m., Galen O'Sullivan wrote: > > This makes sense to me: we remove the locators if we can't connect to them. > > > > I wonder what happens if the two locators can't talk to each other (at > > first, anyways) but can talk to the rest of the cluster. I imagine this is >

Re: Review Request 59925: GEODE-3052 Restarting 2 locators within 1s of each other causes potential locator split brain

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59925/#review177422 --- Ship it! This makes sense to me: we remove the locators if we c

Re: Review Request 59925: GEODE-3052 Restarting 2 locators within 1s of each other causes potential locator split brain

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59925/#review177419 --- Ship it! Ship It! - Udo Kohlmeyer On June 8, 2017, 6:36 p.m.

[GitHub] geode issue #565: GEODE-3021: Any call after the first to setPdxStringFlag s...

Github user jhuynh1 commented on the issue: https://github.com/apache/geode/pull/565 @boglesby @upthewaterspout @gesterzhou Adding additional reviewers --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[Spring CI] Spring Data GemFire > Nightly-ApacheGeode > #579 was SUCCESSFUL (with 1868 tests)

--- Spring Data GemFire > Nightly-ApacheGeode > #579 was successful (rerun once). --- This build was rerun by John Blum. 1870 tests in total. https://build.sprin

[Spring CI] Spring Data GemFire > Nightly-ApacheGeode > #579 has FAILED (1 tests failed)

--- Spring Data GemFire > Nightly-ApacheGeode > #579 failed. --- Scheduled 1/1870 tests failed. https://build.spring.io/browse/SGF-NAG-579/

Re: Review Request 59926: waitUntilFlush should check if its brq's tempQueue is not empty

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59926/#review177413 --- Ship it! Ship It! - Barry Oglesby On June 8, 2017, 6:43 p.m.

Re: Review Request 59852: GEODE-2632: make SecurityService immutable to improve client/server performance

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59852/#review177391 --- geode-core/src/main/java/org/apache/geode/internal/cache/tier/soc

Re: Review Request 59852: GEODE-2632: make SecurityService immutable to improve client/server performance

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59852/#review177410 --- Ship it! Ship It! - Jared Stewart On June 8, 2017, 9:22 p.m.

Re: release 1.2

I think we probably ought to include GEODE-3045 as well. > On Jun 8, 2017, at 3:12 PM, Kenneth Howe wrote: > > I think we should also include the fix for GEODE-3054 in 1.2. This is a bug > that was introduced in the recent changes to the Gfs

Re: release 1.2

I think we should also include the fix for GEODE-3054 in 1.2. This is a bug that was introduced in the recent changes to the Gfsh parser, and affects Windows pathnames specified in options to gfsh commands. https://issues.apache.org/jira/browse/GEODE-3054

[GitHub] geode pull request #570: GEODE-3055: waitUntilFlush should use data region's...

GitHub user gesterzhou opened a pull request: https://github.com/apache/geode/pull/570 GEODE-3055: waitUntilFlush should use data region's bucketid list. So… @upthewaterspout @boglesby …me of the buckets maybe not initialized, then wait for tempQueue to be empty.

Re: [DISCUSS] Using Pull Requests over Review Board

On Thu, Jun 8, 2017 at 2:24 PM Nabarun Nag wrote: > Also, IMHO feature branches from which the PRs are created should be in our > personal fork rather than the main geode git repo. > +1 - I had planned to bring this up in a separate discussion but yes, I think all work should happen out of your

Re: [DISCUSS] Using Pull Requests over Review Board

+1 on using PR. We can use the @tags and the github notification page[Participating tag] to check the PRs that need our attention. Also, IMHO feature branches from which the PRs are created should be in our personal fork rather than the main geode git repo. Because when we push a branch called fea

release 1.2

I'd like to include the fix for GEODE-3052 in the 1.2 release. It's under review now and has passed new tests and is in precheckin testing. https://issues.apache.org/jira/browse/GEODE-3052 "Restarting 2 locators within 1s of each other causes potential locator split brain"

Re: Review Request 59852: GEODE-2632: make SecurityService immutable to improve client/server performance

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59852/ --- (Updated June 8, 2017, 9:22 p.m.) Review request for geode, Emily Yeh, Jinmei L

Re: Review Request 59692: GEODE-2925: add target for resource operation for finer grained security

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59692/#review177383 --- Ship it! Ship it after GEODE-2632 is merged to develop. - Kirk

Re: Review Request 59754: GEODE-2928: get rid of the isGfshVM static variable

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59754/#review177382 --- Fix it, then Ship it! Fix it and ship it! geode-core/src/test

Re: Review Request 59811: GEODE-2420: add file-size-limit param to the ExportLogsController

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59811/#review177380 --- Ship it! Ship It! - Kirk Lund On June 8, 2017, 9:08 p.m., Ke

Re: Review Request 59905: GEODE-2933: Add jmx-manager-hostname-for-clients for startLocator and startServer

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59905/#review177377 --- Fix it, then Ship it! Fix the test category on LauncherLifecycl

Re: Review Request 59811: GEODE-2420: add file-size-limit param to the ExportLogsController

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59811/ --- (Updated June 8, 2017, 9:08 p.m.) Review request for geode, Emily Yeh, Jinmei L

Re: Review Request 59852: GEODE-2632: make SecurityService immutable to improve client/server performance

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59852/ --- (Updated June 8, 2017, 9:04 p.m.) Review request for geode, Emily Yeh, Jinmei L

Re: Review Request 59852: GEODE-2632: make SecurityService immutable to improve client/server performance

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59852/ --- (Updated June 8, 2017, 9:02 p.m.) Review request for geode, Emily Yeh, Jinmei L

Build failed in Jenkins: Geode-release #58

See Changes: [boglesby] GEODE-3040: Compare gateway profile order policy against 9.0 instead of [dbarnes] GEODE-3044: User Manual: Update Swagger example and screen shots - [dbarnes] GEODE-2555: Region Management d

Re: Review Request 59896: GEODE-3043 surprise member added when the member is already in the cluster

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59896/#review177375 --- Ship it! Ship It! - Brian Rowe On June 7, 2017, 10:02 p.m.,

Re: Review Request 59894: GEODE-3041 CI failure: DistributedMemberDUnitTest.testGroupsInAllVMs fails intermittently

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59894/#review177374 --- Ship it! Ship It! - Brian Rowe On June 7, 2017, 9:56 p.m., B

Re: Review Request 59925: GEODE-3052 Restarting 2 locators within 1s of each other causes potential locator split brain

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59925/#review177371 --- Ship it! Ship It! - Brian Rowe On June 8, 2017, 6:36 p.m., B

Re: Review Request 59924: Reverted GEODE-2804 (Allow a locator host to be taken off line and replaced with a different machine having the same host name)

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59924/#review177365 --- Ship it! Ship It! - Bruce Schuchardt On June 8, 2017, 5:54 p

Re: Review Request 59923: GEODE-3029: Tomcat Install Documentation has incorrect required JARs

> On June 8, 2017, 8:05 p.m., David Anuta wrote: > > Looks good! - David --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59923/#review177363 --

Re: Review Request 59923: GEODE-3029: Tomcat Install Documentation has incorrect required JARs

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59923/#review177363 --- - David Anuta On June 8, 2017, 5:33 p.m., Dave Barnes wrote: >

Re: Review Request 59905: GEODE-2933: Add jmx-manager-hostname-for-clients for startLocator and startServer

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59905/#review177358 --- Ship it! Ship It! - Jinmei Liao On June 8, 2017, 5:33 p.m.,

Re: Review Request 59905: GEODE-2933: Add jmx-manager-hostname-for-clients for startLocator and startServer

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59905/#review177357 --- Ship it! Ship It! - Emily Yeh On June 8, 2017, 5:33 p.m., Ja

Re: [DISCUSS] Using Pull Requests over Review Board

On Thu, Jun 8, 2017 at 12:35 PM Mark Bretl wrote: > I like the functionality we get with GitHub, including the Travis CI > integration. > > Do we have a proposed workflow change for committers? The proposed workflow change to committers is to use the same workflow as contributors. The only diff

Re: [DISCUSS] Using Pull Requests over Review Board

I like the functionality we get with GitHub, including the Travis CI integration. Do we have a proposed workflow change for committers? --Mark On Thu, Jun 8, 2017 at 11:20 AM, Jacob Barrett wrote: > Some more fuel on this fire... PR's get checked against Travis CI > automatically and the resul

Re: Review Request 59754: GEODE-2928: get rid of the isGfshVM static variable

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59754/#review177355 --- geode-core/src/main/java/org/apache/geode/management/cli/CliMetaD

[GitHub] geode pull request #569: Resolve Eclipse/IntelliJ import order disagreement

GitHub user PurelyApplied opened a pull request: https://github.com/apache/geode/pull/569 Resolve Eclipse/IntelliJ import order disagreement The style guides contained in `etc/` are not consistent. This commit modifies `etc/intellij-java-google-style.xml` to adhere to the import

Review Request 59926: waitUntilFlush should check if its brq's tempQueue is not empty

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59926/ --- Review request for geode, Barry Oglesby and Dan Smith. Bugs: GEODE-3055 htt

Re: Review Request 59894: GEODE-3041 CI failure: DistributedMemberDUnitTest.testGroupsInAllVMs fails intermittently

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59894/#review177350 --- Ship it! Ship It! - Hitesh Khamesra On June 7, 2017, 9:56 p.

Review Request 59925: GEODE-3052 Restarting 2 locators within 1s of each other causes potential locator split brain

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59925/ --- Review request for geode, Alexander Murmann, Galen O'Sullivan, Hitesh Khamesra,

Re: Review Request 59894: GEODE-3041 CI failure: DistributedMemberDUnitTest.testGroupsInAllVMs fails intermittently

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59894/#review177349 --- Ship it! Ship It! - Udo Kohlmeyer On June 7, 2017, 9:56 p.m.

Re: Review Request 59924: Reverted GEODE-2804 (Allow a locator host to be taken off line and replaced with a different machine having the same host name)

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59924/#review177348 --- Ship it! If precheckin passes... Ship it.. - Udo Kohlmeyer O

Re: [DISCUSS] Using Pull Requests over Review Board

Some more fuel on this fire... PR's get checked against Travis CI automatically and the results show up in the PR. This is a good safety check even for committers before merging their branch into the development branch. -Jake

Re: [DISCUSS] Discussions of API changes missing or lost in noise

I am fine with the initial request coming to the dev list but not every update. I would have been just as happy if we had changed JIRA to just notify about new tickets and left followups with watchers only. I believe the same behavior can be achieved with PR and Reviews (although we could just stop

Re: Review Request 59923: GEODE-3029: Tomcat Install Documentation has incorrect required JARs

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59923/#review177347 --- Ship it! Ship It! - Joey McAllister On June 8, 2017, 5:33 p.

Re: [DISCUSS] Using Pull Requests over Review Board

On Thu, Jun 8, 2017 at 10:20 AM Dan Smith wrote: > One thing that can > help is if you add your github id to your apache profile - the PR will then > show that it is coming from an apache member. To illustrate what Dan is saying, notice the "Member" tag on my comment in the screen cap below. [i

Review Request 59924: Reverted GEODE-2804 (Allow a locator host to be taken off line and replaced with a different machine having the same host name)

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59924/ --- Review request for geode, Bruce Schuchardt, Galen O'Sullivan, and Udo Kohlmeyer.

Re: Review Request 59923: GEODE-3029: Tomcat Install Documentation has incorrect required JARs

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59923/#review177342 --- Ship it! Ship It! - Karen Miller On June 8, 2017, 5:33 p.m.,

Re: [DISCUSS] Discussions of API changes missing or lost in noise

The JIRA noise has gone away, which is awesome! Do we want to move github PRs and review requests off this list as well or keep sending them to the list? -Dan On Mon, Jun 5, 2017 at 1:02 PM, Anthony Baker wrote: > Fixed! Please check iss...@geode.apache.org for JIRA updates. > > Anthony > > >

Re: Review Request 59754: GEODE-2928: get rid of the isGfshVM static variable

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59754/#review177336 --- geode-core/src/main/java/org/apache/geode/management/internal/cli

Review Request 59923: GEODE-3029: Tomcat Install Documentation has incorrect required JARs

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59923/ --- Review request for geode. Repository: geode Description --- GEODE-3029:

Re: Review Request 59905: GEODE-2933: Add jmx-manager-hostname-for-clients for startLocator and startServer

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59905/ --- (Updated June 8, 2017, 5:33 p.m.) Review request for geode, Emily Yeh, Jared St

Re: [DISCUSS] Using Pull Requests over Review Board

+1 for just PRs +1 for trying the functionality Jared has pointed out in Github On Thu, Jun 8, 2017 at 10:19 AM, Jared Stewart wrote: > > On Jun 8, 2017, at 8:32 AM, Bruce Schuchardt > wrote: > > I also don't see any way to push a PR to specific individuals for review. > In Reviewboard there i

Re: [DISCUSS] Using Pull Requests over Review Board

+1 to just using PRs. I think the benefits to new people to the project make it worth it to switch. New people will see PRs from committers when they are creating their PRs, which will help provide good examples. It's one less system to sign up on as a contributor so it's easier for new people to

Re: Review Request 59811: GEODE-2420: add file-size-limit param to the ExportLogsController

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59811/#review177331 --- geode-core/src/test/java/org/apache/geode/management/internal/cli

Re: Need information about FunctionStatistics

Dinesh, The FunctionStatistics and FunctionServiceStatistics look to be displaying properly in vsd. Are you not seeing them? Thanks, Barry Oglesby On Thu, Jun 8, 2017 at 9:51 AM, Kirk Lund wrote: > I think we would probably need to introduce a new FunctionServiceMXBean > with these stats as a

Re: [DISCUSS] Using Pull Requests over Review Board

On Thu, Jun 8, 2017 at 8:32 AM Bruce Schuchardt wrote: > One thing I find confusing in PRs is whether the person submitting the > request is a committer or not. Non-committers need someone to merge the > PR while committers are just looking for a review and will merge the > changes to develop th

Re: [DISCUSS] Using Pull Requests over Review Board

I've used both PRs and Review Boards for doc changes. The Review Board's targeted reviewer list, as Bruce points out, is a plus. It would be great if PRs could do that. On Thu, Jun 8, 2017 at 9:28 AM, John Blum wrote: > +1 to Bruce's comments. > > PRs are for contributors that do not have commit

Re: [DISCUSS] Using Pull Requests over Review Board

On Thu, Jun 8, 2017 at 9:28 AM John Blum wrote: > PRs are for contributors that do not have commit privileges. ReviewBoard > is a tool for "reviewing" changes. > This isn't some law, it was our choice. What I am proposing is that we re-evaluate this choice for consistency. > However, what is

Re: Review Request 59905: GEODE-2933: Add jmx-manager-hostname-for-clients for startLocator and startServer

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59905/#review177324 --- All of my issues are nitpicks. I'm sorry. But only a little. g

Re: Need information about FunctionStatistics

I think we would probably need to introduce a new FunctionServiceMXBean with these stats as attributes or add showFunctionMetrics() operation to MemberMXBean. On Wed, Jun 7, 2017 at 6:32 AM, Dinesh Akhand wrote: > Hi Team, > > Currently I can see Function stats are getting generated . > function

Re: Build failed in Jenkins: Geode-nightly #860

We would have to exclude that machine (for now) and file an INFRA ticket to fix that machine. On Thu, Jun 8, 2017 at 9:42 AM, Jared Stewart wrote: > It looks like the most recent nightly build failed due to an invalid > JAVA_HOME directory. Do we have any control over this, or should a ticket >

Fwd: Build failed in Jenkins: Geode-nightly #860

It looks like the most recent nightly build failed due to an invalid JAVA_HOME directory. Do we have any control over this, or should a ticket be filed with Apache Infra? Thanks, Jared > Begin forwarded message: > > From: Apache Jenkins Server > Subject: Build failed in Jenkins: Geode-nig

Re: Requesting assignment permissions for Geode tickets

You've been added to the Role that can assign Geode tickets! On Thu, Jun 8, 2017 at 9:34 AM, Nick Reich wrote: > Hi, > > Could I get permissions to assign Geode tickets (especially to myself)? > User name is nreich. > > Thanks, > Nick >

Requesting assignment permissions for Geode tickets

Hi, Could I get permissions to assign Geode tickets (especially to myself)? User name is nreich. Thanks, Nick

Re: [DISCUSS] Using Pull Requests over Review Board

+1 to Bruce's comments. PRs are for contributors that do not have commit privileges. ReviewBoard is a tool for "reviewing" changes. However, what is also common practice on open source projects, even for committers, is to create a topic branch containing the commit with the desired changes (labe

Re: [DISCUSS] Using Pull Requests over Review Board

One thing I find confusing in PRs is whether the person submitting the request is a committer or not. Non-committers need someone to merge the PR while committers are just looking for a review and will merge the changes to develop themselves. I also don't see any way to push a PR to specific

Re: Review Request 59904: GEODE-3050: prevent empty dat files

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59904/#review177311 --- Ship it! Ship It! - Jinmei Liao On June 8, 2017, 12:03 a.m.,

Re: Review Request 59904: GEODE-3050: prevent empty dat files

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59904/#review177309 --- Ship it! Ship It! - Bruce Schuchardt On June 8, 2017, 12:03

Re: Review Request 59863: Removing obsolete SSL handling in `AcceptorImpl.accept` catch block

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59863/#review177308 --- Ship it! Ship It! - Bruce Schuchardt On June 8, 2017, 12:40

Re: Review Request 59893: GEODE-3032: Fix CI failure of CommandOverHttpDUnitTest

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59893/#review177303 --- Ship it! Ship It! - Ken Howe On June 7, 2017, 11:13 p.m., Ja

Build failed in Jenkins: Geode-release #57

See -- [...truncated 205.67 KB...] :geode-json:test UP-TO-DATE :geode-json:check :geode-json:build :geode-json:distributedTest UP-TO-DATE :geode-json:integrationTest UP-TO-DATE :geode-junit:ja