+1 for just PRs +1 for trying the functionality Jared has pointed out in Github
On Thu, Jun 8, 2017 at 10:19 AM, Jared Stewart <jstew...@pivotal.io> wrote: > > On Jun 8, 2017, at 8:32 AM, Bruce Schuchardt <bschucha...@pivotal.io> > wrote: > > I also don't see any way to push a PR to specific individuals for review. > In Reviewboard there is a nice queue of pending reviews that I can go > through. On github they're all mixed together and it's difficult to tell > whether any of them are relevant to me. > > > Github has functionality for this (notice the “assignees” section on the > right hand side of this PR). I believe it may be a setting in our > repository that is preventing us from actually making such assignments. > > > > I like the idea of a single source of history for reviews but I don't much > like the idea of having to create PRs on a read-only system and then merge > my changes to ASF's repo. Being able to commit directly seems like a > committer perk that your idea would take away from us. > > Can you expand a bit about what you mean by this? It would seem to me > that whether we use ReviewBoard or PRs the flow is essentially the same for > committers: > 1) Post review request (either from a diff on Reviewboard or from a branch > on a PR) > 2a) Receive feedback > 2b) Update review request (with a new diff on Reviewboard or by pushing > new commits to the branch of your PR) > 3) Merge your changes into develop and push them to the ASF repo > >
