One thing I find confusing in PRs is whether the person submitting the
request is a committer or not. Non-committers need someone to merge the
PR while committers are just looking for a review and will merge the
changes to develop themselves.
I also don't see any way to push a PR to specific individuals for
review. In Reviewboard there is a nice queue of pending reviews that I
can go through. On github they're all mixed together and it's difficult
to tell whether any of them are relevant to me.
I like the idea of a single source of history for reviews but I don't
much like the idea of having to create PRs on a read-only system and
then merge my changes to ASF's repo. Being able to commit directly
seems like a committer perk that your idea would take away from us.
On 6/7/17 6:42 PM, Jacob Barrett wrote:
All,
I would like to discuss transitioning all code reviews to pull requests
over using review board. For non-committer community members we ask them to
make pull requests against the mirrored GitHub repo. Some committers use
pull requests for their own work reviews while others use review board. I
propose that we just use on and that the one we use be pull requests. It
would give us a single source of history for reviews, a single model to
understand for reviewers and committers and keep workflow consistent with
all contributors, committers or not.
-Jake
