[GitHub] [incubator-doris] imay commented on a change in pull request #1576: Change cumulative compaction for decoupling storage from compution

imay commented on a change in pull request #1576: Change cumulative compaction for decoupling storage from compution URL: https://github.com/apache/incubator-doris/pull/1576#discussion_r313239424 ## File path: be/src/olap/base_compaction.h ## @@ -18,166 +18,30 @@ #ifndef

[GitHub] [incubator-doris] imay commented on a change in pull request #1576: Change cumulative compaction for decoupling storage from compution

imay commented on a change in pull request #1576: Change cumulative compaction for decoupling storage from compution URL: https://github.com/apache/incubator-doris/pull/1576#discussion_r313239343 ## File path: be/src/olap/base_compaction.cpp ## @@ -16,513 +16,114 @@ // un

[GitHub] [incubator-doris] imay merged pull request #1632: Fix HLLContext cast error

imay merged pull request #1632: Fix HLLContext cast error URL: https://github.com/apache/incubator-doris/pull/1632 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[GitHub] [incubator-doris] imay commented on a change in pull request #1629: Enable parsing columns from file path for Broker Load (#1582)

imay commented on a change in pull request #1629: Enable parsing columns from file path for Broker Load (#1582) URL: https://github.com/apache/incubator-doris/pull/1629#discussion_r313232047 ## File path: be/src/exec/broker_scanner.cpp ## @@ -489,18 +504,18 @@ bool BrokerS

[GitHub] [incubator-doris] imay commented on a change in pull request #1629: Enable parsing columns from file path for Broker Load (#1582)

imay commented on a change in pull request #1629: Enable parsing columns from file path for Broker Load (#1582) URL: https://github.com/apache/incubator-doris/pull/1629#discussion_r313234607 ## File path: fe/src/main/java/org/apache/doris/planner/BrokerScanNode.java ## @@

[GitHub] [incubator-doris] imay commented on a change in pull request #1629: Enable parsing columns from file path for Broker Load (#1582)

imay commented on a change in pull request #1629: Enable parsing columns from file path for Broker Load (#1582) URL: https://github.com/apache/incubator-doris/pull/1629#discussion_r313206234 ## File path: docs/documentation/cn/sql-reference/sql-statements/Data Manipulation/LOAD.md

[GitHub] [incubator-doris] imay commented on a change in pull request #1629: Enable parsing columns from file path for Broker Load (#1582)

imay commented on a change in pull request #1629: Enable parsing columns from file path for Broker Load (#1582) URL: https://github.com/apache/incubator-doris/pull/1629#discussion_r313206785 ## File path: be/src/exec/broker_scanner.cpp ## @@ -452,6 +456,17 @@ bool BrokerSc

[GitHub] [incubator-doris] imay commented on a change in pull request #1629: Enable parsing columns from file path for Broker Load (#1582)

imay commented on a change in pull request #1629: Enable parsing columns from file path for Broker Load (#1582) URL: https://github.com/apache/incubator-doris/pull/1629#discussion_r313234538 ## File path: fe/src/main/java/org/apache/doris/planner/BrokerScanNode.java ## @@

[GitHub] [incubator-doris] imay commented on a change in pull request #1629: Enable parsing columns from file path for Broker Load (#1582)

imay commented on a change in pull request #1629: Enable parsing columns from file path for Broker Load (#1582) URL: https://github.com/apache/incubator-doris/pull/1629#discussion_r313233198 ## File path: be/src/exec/parquet_reader.cpp ## @@ -204,13 +208,23 @@ Status Parqu

[GitHub] [incubator-doris] imay commented on a change in pull request #1629: Enable parsing columns from file path for Broker Load (#1582)

imay commented on a change in pull request #1629: Enable parsing columns from file path for Broker Load (#1582) URL: https://github.com/apache/incubator-doris/pull/1629#discussion_r313206399 ## File path: fe/src/main/cup/sql_parser.cup ## @@ -1050,10 +1050,11 @@ data_desc

[GitHub] [incubator-doris] imay commented on a change in pull request #1629: Enable parsing columns from file path for Broker Load (#1582)

imay commented on a change in pull request #1629: Enable parsing columns from file path for Broker Load (#1582) URL: https://github.com/apache/incubator-doris/pull/1629#discussion_r313232621 ## File path: be/src/exec/broker_scanner.cpp ## @@ -489,18 +504,18 @@ bool BrokerS

[GitHub] [incubator-doris] kangpinghuang opened a new pull request #1633: add zone map page(#1390)

kangpinghuang opened a new pull request #1633: add zone map page(#1390) URL: https://github.com/apache/incubator-doris/pull/1633 Columns' zone map include min/max value for column page. When scan data, we can use this information to eliminate data loading.

[GitHub] [incubator-doris] yuanlihan opened a new pull request #1629: Enable parsing columns from file path for Broker Load (#1582)

yuanlihan opened a new pull request #1629: Enable parsing columns from file path for Broker Load (#1582) URL: https://github.com/apache/incubator-doris/pull/1629 Currently, we do not support parsing encoded/compressed columns in file path, eg: extract column k1 from file path `/path/to/dir

[GitHub] [incubator-doris] yuanlihan closed pull request #1629: Enable parsing columns from file path for Broker Load (#1582)

yuanlihan closed pull request #1629: Enable parsing columns from file path for Broker Load (#1582) URL: https://github.com/apache/incubator-doris/pull/1629 This is an automated message from the Apache Git Service. To respond

[GitHub] [incubator-doris] imay opened a new pull request #1632: Fix HLLContext cast error

imay opened a new pull request #1632: Fix HLLContext cast error URL: https://github.com/apache/incubator-doris/pull/1632 This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

[GitHub] [incubator-doris] imay commented on a change in pull request #1631: Fix time zone compatibility

imay commented on a change in pull request #1631: Fix time zone compatibility URL: https://github.com/apache/incubator-doris/pull/1631#discussion_r313219924 ## File path: be/src/runtime/runtime_state.cpp ## @@ -169,11 +177,19 @@ Status RuntimeState::init( const TQueryG

[GitHub] [incubator-doris] imay commented on a change in pull request #1631: Fix time zone compatibility

imay commented on a change in pull request #1631: Fix time zone compatibility URL: https://github.com/apache/incubator-doris/pull/1631#discussion_r313217331 ## File path: gensrc/thrift/PaloInternalService.thrift ## @@ -182,7 +182,8 @@ struct TPlanFragmentExecParams { struc

[GitHub] [incubator-doris] HangyuanLiu opened a new pull request #1631: Fix time zone compatibility

HangyuanLiu opened a new pull request #1631: Fix time zone compatibility URL: https://github.com/apache/incubator-doris/pull/1631 Fix time zone compatibility with old fe This is an automated message from the Apache Git Service

[GitHub] [incubator-doris] imay merged pull request #1625: Change the prefix of table info apis

imay merged pull request #1625: Change the prefix of table info apis URL: https://github.com/apache/incubator-doris/pull/1625 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [incubator-doris] chaoyli commented on a change in pull request #1576: Change cumulative compaction for decoupling storage from compution

chaoyli commented on a change in pull request #1576: Change cumulative compaction for decoupling storage from compution URL: https://github.com/apache/incubator-doris/pull/1576#discussion_r313200154 ## File path: be/src/olap/base_compaction.cpp ## @@ -16,513 +16,115 @@ //

[GitHub] [incubator-doris] chaoyli commented on a change in pull request #1576: Change cumulative compaction for decoupling storage from compution

chaoyli commented on a change in pull request #1576: Change cumulative compaction for decoupling storage from compution URL: https://github.com/apache/incubator-doris/pull/1576#discussion_r313200154 ## File path: be/src/olap/base_compaction.cpp ## @@ -16,513 +16,115 @@ //

[GitHub] [incubator-doris] worker24h commented on a change in pull request #1617: Add PreAgg Hint

worker24h commented on a change in pull request #1617: Add PreAgg Hint URL: https://github.com/apache/incubator-doris/pull/1617#discussion_r313199194 ## File path: fe/src/main/java/org/apache/doris/planner/SingleNodePlanner.java ## @@ -593,8 +595,20 @@ private void turnOffP

[GitHub] [incubator-doris] worker24h commented on a change in pull request #1617: Add PreAgg Hint

worker24h commented on a change in pull request #1617: Add PreAgg Hint URL: https://github.com/apache/incubator-doris/pull/1617#discussion_r313198872 ## File path: fe/src/main/java/org/apache/doris/planner/SingleNodePlanner.java ## @@ -327,6 +325,10 @@ private void turnOffP

[GitHub] [incubator-doris] worker24h commented on a change in pull request #1617: Add PreAgg Hint

worker24h commented on a change in pull request #1617: Add PreAgg Hint URL: https://github.com/apache/incubator-doris/pull/1617#discussion_r313198465 ## File path: fe/src/main/cup/sql_parser.cup ## @@ -338,6 +338,7 @@ nonterminal ArrayList opt_plan_hints; nonterminal Array

[GitHub] [incubator-doris] imay merged pull request #1630: Fix compile error

imay merged pull request #1630: Fix compile error URL: https://github.com/apache/incubator-doris/pull/1630 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use t

[GitHub] [incubator-doris] imay merged pull request #1628: Insert select Stmt keep the same semantics with mysql (#1626)

imay merged pull request #1628: Insert select Stmt keep the same semantics with mysql (#1626) URL: https://github.com/apache/incubator-doris/pull/1628 This is an automated message from the Apache Git Service. To respond to t

[GitHub] [incubator-doris] imay opened a new pull request #1630: Fix compile error

imay opened a new pull request #1630: Fix compile error URL: https://github.com/apache/incubator-doris/pull/1630 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [incubator-doris] imay merged pull request #1624: Fix tablet restore api in BE(#1623)

imay merged pull request #1624: Fix tablet restore api in BE(#1623) URL: https://github.com/apache/incubator-doris/pull/1624 This is an automated message from the Apache Git Service. To respond to the message, please log on t

[GitHub] [incubator-doris] yuanlihan opened a new pull request #1629: Enable parsing columns from file path for Broker Load (#1582)

yuanlihan opened a new pull request #1629: Enable parsing columns from file path for Broker Load (#1582) URL: https://github.com/apache/incubator-doris/pull/1629 Currently, we do not support parsing encoded/compressed columns in file path, eg: extract column k1 from file path `/path/to/dir

[GitHub] [incubator-doris] wangbo commented on a change in pull request #1628: Insert select Stmt keep the same semantics with mysql (#1626)

wangbo commented on a change in pull request #1628: Insert select Stmt keep the same semantics with mysql (#1626) URL: https://github.com/apache/incubator-doris/pull/1628#discussion_r312930799 ## File path: fe/src/main/java/org/apache/doris/qe/StmtExecutor.java ## @@ -639,

[GitHub] [incubator-doris] morningman merged pull request #1598: Time zone related be function

morningman merged pull request #1598: Time zone related be function URL: https://github.com/apache/incubator-doris/pull/1598 This is an automated message from the Apache Git Service. To respond to the message, please log on t

[GitHub] [incubator-doris] imay merged pull request #1622: Add block compression codec and remove not used codec

imay merged pull request #1622: Add block compression codec and remove not used codec URL: https://github.com/apache/incubator-doris/pull/1622 This is an automated message from the Apache Git Service. To respond to the messa

[GitHub] [incubator-doris] gaodayue commented on a change in pull request #1590: Implement BetaRowsetWriter

gaodayue commented on a change in pull request #1590: Implement BetaRowsetWriter URL: https://github.com/apache/incubator-doris/pull/1590#discussion_r312904888 ## File path: be/src/olap/rowset/beta_rowset_writer.cpp ## @@ -0,0 +1,184 @@ +// Licensed to the Apache Software F

[GitHub] [incubator-doris] gaodayue commented on a change in pull request #1590: Implement BetaRowsetWriter

gaodayue commented on a change in pull request #1590: Implement BetaRowsetWriter URL: https://github.com/apache/incubator-doris/pull/1590#discussion_r312903421 ## File path: be/src/olap/rowset/beta_rowset_writer.cpp ## @@ -0,0 +1,184 @@ +// Licensed to the Apache Software F

[GitHub] [incubator-doris] gaodayue commented on a change in pull request #1590: Implement BetaRowsetWriter

gaodayue commented on a change in pull request #1590: Implement BetaRowsetWriter URL: https://github.com/apache/incubator-doris/pull/1590#discussion_r312900035 ## File path: be/src/olap/rowset/alpha_rowset_writer.h ## @@ -56,19 +56,13 @@ class AlphaRowsetWriter : public Row

[GitHub] [incubator-doris] gaodayue commented on a change in pull request #1590: Implement BetaRowsetWriter

gaodayue commented on a change in pull request #1590: Implement BetaRowsetWriter URL: https://github.com/apache/incubator-doris/pull/1590#discussion_r312900074 ## File path: be/src/olap/rowset/beta_rowset_writer.h ## @@ -0,0 +1,89 @@ +// Licensed to the Apache Software Foun

[GitHub] [incubator-doris] kangpinghuang commented on a change in pull request #1624: Fix tablet restore api in BE(#1623)

kangpinghuang commented on a change in pull request #1624: Fix tablet restore api in BE(#1623) URL: https://github.com/apache/incubator-doris/pull/1624#discussion_r312893636 ## File path: bin/restore_tablet_tool.sh ## @@ -0,0 +1,84 @@ +#!/usr/bin/env bash +# Licensed to th

[GitHub] [incubator-doris] kangpinghuang commented on a change in pull request #1624: Fix tablet restore api in BE(#1623)

kangpinghuang commented on a change in pull request #1624: Fix tablet restore api in BE(#1623) URL: https://github.com/apache/incubator-doris/pull/1624#discussion_r312893694 ## File path: bin/restore_tablet_tool.sh ## @@ -0,0 +1,84 @@ +#!/usr/bin/env bash +# Licensed to th

[GitHub] [incubator-doris] kangpinghuang commented on a change in pull request #1624: Fix tablet restore api in BE(#1623)

kangpinghuang commented on a change in pull request #1624: Fix tablet restore api in BE(#1623) URL: https://github.com/apache/incubator-doris/pull/1624#discussion_r312893460 ## File path: be/src/http/action/restore_tablet_action.cpp ## @@ -185,31 +176,48 @@ Status RestoreT

[GitHub] [incubator-doris] kangpinghuang commented on a change in pull request #1624: Fix tablet restore api in BE(#1623)

kangpinghuang commented on a change in pull request #1624: Fix tablet restore api in BE(#1623) URL: https://github.com/apache/incubator-doris/pull/1624#discussion_r312893296 ## File path: be/src/http/action/restore_tablet_action.cpp ## @@ -121,36 +121,27 @@ Status RestoreT

[GitHub] [incubator-doris] kangpinghuang commented on a change in pull request #1624: Fix tablet restore api in BE(#1623)

kangpinghuang commented on a change in pull request #1624: Fix tablet restore api in BE(#1623) URL: https://github.com/apache/incubator-doris/pull/1624#discussion_r312893409 ## File path: be/src/http/action/restore_tablet_action.cpp ## @@ -185,31 +176,48 @@ Status RestoreT

[GitHub] [incubator-doris] kangpinghuang commented on a change in pull request #1624: Fix tablet restore api in BE(#1623)

kangpinghuang commented on a change in pull request #1624: Fix tablet restore api in BE(#1623) URL: https://github.com/apache/incubator-doris/pull/1624#discussion_r312893344 ## File path: be/src/http/action/restore_tablet_action.cpp ## @@ -86,11 +86,11 @@ Status RestoreTab

[GitHub] [incubator-doris] jiangshouzhuang commented on a change in pull request #1627: fix backends disk error statistics issue

jiangshouzhuang commented on a change in pull request #1627: fix backends disk error statistics issue URL: https://github.com/apache/incubator-doris/pull/1627#discussion_r312887796 ## File path: gensrc/thrift/MasterService.thrift ## @@ -64,12 +64,13 @@ struct TTablet {

[GitHub] [incubator-doris] imay commented on a change in pull request #1625: Change the prefix of table info apis

imay commented on a change in pull request #1625: Change the prefix of table info apis URL: https://github.com/apache/incubator-doris/pull/1625#discussion_r312884183 ## File path: fe/src/main/java/org/apache/doris/http/rest/TableQueryPlanAction.java ## @@ -77,25 +81,26 @@

[GitHub] [incubator-doris] imay commented on a change in pull request #1625: Change the prefix of table info apis

imay commented on a change in pull request #1625: Change the prefix of table info apis URL: https://github.com/apache/incubator-doris/pull/1625#discussion_r312884461 ## File path: fe/src/main/java/org/apache/doris/http/rest/TableQueryPlanAction.java ## @@ -77,25 +81,26 @@

[GitHub] [incubator-doris] imay commented on a change in pull request #1627: fix backends disk error statistics issue

imay commented on a change in pull request #1627: fix backends disk error statistics issue URL: https://github.com/apache/incubator-doris/pull/1627#discussion_r312880575 ## File path: gensrc/thrift/MasterService.thrift ## @@ -64,12 +64,13 @@ struct TTablet { struct TDis

[GitHub] [incubator-doris] jiangshouzhuang commented on a change in pull request #1627: fix backends disk error statistics issue

jiangshouzhuang commented on a change in pull request #1627: fix backends disk error statistics issue URL: https://github.com/apache/incubator-doris/pull/1627#discussion_r312880003 ## File path: gensrc/thrift/MasterService.thrift ## @@ -64,12 +64,13 @@ struct TTablet {

[GitHub] [incubator-doris] wangbo commented on a change in pull request #1628: Insert select Stmt keep the same semantics with mysql (#1626)

wangbo commented on a change in pull request #1628: Insert select Stmt keep the same semantics with mysql (#1626) URL: https://github.com/apache/incubator-doris/pull/1628#discussion_r312877005 ## File path: fe/src/main/java/org/apache/doris/qe/StmtExecutor.java ## @@ -639,

[GitHub] [incubator-doris] imay commented on a change in pull request #1627: fix backends disk error statistics issue

imay commented on a change in pull request #1627: fix backends disk error statistics issue URL: https://github.com/apache/incubator-doris/pull/1627#discussion_r312872005 ## File path: gensrc/thrift/MasterService.thrift ## @@ -64,12 +64,13 @@ struct TTablet { struct TDis

[GitHub] [incubator-doris] imay commented on a change in pull request #1628: Insert select Stmt keep the same semantics with mysql (#1626)

imay commented on a change in pull request #1628: Insert select Stmt keep the same semantics with mysql (#1626) URL: https://github.com/apache/incubator-doris/pull/1628#discussion_r312867170 ## File path: fe/src/main/java/org/apache/doris/qe/StmtExecutor.java ## @@ -639,6

[GitHub] [incubator-doris] wangbo opened a new pull request #1628: Insert select Stmt keep the same semantics with mysql (#1626)

wangbo opened a new pull request #1628: Insert select Stmt keep the same semantics with mysql (#1626) URL: https://github.com/apache/incubator-doris/pull/1628 This is an automated message from the Apache Git Service. To resp

[GitHub] [incubator-doris] jiangshouzhuang opened a new pull request #1627: fix backends disk error statistics issue

jiangshouzhuang opened a new pull request #1627: fix backends disk error statistics issue URL: https://github.com/apache/incubator-doris/pull/1627 #1608 The main problem solved is an error in disk statistics when Doris's storage_root_path is set to a storage limit, rather than using

[GitHub] [incubator-doris] wangbo opened a new issue #1626: Insert select Stmt keep the same semantics with mysql

wangbo opened a new issue #1626: Insert select Stmt keep the same semantics with mysql URL: https://github.com/apache/incubator-doris/issues/1626 **Question** When doing Insert Select stmt in doris,if the select stmt returns epmty set, it will returns a error which content is "all part

[GitHub] [incubator-doris] EmmyMiao87 opened a new pull request #1625: Change the prefix of table info apis

EmmyMiao87 opened a new pull request #1625: Change the prefix of table info apis URL: https://github.com/apache/incubator-doris/pull/1625 The pathtrie could not distinguish the different param key with the same prefix path. So the prefix of table info apis has been change to /api/externa

[GitHub] [incubator-doris] kangpinghuang commented on a change in pull request #1590: Implement BetaRowsetWriter

kangpinghuang commented on a change in pull request #1590: Implement BetaRowsetWriter URL: https://github.com/apache/incubator-doris/pull/1590#discussion_r312817232 ## File path: be/src/olap/rowset/beta_rowset_writer.h ## @@ -0,0 +1,89 @@ +// Licensed to the Apache Softwar

[GitHub] [incubator-doris] kangpinghuang commented on a change in pull request #1590: Implement BetaRowsetWriter

kangpinghuang commented on a change in pull request #1590: Implement BetaRowsetWriter URL: https://github.com/apache/incubator-doris/pull/1590#discussion_r312819519 ## File path: be/src/olap/rowset/beta_rowset_writer.cpp ## @@ -0,0 +1,184 @@ +// Licensed to the Apache Soft

[GitHub] [incubator-doris] kangpinghuang commented on a change in pull request #1590: Implement BetaRowsetWriter

kangpinghuang commented on a change in pull request #1590: Implement BetaRowsetWriter URL: https://github.com/apache/incubator-doris/pull/1590#discussion_r312820137 ## File path: be/src/olap/rowset/beta_rowset_writer.cpp ## @@ -0,0 +1,184 @@ +// Licensed to the Apache Soft

[GitHub] [incubator-doris] kangpinghuang commented on a change in pull request #1590: Implement BetaRowsetWriter

kangpinghuang commented on a change in pull request #1590: Implement BetaRowsetWriter URL: https://github.com/apache/incubator-doris/pull/1590#discussion_r312807503 ## File path: be/src/olap/rowset/alpha_rowset_writer.h ## @@ -56,19 +56,13 @@ class AlphaRowsetWriter : publ

[GitHub] [incubator-doris] HangyuanLiu commented on a change in pull request #1598: Time zone related be function

HangyuanLiu commented on a change in pull request #1598: Time zone related be function URL: https://github.com/apache/incubator-doris/pull/1598#discussion_r312823840 ## File path: be/src/runtime/datetime_value.h ## @@ -331,10 +332,14 @@ class DateTimeValue { // Add

[GitHub] [incubator-doris] imay merged pull request #1590: Implement BetaRowsetWriter

imay merged pull request #1590: Implement BetaRowsetWriter URL: https://github.com/apache/incubator-doris/pull/1590 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [incubator-doris] imay commented on a change in pull request #1598: Time zone related be function

imay commented on a change in pull request #1598: Time zone related be function URL: https://github.com/apache/incubator-doris/pull/1598#discussion_r312820490 ## File path: be/src/runtime/datetime_value.h ## @@ -331,10 +332,14 @@ class DateTimeValue { // Add interval

[GitHub] [incubator-doris] morningman merged pull request #1618: Avoid load or query failed when doing alter job

morningman merged pull request #1618: Avoid load or query failed when doing alter job URL: https://github.com/apache/incubator-doris/pull/1618 This is an automated message from the Apache Git Service. To respond to the messa

[GitHub] [incubator-doris] imay commented on a change in pull request #1624: Fix tablet restore api in BE(#1623)

imay commented on a change in pull request #1624: Fix tablet restore api in BE(#1623) URL: https://github.com/apache/incubator-doris/pull/1624#discussion_r312802360 ## File path: bin/restore_tablet_tool.sh ## @@ -0,0 +1,84 @@ +#!/usr/bin/env bash +# Licensed to the Apache

[GitHub] [incubator-doris] imay commented on a change in pull request #1624: Fix tablet restore api in BE(#1623)

imay commented on a change in pull request #1624: Fix tablet restore api in BE(#1623) URL: https://github.com/apache/incubator-doris/pull/1624#discussion_r312802272 ## File path: bin/restore_tablet_tool.sh ## @@ -0,0 +1,84 @@ +#!/usr/bin/env bash +# Licensed to the Apache

[GitHub] [incubator-doris] imay commented on a change in pull request #1624: Fix tablet restore api in BE(#1623)

imay commented on a change in pull request #1624: Fix tablet restore api in BE(#1623) URL: https://github.com/apache/incubator-doris/pull/1624#discussion_r312801515 ## File path: be/src/http/action/restore_tablet_action.cpp ## @@ -185,31 +176,48 @@ Status RestoreTabletActi

[GitHub] [incubator-doris] imay commented on a change in pull request #1624: Fix tablet restore api in BE(#1623)

imay commented on a change in pull request #1624: Fix tablet restore api in BE(#1623) URL: https://github.com/apache/incubator-doris/pull/1624#discussion_r312801552 ## File path: be/src/http/action/restore_tablet_action.cpp ## @@ -185,31 +176,48 @@ Status RestoreTabletActi

[GitHub] [incubator-doris] imay commented on a change in pull request #1624: Fix tablet restore api in BE(#1623)

imay commented on a change in pull request #1624: Fix tablet restore api in BE(#1623) URL: https://github.com/apache/incubator-doris/pull/1624#discussion_r312801227 ## File path: be/src/http/action/restore_tablet_action.cpp ## @@ -121,36 +121,27 @@ Status RestoreTabletActi

[GitHub] [incubator-doris] imay commented on a change in pull request #1624: Fix tablet restore api in BE(#1623)

imay commented on a change in pull request #1624: Fix tablet restore api in BE(#1623) URL: https://github.com/apache/incubator-doris/pull/1624#discussion_r312800888 ## File path: be/src/http/action/restore_tablet_action.cpp ## @@ -86,11 +86,11 @@ Status RestoreTabletAction

[GitHub] [incubator-doris] kangpinghuang opened a new pull request #1624: Fix tablet restore api in BE(#1623)

kangpinghuang opened a new pull request #1624: Fix tablet restore api in BE(#1623) URL: https://github.com/apache/incubator-doris/pull/1624 1. fix bug when tablet with pending dir 2. add a shell script to support batch restore

[GitHub] [incubator-doris] kangpinghuang commented on issue #1623: there is bug for api to restore be tablet when there is pending_dir

kangpinghuang commented on issue #1623: there is bug for api to restore be tablet when there is pending_dir URL: https://github.com/apache/incubator-doris/issues/1623#issuecomment-520320061 And more this api can only process one tablet at one time. In many cases, there will be many tablet

[GitHub] [incubator-doris] kangpinghuang opened a new issue #1623: there is bug for api to restore be tablet when there is pending_dir

kangpinghuang opened a new issue #1623: there is bug for api to restore be tablet when there is pending_dir URL: https://github.com/apache/incubator-doris/issues/1623 restore tablet api is for restore tablet from trash dir when mistakes. But now there is a bug when the tablet has pending

[GitHub] [incubator-doris] imay commented on a change in pull request #1622: Add block compression codec and remove not used codec

imay commented on a change in pull request #1622: Add block compression codec and remove not used codec URL: https://github.com/apache/incubator-doris/pull/1622#discussion_r312798278 ## File path: gensrc/proto/segment_v2.proto ## @@ -61,8 +61,9 @@ enum CompressionTypePB {

[GitHub] [incubator-doris] imay commented on a change in pull request #1598: Time zone related be function

imay commented on a change in pull request #1598: Time zone related be function URL: https://github.com/apache/incubator-doris/pull/1598#discussion_r312796878 ## File path: be/src/runtime/datetime_value.h ## @@ -332,9 +333,9 @@ class DateTimeValue { // Add interval

[GitHub] [incubator-doris] imay commented on a change in pull request #1598: Time zone related be function

imay commented on a change in pull request #1598: Time zone related be function URL: https://github.com/apache/incubator-doris/pull/1598#discussion_r312797618 ## File path: be/src/exprs/timestamp_functions.cpp ## @@ -485,142 +385,112 @@ IntVal TimestampFunctions::date_diff(

[GitHub] [incubator-doris] imay commented on a change in pull request #1598: Time zone related be function

imay commented on a change in pull request #1598: Time zone related be function URL: https://github.com/apache/incubator-doris/pull/1598#discussion_r312797672 ## File path: be/src/exprs/timestamp_functions.cpp ## @@ -485,142 +385,112 @@ IntVal TimestampFunctions::date_diff(

[GitHub] [incubator-doris] imay commented on a change in pull request #1598: Time zone related be function

imay commented on a change in pull request #1598: Time zone related be function URL: https://github.com/apache/incubator-doris/pull/1598#discussion_r312797978 ## File path: be/src/runtime/datetime_value.cpp ## @@ -1524,43 +1524,42 @@ bool DateTimeValue::date_add_interval(co

[GitHub] [incubator-doris] gaodayue commented on a change in pull request #1622: Add block compression codec and remove not used codec

gaodayue commented on a change in pull request #1622: Add block compression codec and remove not used codec URL: https://github.com/apache/incubator-doris/pull/1622#discussion_r312795986 ## File path: gensrc/proto/segment_v2.proto ## @@ -61,8 +61,9 @@ enum CompressionTypeP