imay commented on a change in pull request #1631: Fix time zone compatibility
URL: https://github.com/apache/incubator-doris/pull/1631#discussion_r313217331
##########
File path: gensrc/thrift/PaloInternalService.thrift
##########
@@ -182,7 +182,8 @@ struct TPlanFragmentExecParams {
struct TQueryGlobals {
// String containing a timestamp set as the current time.
1: required string now_string
- 2: optional string time_zone
+ 2: optional i64 timestamp
Review comment:
Add some comments to describe timestamp and now_string's relation
```suggestion
2: optional i64 timestamp_ms
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@doris.apache.org
For additional commands, e-mail: dev-h...@doris.apache.org
