kangpinghuang commented on a change in pull request #1590: Implement
BetaRowsetWriter
URL: https://github.com/apache/incubator-doris/pull/1590#discussion_r312807503
##########
File path: be/src/olap/rowset/alpha_rowset_writer.h
##########
@@ -56,19 +56,13 @@ class AlphaRowsetWriter : public RowsetWriter {
// get a rowset
RowsetSharedPtr build() override;
- MemPool* mem_pool() override;
+ Version version() override { return _rowset_writer_context.version; }
Review comment:
add const description?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
