imay commented on a change in pull request #1631: Fix time zone compatibility
URL: https://github.com/apache/incubator-doris/pull/1631#discussion_r313219924
##########
File path: be/src/runtime/runtime_state.cpp
##########
@@ -169,11 +177,19 @@ Status RuntimeState::init(
const TQueryGlobals& query_globals, ExecEnv* exec_env) {
_fragment_instance_id = fragment_instance_id;
_query_options = query_options;
- _timestamp = atol(query_globals.now_string.c_str());
if (query_globals.__isset.time_zone) {
_timezone = query_globals.time_zone;
+ _timestamp_ms = query_globals.timestamp;
+ } else if (query_globals.now_string != "") {
Review comment:
can this string be empty? I think it is no need to test it
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@doris.apache.org
For additional commands, e-mail: dev-h...@doris.apache.org
