Bug#696659: Security uploads not working

2012-12-27 Thread Paul Tagliamonte
Outstanding!! Sorry about that break, and do let us know if there are any other issues with your setup Cheers Paul On Dec 27, 2012 8:21 AM, "Moritz Mühlenhoff" wrote: > On Wed, Dec 26, 2012 at 10:37:44AM -0500, Paul Tagliamonte wrote: > > On Wed, Dec 26, 2012 at 10:36 AM, Moritz Mühlenhoff >

Bug#696659: Security uploads not working

2012-12-27 Thread Moritz Mühlenhoff
On Wed, Dec 26, 2012 at 10:37:44AM -0500, Paul Tagliamonte wrote: > On Wed, Dec 26, 2012 at 10:36 AM, Moritz Mühlenhoff wrote: > > > On Wed, Dec 26, 2012 at 10:35:46AM -0500, Paul Tagliamonte wrote: > > > Seems OK here. Can you make sure something's not gone wrong with your > > install? > > > How

Bug#696659: Security uploads not working

2012-12-26 Thread Paul Tagliamonte
On Wed, Dec 26, 2012 at 10:36 AM, Moritz Mühlenhoff wrote: > On Wed, Dec 26, 2012 at 10:35:46AM -0500, Paul Tagliamonte wrote: > > Seems OK here. Can you make sure something's not gone wrong with your > install? > > How did you install it? Did you upgrade python-dput too? That's where > the fix >

Bug#696659: Security uploads not working

2012-12-26 Thread Moritz Mühlenhoff
On Wed, Dec 26, 2012 at 10:35:46AM -0500, Paul Tagliamonte wrote: > Seems OK here. Can you make sure something's not gone wrong with your install? > How did you install it? Did you upgrade python-dput too? That's where the fix > is :) Bummer, I only fetched dput-ng from incoming.debian.org... Wil

Bug#696659: Security uploads not working

2012-12-26 Thread Paul Tagliamonte
On Wed, Dec 26, 2012 at 04:05:19PM +0100, Moritz Mühlenhoff wrote: > On Wed, Dec 26, 2012 at 03:27:26PM +0100, Moritz Mühlenhoff wrote: > > On Wed, Dec 26, 2012 at 01:24:42PM +0100, Arno Töll wrote: > > > Hi, > > > > > > On 26.12.2012 03:48, Paul Tagliamonte wrote: > > > > Arno, can you ACK this c

Bug#696659: Security uploads not working

2012-12-26 Thread Moritz Mühlenhoff
On Wed, Dec 26, 2012 at 03:27:26PM +0100, Moritz Mühlenhoff wrote: > On Wed, Dec 26, 2012 at 01:24:42PM +0100, Arno Töll wrote: > > Hi, > > > > On 26.12.2012 03:48, Paul Tagliamonte wrote: > > > Arno, can you ACK this change? > > > > The patch itself is fine, but I believe a warning instead of an

Bug#696659: Security uploads not working

2012-12-26 Thread Moritz Mühlenhoff
On Wed, Dec 26, 2012 at 01:24:42PM +0100, Arno Töll wrote: > Hi, > > On 26.12.2012 03:48, Paul Tagliamonte wrote: > > Arno, can you ACK this change? > > The patch itself is fine, but I believe a warning instead of an error > would be more appropriate. You do logger.error, but you don't fail out >

Bug#696659: Security uploads not working

2012-12-26 Thread Paul Tagliamonte
On Wed, Dec 26, 2012 at 01:24:42PM +0100, Arno Töll wrote: > Hi, > > On 26.12.2012 03:48, Paul Tagliamonte wrote: > > Arno, can you ACK this change? > > The patch itself is fine, but I believe a warning instead of an error > would be more appropriate. You do logger.error, but you don't fail out >

Bug#696659: Security uploads not working

2012-12-26 Thread Arno Töll
Hi, On 26.12.2012 03:48, Paul Tagliamonte wrote: > Arno, can you ACK this change? The patch itself is fine, but I believe a warning instead of an error would be more appropriate. You do logger.error, but you don't fail out which makes your error essentially a warning. Maybe it should be tagged as

Bug#696659: Security uploads not working

2012-12-25 Thread Paul Tagliamonte
tags 696659 + pending thanks Hey Moritz, I've pushed a fix in git. If you wouldn't mind reviewing the diff[1] and ensuring that it satisfies your concerns, that would be great. High level logic is, given a exec problem (dput.utils:95), and the file we're s'posed to run isn't on the filesystem, d

Bug#696659: Security uploads not working

2012-12-25 Thread Moritz Mühlenhoff
> > > Please keep in mind all old dput configs will override new dput configs > > > -- we defer to the old configs in all cases :) > > > > > > If it's still saying to run that hook, dput-ng will try to run the hook. > > > > > > Perhaps remove that target? > > > > I will remove /etc/dput.cf, then

Bug#696659: Security uploads not working

2012-12-25 Thread Paul Tagliamonte
retitle 696659 Don't abort upload on missing pre_upload_command or post_upload_command thanks On Tue, Dec 25, 2012 at 05:55:32PM +0100, Moritz Mühlenhoff wrote: > On Tue, Dec 25, 2012 at 08:47:20AM -0500, Paul Tagliamonte wrote: > > This all looks great > > > > > > > > Could not execute /usr/s

Bug#696659: Security uploads not working

2012-12-25 Thread Moritz Mühlenhoff
On Tue, Dec 25, 2012 at 08:47:20AM -0500, Paul Tagliamonte wrote: > This all looks great > > > > > Could not execute /usr/share/dput/helper/security-warning: [Errno 2] No > > such file or directory > > We don't own /usr/share/dput -- this looks like it's coming from > dput-old's /etc/dput.cf --

Bug#696659: Security uploads not working

2012-12-25 Thread Paul Tagliamonte
tags 696659 + moreinfo thanks On Tue, Dec 25, 2012 at 12:13:09PM +0100, Moritz Muehlenhoff wrote: > Package: dput-ng > Version: 1.2 > Severity: normal > > Hi, > I tried to upload a security upload to security-master, but > /usr/share/dput/helper/security-warning is missing: > > running allowed

Bug#696659: Security uploads not working

2012-12-25 Thread Moritz Muehlenhoff
Package: dput-ng Version: 1.2 Severity: normal Hi, I tried to upload a security upload to security-master, but /usr/share/dput/helper/security-warning is missing: running allowed-distribution: check whether a local profile permits uploads to the target distribution running protected-distributio