Hi,

On 26.12.2012 03:48, Paul Tagliamonte wrote:
> Arno, can you ACK this change?

The patch itself is fine, but I believe a warning instead of an error
would be more appropriate. You do logger.error, but you don't fail out
which makes your error essentially a warning. Maybe it should be tagged
as such.


By the way Moritz: You as a security team member probably want to
disable the "protected distribution" hook, prompting you for
confirmation before every upload.

-- 
with kind regards,
Arno Töll
IRC: daemonkeeper on Freenode/OFTC
GnuPG Key-ID: 0x9D80F36D

Attachment: signature.asc
Description: OpenPGP digital signature

Reply via email to