On Wed, Dec 26, 2012 at 01:24:42PM +0100, Arno Töll wrote:
> Hi,
> 
> On 26.12.2012 03:48, Paul Tagliamonte wrote:
> > Arno, can you ACK this change?
> 
> The patch itself is fine, but I believe a warning instead of an error
> would be more appropriate. You do logger.error, but you don't fail out
> which makes your error essentially a warning. Maybe it should be tagged
> as such.

Done :)

> 
> 
> By the way Moritz: You as a security team member probably want to
> disable the "protected distribution" hook, prompting you for
> confirmation before every upload.
> 
> -- 
> with kind regards,
> Arno Töll
> IRC: daemonkeeper on Freenode/OFTC
> GnuPG Key-ID: 0x9D80F36D
> 

OK, this'll get folded into the next release.

-- 
 .''`.  Paul Tagliamonte <paul...@debian.org>
: :'  : Proud Debian Developer
`. `'`  4096R / 8F04 9AD8 2C92 066C 7352  D28A 7B58 5B30 807C 2A87
 `-     http://people.debian.org/~paultag

Attachment: signature.asc
Description: Digital signature

Reply via email to