Bug#604823: httping: Don't read one byte at a time

2010-11-24 Thread Olaf van der Spek
On Wed, Nov 24, 2010 at 9:39 PM, folkert wrote: >> >> > Reading one byte at a time doesn't seem like the best way. Could you >> >> > use a buffer of 16 k? >> >> >> >> I agree this is not optimal (even though works and is no bug), looking at >> >> the >> >> use of the myread function in the sourc

Bug#604823: httping: Don't read one byte at a time

2010-11-24 Thread folkert
> >> > Reading one byte at a time doesn't seem like the best way. Could you use > >> > a buffer of 16 k? > >> > >> I agree this is not optimal (even though works and is no bug), looking at > >> the > >> use of the myread function in the source code its unclear to me why it is > >> implemented lik

Bug#604823: httping: Don't read one byte at a time

2010-11-24 Thread Olaf van der Spek
On Wed, Nov 24, 2010 at 6:04 PM, folkert wrote: >> > Reading one byte at a time doesn't seem like the best way. Could you use a >> > buffer of 16 k? >> >> I agree this is not optimal (even though works and is no bug), looking at the >> use of the myread function in the source code its unclear to

Bug#604823: httping: Don't read one byte at a time

2010-11-24 Thread folkert
> > I agree this is not optimal (even though works and is no bug), looking at > > the > > use of the myread function in the source code its unclear to me why it is > > implemented like that. Folkert, is there any reason it should be like that? > > I was wondering why a localhost request was takin

Bug#604823: httping: Don't read one byte at a time

2010-11-24 Thread Olaf van der Spek
On Wed, Nov 24, 2010 at 5:07 PM, Nico Golde wrote: > I agree this is not optimal (even though works and is no bug), looking at the > use of the myread function in the source code its unclear to me why it is > implemented like that. Folkert, is there any reason it should be like that? I was wonder

Bug#604823: httping: Don't read one byte at a time

2010-11-24 Thread folkert
> > Reading one byte at a time doesn't seem like the best way. Could you use a > > buffer of 16 k? > > I agree this is not optimal (even though works and is no bug), looking at the > use of the myread function in the source code its unclear to me why it is > implemented like that. Folkert, is t

Bug#604823: httping: Don't read one byte at a time

2010-11-24 Thread Nico Golde
severity 604823 wishlist thanks Hi, * Olaf van der Spek [2010-11-24 16:51]: > Package: httping > Version: 1.4.4-1 > Severity: normal adjusted severity, there is no bug here > Reading one byte at a time doesn't seem like the best way. Could you use a > buffer of 16 k? > > Greetings, > > Olaf

Bug#604823: httping: Don't read one byte at a time

2010-11-24 Thread Olaf van der Spek
Package: httping Version: 1.4.4-1 Severity: normal Hi, Reading one byte at a time doesn't seem like the best way. Could you use a buffer of 16 k? Greetings, Olaf select(4, NULL, [3], NULL, {30, 0}) = 1 (out [3], left {30, 0}) write(3, "HEAD / HTTP/1.0\r\nUser-Agent: HTT"..., 64) = 64 sele