Please review the change to update to using jtreg 8.
The primary change is to the `jib-profiles.js` file, which specifies the
version of jtreg to use, for those systems that rely on this file. In addition,
the requiredVersion has been updated in the various `TEST.ROOT` files.
-
Com
On Wed, 9 Jul 2025 18:39:40 GMT, Naoto Sato wrote:
> Replaced Collections.emptyList() with List.of() as part of refactoring. This
> was discussed in the context of investigating a CDS-related issue
> (https://bugs.openjdk.org/browse/JDK-8357281?focusedId=14796714&page=com.atlassian.jira.plugin.
On Thu, 26 Jun 2025 17:22:24 GMT, Alexey Ivanov wrote:
>> Alisen Chung has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> revert german translation, revert english wxl format change
>
> src/demo/share/jfc/SwingSet2/resources/swingset_de.pro
On Wed, 25 Jun 2025 21:28:16 GMT, Alisen Chung wrote:
>> This issue is responsible for updating the translations of all the
>> localize(able) resources in the JDK since the previous L10n drop.
>
> Alisen Chung has updated the pull request incrementally with one additional
> commit since the las
On Mon, 23 Jun 2025 16:44:23 GMT, Alisen Chung wrote:
>> This issue is responsible for updating the translations of all the
>> localize(able) resources in the JDK since the previous L10n drop.
>
> Alisen Chung has updated the pull request incrementally with one additional
> commit since the las
On Mon, 23 Jun 2025 16:44:23 GMT, Alisen Chung wrote:
>> This issue is responsible for updating the translations of all the
>> localize(able) resources in the JDK since the previous L10n drop.
>
> Alisen Chung has updated the pull request incrementally with one additional
> commit since the las
On Mon, 23 Jun 2025 16:44:23 GMT, Alisen Chung wrote:
>> This issue is responsible for updating the translations of all the
>> localize(able) resources in the JDK since the previous L10n drop.
>
> Alisen Chung has updated the pull request incrementally with one additional
> commit since the las
On Mon, 23 Jun 2025 19:04:22 GMT, Alexey Ivanov wrote:
>> If "major tick" is translated to "Hauptteilstrich", then the plural would be
>> `[SliderDemo.majorticks=]Hauptteilstriche` (which is a rather artificial
>> word so the translation team might want to come up with a better translation
>>
On Wed, 18 Jun 2025 07:17:13 GMT, Ana Maria Mihalceanu wrote:
>> Please review my PR. This PR includes the following:
>>
>> - [x] Fix a small typo in a word and copyright.
>> - [x] Enhance description for `--target-platform`.
>> - [x] Rearrange `jmod create` example from basic to complex.
>
> An
On Mon, 2 Jun 2025 13:46:23 GMT, Christian Stein wrote:
> Please review this fix to correctly parse tokens in an argument file that
> contains trailing comments without preceding whitespace characters before the
> '#' comment marker, the number sign.
>
> The specifact
On Thu, 12 Jun 2025 07:57:20 GMT, Ana Maria Mihalceanu wrote:
> Please review my PR. This PR includes the following:
>
> - [x] Fix a small typo in a word and copyright.
> - [x] Enhance description for `--target-platform`.
> - [x] Rearrange `jmod create` example from basic to complex.
Marked as
On Thu, 12 Jun 2025 07:57:20 GMT, Ana Maria Mihalceanu wrote:
> Please review my PR. This PR includes the following:
>
> - [ ] Fix a small typo in a word and copyright
src/jdk.jlink/share/man/jmod.md line 183:
> 181: `--target-platform` *platform*
> 182: : Specifies the target platform. The
On Wed, 11 Jun 2025 11:41:41 GMT, David Beaumont wrote:
>> Christian Stein has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Extract shared function to compute current token
>
> test/jdk/tools/launch
On Tue, 10 Jun 2025 08:15:58 GMT, Christian Stein wrote:
>> Or the handling of `#` can be merged with the previous case ... somehow.
>
> Extracting a method wouldn't really simplify the code, as many local
> variables are in play.
>
> Merging the cases also ends up
here is not requirement specified to prepend a comment in a line with at
> least one argument with one or more preceding whitespace characters.
Christian Stein has updated the pull request incrementally with one additional
commit since the last revision:
Extract shared function to compute curr
On Mon, 2 Jun 2025 16:03:49 GMT, Christian Stein wrote:
>> right I agree that if there is common code we should extract it in a helper
>> method
>
> Or the handling of `#` can be merged with the previous case ... somehow.
Extracting a method wouldn't really simplify
On Mon, 2 Jun 2025 15:08:49 GMT, Vicente Romero wrote:
>> src/java.base/share/native/libjli/args.c line 276:
>>
>>> 274: }
>>> 275: pctx->cptr = nextc + 1;
>>> 276: return token;
>>
>> This code duplicates a large part of the block of
On Mon, 2 Jun 2025 15:35:34 GMT, Vicente Romero wrote:
> the fact that not including a space between the comment and the previous
> element created havoc seems to indicate that the scanner is pretty fragile
> and could break again in the future. We should probably file a follow up to
> make th
On Mon, 2 Jun 2025 13:46:23 GMT, Christian Stein wrote:
> Please review this fix to correctly parse tokens in an argument file that
> contains trailing comments without preceding whitespace characters before the
> '#' comment marker, the number sign.
>
> The specifact
Please review this fix to correctly parse tokens in an argument file that
contains trailing comments without preceding whitespace characters before the
'#' comment marker, the number sign.
The specifaction of the `java` Command has in section [java Command-Line
Argument
Files](https://docs.ora
On Wed, 28 May 2025 11:14:22 GMT, Nizar Benalla wrote:
>> I'll split the releases over two lines in the next update. The line is a
>> little too long.
>
> Thinking about this again, could we represent the supported versions more
> concisely? like `8-26` or `from 8 to 26`.
Another variant:
On Fri, 9 May 2025 09:09:34 GMT, Leo Korinth wrote:
> At the moment I am awaiting jtreg 7.6, I therefore guess the timeout factor
> change to 1 will happen after the fork.
Note, that I moved the timeout configuration feature to `jtreg` 7.5.2 - which
will be released soon.
-
PR Co
On Fri, 9 May 2025 04:54:52 GMT, David Holmes wrote:
> [...]
> ** though another option would be to update the jtreg default timeout instead.
And affect all other tests, too? I'd rather let the default stay on the former
hard-coded 120s value.
-
PR Comment: https://git.openjdk.org
On Tue, 6 May 2025 08:02:21 GMT, Christian Stein wrote:
> Please review this update to synchronize the extra help text for `-Xms` with
> the description given in the manpage.
>
> Copied from the issue:
>> The launcher help text for -Xms is wrong and should be updated to mat
On Tue, 6 May 2025 08:15:16 GMT, Joel Sikström wrote:
> Are the localized texts (in launcher_.properties) updated at a later
> time?
Yes. We only update the English variant without the `_` classifier; the
rest will be translated and updated in pre-release step. See for example
"[8347498: JDK
Please review this update to synchronize the extra help text for `-Xms` with
the description given in the manpage.
Copied from the issue:
> The launcher help text for -Xms is wrong and should be updated to match the
> manpage description. The actual meaning of -Xms is that it sets both the
> in
On Tue, 29 Apr 2025 14:36:37 GMT, Henry Jen wrote:
>> This PR check the jar file to ensure entries are consistent from the central
>> directory and local file header. Also check there is no duplicate entry
>> names that could override the desired content by accident.
>
> Henry Jen has updated t
On Fri, 4 Apr 2025 07:20:23 GMT, Jan Lahoda wrote:
> This is a PR that implements JEP: Compact Source Files and Instance Main
> Methods. Changes include:
> - `java.io.IO` moved to `java.lang.IO`, and no longer uses `System.console()`
> to implement the methods (thanks to @stuart-marks)
> - `jav
On Wed, 5 Feb 2025 20:11:36 GMT, Alexey Semenyuk wrote:
> Enable MSI installers to block installation if the version of Windows is too
> old.
>
> jpackage will read major and minor OS versions from PE headers of the main
> launcher and `java.dll` in the app image. The combined version is the m
On Mon, 13 Jan 2025 11:29:06 GMT, Christian Stein wrote:
>> Please review this change request enabling native access in source launch
>> mode when using a modular setup.
>>
>> The change comes in two parts:
>> 1. Prevent warnings of unknown modules being emitted
On Mon, 6 Jan 2025 16:35:59 GMT, Christian Stein wrote:
> Please review this change request enabling native access in source launch
> mode when using a modular setup.
>
> The change comes in two parts:
> 1. Prevent warnings of unknown modules being emitted from module bootst
On Wed, 8 Jan 2025 20:29:03 GMT, Christian Stein wrote:
>> Please review this change request enabling native access in source launch
>> mode when using a modular setup.
>>
>> The change comes in two parts:
>> 1. Prevent warnings of unknown modules being emitted
gt; _Testing of tier1..3 is in progress..._
Christian Stein has updated the pull request incrementally with three
additional commits since the last revision:
- Update src/java.base/share/classes/jdk/internal/module/ModuleBootstrap.java
- Update src/java.base/share/native/libjli/java.c
On Fri, 10 Jan 2025 16:06:32 GMT, Jaikiran Pai wrote:
> [...] retain the previous order and first check for the suffix and if it's
> not .java, only then do a stat system call.
I started with that oder (before
https://github.com/openjdk/jdk/pull/21910/commits/f0bd01d393a5d88e8b33723b7b4ca16379
On Thu, 9 Jan 2025 20:06:49 GMT, Alan Bateman wrote:
> Do you expect any other options that the source launcher might need to
> handle? Right now, there are warnings when the module or package name is not
> in modules in the boot layer. There other CLI options would be very advanced
> so assum
e variations that omit the
> `--source` arguments like shown in the underlying issue description of
> JDK-8340380.
>
> Tests of tier 1..3: _in progress_
Christian Stein has updated the pull request incrementally with one additional
commit since the last revision:
Flip initial ch
e variations that omit the
> `--source` arguments like shown in the underlying issue description of
> JDK-8340380.
>
> Tests of tier 1..3: _in progress_
Christian Stein has updated the pull request incrementally with two additional
commits since the last revision:
- Update copyrigh
Please review this change that improves the launcher mode detection by reading
the initial two characters from the started shebang script. It addresses the
reported confusing error messages and also supports more shebang line
variations. Including those line variations that omit the `--source` a
On Fri, 20 Dec 2024 12:13:13 GMT, Alan Bateman wrote:
>> Christian Stein has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Add two more valid use-cases
>
> test/jdk/tools/jar/ReleaseBeforeFiles.java line 26
On Thu, 14 Nov 2024 11:57:52 GMT, Christian Stein wrote:
> Please review this change ensuring all targeted classes in a MR-JAR file
> should target the same or a lower classfile version. The [JAR File
> Specification](https://docs.oracle.com/javase/9/docs/specs/jar/jar.html#Mult
On Mon, 16 Dec 2024 14:23:26 GMT, Christian Stein wrote:
>> Please review this change ensuring all targeted classes in a MR-JAR file
>> should target the same or a lower classfile version. The [JAR File
>> Specification](https://docs.oracle.com/javase/9/docs/specs/jar/jar.
an appropriate
> `--release N` option to the associated `javac` call. One of those fixes
> rewrites the classfile version bytes between the `javac` and `jar` calls.
Christian Stein has updated the pull request incrementally with one additional
commit since the last revision:
Fix ar
an appropriate
> `--release N` option to the associated `javac` call. One of those fixes
> rewrites the classfile version bytes between the `javac` and `jar` calls.
Christian Stein has updated the pull request incrementally with one additional
commit since the last revision:
Remove the
an appropriate
> `--release N` option to the associated `javac` call. One of those fixes
> rewrites the classfile version bytes between the `javac` and `jar` calls.
Christian Stein has updated the pull request incrementally with one additional
commit since the last revision:
Improv
On Thu, 14 Nov 2024 11:57:52 GMT, Christian Stein wrote:
> Please review this change ensuring all targeted classes in a MR-JAR file
> should target the same or a lower classfile version. The [JAR File
> Specification](https://docs.oracle.com/javase/9/docs/specs/jar/jar.html#Mult
On Thu, 12 Dec 2024 16:00:52 GMT, Jorn Vernee wrote:
>> According to above's prior-art, it could just read `release of {0} too high:
>> {1}`
>
>> `release of {0} too high: {1}`
>
> I think this is better. Probably good enough.
>
> My concern stems from the fact that 'release' doesn't seem to b
On Thu, 12 Dec 2024 15:26:20 GMT, Christian Stein wrote:
>> In this context the actual class file major version doesn't add any value to
>> communicate the issue to the user:
>> - `javac --release N` and
>> - `jar --release N` use the "Java release feature num
On Thu, 12 Dec 2024 15:32:40 GMT, Christian Stein wrote:
>> Maybe this reads better? `release version of {0} too high: {1}`:
>>
>> release version of META-INF/versions/9/version/Version.class too high: 25
>> release version of META-INF/versions/10/version/Version.class
On Thu, 12 Dec 2024 15:29:33 GMT, Christian Stein wrote:
>> User-facing help messages read:
>>
>> javac --help
>> ...
>> --release
>> Compile for the specified Java SE release.
>> Supported releases:
>> 8, 9, 10, 11
On Thu, 12 Dec 2024 15:23:43 GMT, Christian Stein wrote:
>> src/jdk.jartool/share/classes/sun/tools/jar/resources/jar.properties line 94:
>>
>>> 92: unexpected versioned entry {0} for release {1}
>>> 93: error.release.value.toohigh.versioned.entry=\
>
On Thu, 12 Dec 2024 14:47:24 GMT, Jorn Vernee wrote:
>> Please review this change ensuring all targeted classes in a MR-JAR file
>> should target the same or a lower classfile version.
>>
>> For example, having compiled source files with `javac` 25 without using the
>> `--release` option (or w
On Thu, 14 Nov 2024 11:57:52 GMT, Christian Stein wrote:
> Please review this change ensuring all targeted classes in a MR-JAR file
> should target the same or a lower classfile version.
>
> For example, having compiled source files with `javac` 25 without using the
> `--rele
Please review this change ensuring all targeted classes in a MR-JAR file should
target the same or a lower classfile version.
For example, having compiled source files with `javac` 25 without using the
`--release` option (or with `--release 25`) and trying to archive them via a
`jar --create --
jar -d --release 9 -f a.jar`
>
>
> ==
> Test summary
> ==
>TEST TOTAL PASS FAIL ERROR
>jtreg:test/jdk/tools/jar 2626 0 0
> ======
&
On Tue, 19 Nov 2024 11:12:01 GMT, Christian Stein wrote:
> Please review this follow-up PR to improve `java`'s manpage section about
> wildcards in argument files: the confusing sentence is now removed.
>
> This is a cleanup of commit
> https://github.co
On Wed, 4 Dec 2024 01:51:06 GMT, David Holmes wrote:
>> Christian Stein has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Update java.md
>>
>> [skip ci]
>
> src/java.base/share/man/java.m
> Please review this follow-up PR to improve `java`'s manpage section about
> wildcards in argument files: the confusing sentence is now removed.
>
> This is a cleanup of commit
> https://github.com/openjdk/jdk/commit/5cb0d438231383d491b2fcca455d09af7f2ee016
Christian S
On Wed, 20 Nov 2024 10:53:50 GMT, Jaikiran Pai wrote:
>> Please review this follow-up PR to improve `java`'s manpage section about
>> wildcards in argument files: the confusing sentence is now removed.
>>
>> This is a cleanup of commit
>> https://github.com/openjdk/jdk/commit/5cb0d438231383d49
> Please review this follow-up PR to improve `java`'s manpage section about
> wildcards in argument files: the confusing sentence is now removed.
>
> This is a cleanup of commit
> https://github.com/openjdk/jdk/commit/5cb0d438231383d491b2fcca455d09af7f2ee016
Christian S
> Please review this follow-up PR to improve `java`'s manpage section about
> wildcards in argument files: the confusing sentence is now removed.
>
> This is a cleanup of commit
> https://github.com/openjdk/jdk/commit/5cb0d438231383d491b2fcca455d09af7f2ee016
Christian S
On Fri, 29 Nov 2024 12:16:54 GMT, Nizar Benalla wrote:
>> Can I please get a review for this PR that add tests to verify the value of
>> `@since` tags to the Tools area modules. The test is described in this
>> [email](https://mail.openjdk.org/pipermail/jdk-dev/2024-October/009474.html).
>> Th
On Thu, 14 Nov 2024 01:28:15 GMT, Nizar Benalla wrote:
>> Can I please get a review for this PR that add tests to verify the value of
>> `@since` tags to the Tools area modules. The test is described in this
>> [email](https://mail.openjdk.org/pipermail/jdk-dev/2024-October/009474.html).
>> Th
> Please review this follow-up PR to improve `java`'s manpage section about
> wildcards in argument files: the confusing sentence is now removed.
>
> This is a cleanup of commit
> https://github.com/openjdk/jdk/commit/5cb0d438231383d491b2fcca455d09af7f2ee016
Christian S
Please review this follow-up PR to improve `java`'s manpage section about
wildcards in argument files: the confusing sentence is now removed.
This is a cleanup of commit
https://github.com/openjdk/jdk/commit/5cb0d438231383d491b2fcca455d09af7f2ee016
-
Commit messages:
- 8344540: Re
On Mon, 18 Nov 2024 15:22:59 GMT, Christian Stein wrote:
> Please review this improvement to the manual page covering the usage of
> wildcards in `java`'s argfiles.
> [...] I think this sentence can be removed altogether, given that this
> semantic is already explained a fe
On Mon, 18 Nov 2024 15:22:59 GMT, Christian Stein wrote:
> Please review this improvement to the manual page covering the usage of
> wildcards in `java`'s argfiles.
No, that was an oversight. Good catch!
I will remove that sentence (second last bullet point) in favor of the
au
On Mon, 18 Nov 2024 15:22:59 GMT, Christian Stein wrote:
> Please review this improvement to the manual page covering the usage of
> wildcards in `java`'s argfiles.
This pull request has now been integrated.
Changeset: 5cb0d438
Author: Christian Stein
URL:
https://git.
Please review this improvement to the manual page covering the usage of
wildcards in `java`'s argfiles.
-
Commit messages:
- 8293040: Argfile documentation for java launcher tool is confusing regarding
usage of wildcards
Changes: https://git.openjdk.org/jdk/pull/22208/files
Webr
On Fri, 15 Nov 2024 14:50:21 GMT, Magnus Ihse Bursie wrote:
>> Currently, the man pages are stored as troff (a text format) in the open
>> repo, and a content-wise identical copy is stored as markdown (another text
>> format) in the closed repo.
>>
>> Since markdown is preferred to troff in te
On Fri, 15 Nov 2024 14:46:33 GMT, Magnus Ihse Bursie wrote:
>> Currently, the man pages are stored as troff (a text format) in the open
>> repo, and a content-wise identical copy is stored as markdown (another text
>> format) in the closed repo.
>>
>> Since markdown is preferred to troff in te
On Thu, 14 Nov 2024 11:11:54 GMT, Magnus Ihse Bursie wrote:
>> Currently, the man pages are stored as troff (a text format) in the open
>> repo, and a content-wise identical copy is stored as markdown (another text
>> format) in the closed repo.
>>
>> Since markdown is preferred to troff in te
On Wed, 13 Nov 2024 17:05:25 GMT, Magnus Ihse Bursie wrote:
> Currently, the man pages are stored as troff (a text format) in the open
> repo, and a content-wise identical copy is stored as markdown (another text
> format) in the closed repo.
>
> Since markdown is preferred to troff in terms o
On Wed, 13 Nov 2024 17:05:25 GMT, Magnus Ihse Bursie wrote:
> Currently, the man pages are stored as troff (a text format) in the open
> repo, and a content-wise identical copy is stored as markdown (another text
> format) in the closed repo.
>
> Since markdown is preferred to troff in terms o
Please review this change for the `jar` tool to gracefully handle the case
where `--release` is not specified as the last arguments.
Prior to this commit, operation modes `-d --describe-module` and `--validate`
expected to read the optional `--release` option as a file argument: `jar -d -f
a.ja
jar -d --release 9 -f a.jar`
>
>
> ==
> Test summary
> ==
>TEST TOTAL PASS FAIL ERROR
>jtreg:test/jdk/tools/jar 2626 0 0
> ======
&
On Mon, 7 Oct 2024 05:58:53 GMT, Jaikiran Pai wrote:
>> Can I please get a review for this patch which proposes to implement the
>> enhancement request noted in
>> https://bugs.openjdk.java.net/browse/JDK-8173970?
>>
>> Edit: This PR description has now been updated to match the changes that
On Tue, 10 Sep 2024 05:31:29 GMT, Jaikiran Pai wrote:
> Can I please get a review of this change which proposes to address
> https://bugs.openjdk.org/browse/JDK-8339810?
>
> As noted in the issue we have a few places in the jar's tool `Main` class
> where we currently don't close the resources
On Tue, 10 Sep 2024 04:36:42 GMT, Jaikiran Pai wrote:
>> Can I please get a review for this patch which proposes to implement the
>> enhancement request noted in
>> https://bugs.openjdk.java.net/browse/JDK-8173970?
>>
>> The commit in this PR introduces the `-o` and `--output-dir` option to th
On Tue, 27 Aug 2024 08:38:23 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this change which proposes to fix the issue
>> noted in https://bugs.openjdk.org/browse/JDK-8338445?
>>
>> The JDK internal class `jdk.internal.loader.URLClassPath` is used by
>> classloader implementations i
On Mon, 26 Aug 2024 03:47:49 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this change which proposes to fix the issue
>> noted in https://bugs.openjdk.org/browse/JDK-8338445?
>>
>> The JDK internal class `jdk.internal.loader.URLClassPath` is used by
>> classloader implementations i
Please review this trivial test-only change to resolve a name clash with a
jtreg-reserved property by removing the third option to control a test
verbosity level via the `test.verbose` system property.
The fix assumes that the system property was only used in a manual scenario,
like `make test
On Thu, 2 May 2024 09:48:51 GMT, Christian Stein wrote:
> Please review the change to update to using `jtreg` **7.4**.
>
> The primary change is to the `jib-profiles.js` file, which specifies the
> version of jtreg to use, for those systems that rely on this file. In
>
On Thu, 2 May 2024 09:48:51 GMT, Christian Stein wrote:
> Please review the change to update to using `jtreg` **7.4**.
>
> The primary change is to the `jib-profiles.js` file, which specifies the
> version of jtreg to use, for those systems that rely on this file. In
>
On Thu, 2 May 2024 09:48:51 GMT, Christian Stein wrote:
> Please review the change to update to using `jtreg` **7.4**.
>
> The primary change is to the `jib-profiles.js` file, which specifies the
> version of jtreg to use, for those systems that rely on this file. In
>
Please review the change to update to using `jtreg` **7.4**.
The primary change is to the `jib-profiles.js` file, which specifies the
version of jtreg to use, for those systems that rely on this file. In addition,
the `requiredVersion` has been updated in the various `TEST.ROOT` files.
Testing:
On Sun, 9 Jun 2024 19:35:04 GMT, Justin Lu wrote:
>> Damon Nguyen has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Remove double quotes
>
> src/jdk.jconsole/share/classes/sun/tools/jconsole/resources/messages_de.properties
> line 285:
>
On Mon, 10 Jun 2024 20:34:10 GMT, Damon Nguyen wrote:
>> src/jdk.compiler/share/classes/com/sun/tools/javac/resources/compiler_de.properties
>> line 409:
>>
>>> 407: compiler.err.unconditional.pattern.and.default=Switch umfasst sowohl
>>> ein nicht bedingtes Muster als auch ein Standardlabel
>
On Mon, 10 Jun 2024 22:48:13 GMT, Damon Nguyen wrote:
>> src/jdk.jdi/share/classes/com/sun/tools/example/debug/tty/TTYResources_de.java
>> line 325:
>>
>>> 323: {"Unexpected event type", "Unerwarteter Ereignistyp: {0}"},
>>> 324: {"unknown", "unbekannt"},
>>> 325: {"Unmo
On Tue, 11 Jun 2024 05:43:12 GMT, Christian Stein wrote:
>> src/java.desktop/share/classes/sun/print/resources/serviceui_de.properties
>> line 66:
>>
>>> 64: label.size=G&röße:
>>> 65: label.source=&Quelle:
>>> 66: label.outputbin
On Mon, 10 Jun 2024 20:19:51 GMT, Phil Race wrote:
>> Damon Nguyen has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Remove double quotes
>
> src/java.desktop/share/classes/sun/print/resources/serviceui_de.properties
> line 66:
>
>> 64:
On Tue, 9 Apr 2024 13:38:29 GMT, Jan Lahoda wrote:
>> This is an implementation of JEP JDK-8315129: Module Import Declarations
>> (Preview). Please see the JEP for details:
>> https://bugs.openjdk.org/browse/JDK-8315129
>>
>> It is mostly straightforward - the module imports are parsed, and the
On Mon, 19 Feb 2024 15:42:05 GMT, Christian Stein wrote:
>> Please review this PR that makes the launcher helper keep a reference to the
>> executable JAR file active after extracting the name of the main class and
>> returning it as Class instance. Now, when loading classes
On Wed, 14 Feb 2024 11:03:07 GMT, Christian Stein wrote:
> Please review this PR that makes the launcher helper keep a reference to the
> executable JAR file active after extracting the name of the main class and
> returning it as Class instance. Now, when loading classes from the
On Thu, 15 Feb 2024 08:53:12 GMT, Alan Bateman wrote:
>> `String jarname` is filled by the caller with the value of `String what`,
>> and therefore contains the entire path to the executable JAR file. Using
>> only `jarFile.getName()` will prevent any parent directories from being
>> noted in
> Please review this PR that makes the launcher helper keep a reference to the
> executable JAR file active after extracting the name of the main class and
> returning it as Class instance. Now, when loading classes from the JAR file,
> it hasn't to be re-opened.
Christian
On Mon, 19 Feb 2024 07:32:31 GMT, Jaikiran Pai wrote:
> Both the files will need a copyright year update.
Right. Updating both files.
> The JBS issue would need an appropriate noreg label too
> https://openjdk.org/guide/#noreg
Added `noreg-cleanup` to the issue.
-
PR Comment: ht
On Mon, 19 Feb 2024 10:41:03 GMT, Alan Bateman wrote:
>> src/java.base/share/classes/sun/launcher/LauncherHelper.java line 821:
>>
>>> 819: // In LM_JAR mode, put the underlying file in the
>>> JarFile/ZipFile cache.
>>> 820: // This will avoid needing to re-parse the manifest w
On Mon, 19 Feb 2024 07:04:07 GMT, David Holmes wrote:
> Please reviews these manpage updates in relation to "JEP 458: Launch
> Multi-File Source-Code Programs". The manpage sources had previously been
> updated internally at Oracle under JDK-8322478, but the open troff file was
> not regenera
> Please review this PR that makes the launcher helper keep a reference to the
> executable JAR file active after extracting the name of the main class and
> returning it as Class instance. Now, when loading classes from the JAR file,
> it hasn't to be re-opened.
Christian
On Wed, 14 Feb 2024 11:41:43 GMT, Alan Bateman wrote:
>> Please review this PR that makes the launcher helper keep a reference to the
>> executable JAR file active after extracting the name of the main class and
>> returning it as Class instance. Now, when loading classes from the JAR file,
>>
1 - 100 of 177 matches
Mail list logo
