On Mon, 2 Jun 2025 15:08:49 GMT, Vicente Romero <vrom...@openjdk.org> wrote:

>> src/java.base/share/native/libjli/args.c line 276:
>> 
>>> 274:                     }
>>> 275:                     pctx->cptr = nextc + 1;
>>> 276:                     return token;
>> 
>> This code duplicates a large part of the block of the previous case. Perhaps 
>> an internal helper method could be extracted?
>
> right I agree that if there is common code we should extract it in a helper 
> method

Or the handling of `#` can be merged with the previous case ... somehow.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/25589#discussion_r2121594206

Reply via email to