codecov-commenter commented on PR #14544:
URL: https://github.com/apache/pinot/pull/14544#issuecomment-2501941200
##
[Codecov](https://app.codecov.io/gh/apache/pinot/pull/14544?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u
jasperjiaguo commented on code in PR #14536:
URL: https://github.com/apache/pinot/pull/14536#discussion_r1859267651
##
pinot-controller/src/main/java/org/apache/pinot/controller/helix/SegmentStatusChecker.java:
##
@@ -330,46 +334,46 @@ private void updateSegmentMetrics(String
t
jasperjiaguo commented on issue #14538:
URL: https://github.com/apache/pinot/issues/14538#issuecomment-2501989780
Thanks @mqliang . Regarding 2. we have previously run into issues where
queriesDisabled is accidentally not cleared but went under the radar and caused
availability issues.
--
jasperjiaguo commented on issue #14538:
URL: https://github.com/apache/pinot/issues/14538#issuecomment-2501993335
We want to
1. either enhance the existing replicas_up metric
2. or for better backward compat add an replicas_up v2 to include
queriesDisabled and shutdownInProgress
deemoliu commented on code in PR #14534:
URL: https://github.com/apache/pinot/pull/14534#discussion_r1859268751
##
pinot-plugins/pinot-input-format/pinot-clp-log/src/main/java/org/apache/pinot/plugin/inputformat/clplog/CLPLogRecordExtractorConfig.java:
##
@@ -54,6 +55,7 @@ publi
jasperjiaguo commented on code in PR #14536:
URL: https://github.com/apache/pinot/pull/14536#discussion_r1859267651
##
pinot-controller/src/main/java/org/apache/pinot/controller/helix/SegmentStatusChecker.java:
##
@@ -330,46 +334,46 @@ private void updateSegmentMetrics(String
t
jasperjiaguo commented on PR #14536:
URL: https://github.com/apache/pinot/pull/14536#issuecomment-2502006210
Discussed internally that we should have an instance config cache and fetch
on demand. Meanwhile, do we want to have 2 versions of the metric that maybe
config-controlled or both ava
lnbest0707-uber commented on PR #14097:
URL: https://github.com/apache/pinot/pull/14097#issuecomment-2502108096
Abandon the change, will use https://github.com/apache/pinot/pull/14200
instead
--
This is an automated message from the Apache Git Service.
To respond to the message, please lo
lnbest0707-uber commented on PR #13188:
URL: https://github.com/apache/pinot/pull/13188#issuecomment-2502111643
Some changes might not be needed anymore, will abandon this PR and use
another one to converge with what we used in Uber
--
This is an automated message from the Apache Git Serv
lnbest0707-uber closed pull request #13188: Upgrade and optimize text search in
SchemaConformingTransformerV2
URL: https://github.com/apache/pinot/pull/13188
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above t
lnbest0707-uber closed pull request #12932: Followup fix and improvements on
SchemaConformingTransformerV2
URL: https://github.com/apache/pinot/pull/12932
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to g
klsince commented on PR #14544:
URL: https://github.com/apache/pinot/pull/14544#issuecomment-2502153650
e.g. when call batchReload with
```
{"Server_100.107.42.37_7050": ["airlineStats_OFFLINE_16071_16071_0"],
"Server_100.107.42.37_7051": ["airlineStats_OFFLINE_16101_16101_1"]}
```
stephaniemelton opened a new issue, #14542:
URL: https://github.com/apache/pinot/issues/14542
**Pinot Version:** 1.2.0
**Summary:** All queries return a 403 Forbidden error unless the query
starts with a comment. Disabled auth mechanisms and it still throws the 403
error without the
deemoliu commented on code in PR #14534:
URL: https://github.com/apache/pinot/pull/14534#discussion_r1859074499
##
pinot-plugins/pinot-input-format/pinot-clp-log/src/main/java/org/apache/pinot/plugin/inputformat/clplog/CLPLogRecordExtractorConfig.java:
##
@@ -54,6 +55,7 @@ publi
deemoliu commented on code in PR #14534:
URL: https://github.com/apache/pinot/pull/14534#discussion_r1859073115
##
pinot-plugins/pinot-input-format/pinot-clp-log/src/main/java/org/apache/pinot/plugin/inputformat/clplog/CLPLogRecordExtractor.java:
##
@@ -253,5 +253,9 @@ private v
jackluo923 commented on code in PR #14534:
URL: https://github.com/apache/pinot/pull/14534#discussion_r1859076644
##
pinot-plugins/pinot-input-format/pinot-clp-log/src/main/java/org/apache/pinot/plugin/inputformat/clplog/CLPLogRecordExtractorConfig.java:
##
@@ -54,6 +55,7 @@ pub
deemoliu commented on code in PR #14534:
URL: https://github.com/apache/pinot/pull/14534#discussion_r1859091189
##
pinot-plugins/pinot-input-format/pinot-clp-log/src/main/java/org/apache/pinot/plugin/inputformat/clplog/CLPLogRecordExtractorConfig.java:
##
@@ -54,6 +55,7 @@ publi
mqliang closed pull request #14536: Enhance SegmentStatusChecker to honor
no-queryable servers and instance assignment config
URL: https://github.com/apache/pinot/pull/14536
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
Jackie-Jiang commented on code in PR #14506:
URL: https://github.com/apache/pinot/pull/14506#discussion_r1859153129
##
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/realtime/PinotLLCRealtimeSegmentManager.java:
##
@@ -1557,6 +1558,7 @@ public void uploadT
Jackie-Jiang commented on code in PR #14415:
URL: https://github.com/apache/pinot/pull/14415#discussion_r1859156847
##
pinot-plugins/pinot-batch-ingestion/pinot-batch-ingestion-spark-2.4/src/main/java/org/apache/pinot/plugin/ingestion/batch/spark/SparkSegmentMetadataPushJobRunner.java:
This is an automated email from the ASF dual-hosted git repository.
jackie pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
The following commit(s) were added to refs/heads/master by this push:
new 8333688e4e Replace More String.format() Usages Wi
Jackie-Jiang merged PR #14539:
URL: https://github.com/apache/pinot/pull/14539
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot
mqliang closed pull request #14536: Enhance SegmentStatusChecker to honor
no-queryable servers and instance assignment config
URL: https://github.com/apache/pinot/pull/14536
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
Jackie-Jiang commented on issue #14529:
URL: https://github.com/apache/pinot/issues/14529#issuecomment-2501822661
I'd suggest adding a flag in the existing endpoint to control the desired
behavior. A new API is kind of overkilling, and not as explicit as having a flag
--
This is an automa
xiangfu0 commented on PR #14537:
URL: https://github.com/apache/pinot/pull/14537#issuecomment-2501975636
Thanks for supporting this !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
This is an automated email from the ASF dual-hosted git repository.
xiangfu pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
from b34e805ced Add GeoJSON support. (#14405)
add 1975268b4c [Scalar Function][Array] Add ArrayJoinString Scalar
func
This is an automated email from the ASF dual-hosted git repository.
jackie pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
The following commit(s) were added to refs/heads/master by this push:
new b34e805ced Add GeoJSON support. (#14405)
b34e805c
xiangfu0 merged PR #14537:
URL: https://github.com/apache/pinot/pull/14537
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apa
mqliang closed pull request #14536: Enhance SegmentStatusChecker to honor
no-queryable servers and instance assignment config
URL: https://github.com/apache/pinot/pull/14536
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
Jackie-Jiang merged PR #14540:
URL: https://github.com/apache/pinot/pull/14540
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot
This is an automated email from the ASF dual-hosted git repository.
jackie pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
The following commit(s) were added to refs/heads/master by this push:
new b9676ff77b Bump com.dynatrace.hash4j:hash4j from
This is an automated email from the ASF dual-hosted git repository.
jackie pushed a change to branch
dependabot/maven/com.dynatrace.hash4j-hash4j-0.19.0
in repository https://gitbox.apache.org/repos/asf/pinot.git
was 2f63273abf Bump com.dynatrace.hash4j:hash4j from 0.18.0 to 0.19.0
The re
Jackie-Jiang commented on code in PR #14348:
URL: https://github.com/apache/pinot/pull/14348#discussion_r1859150302
##
docker/images/pinot/etc/jmx_prometheus_javaagent/configs/server.yml:
##
@@ -1,99 +1,12 @@
rules:
-- pattern:
"\"org\\.apache\\.pinot\\.common\\.metrics\"<>(\\
Jackie-Jiang commented on PR #14405:
URL: https://github.com/apache/pinot/pull/14405#issuecomment-2501788022
Great job! Please help also update the pinot documentation for these new
functions
--
This is an automated message from the Apache Git Service.
To respond to the message, please lo
Jackie-Jiang merged PR #14405:
URL: https://github.com/apache/pinot/pull/14405
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot
Jackie-Jiang commented on issue #14543:
URL: https://github.com/apache/pinot/issues/14543#issuecomment-2501794525
Do you want to help with this ticket? We can try upgrade it and see if
anything breaks
--
This is an automated message from the Apache Git Service.
To respond to the message,
mzetkulic commented on issue #11795:
URL: https://github.com/apache/pinot/issues/11795#issuecomment-2501908106
Hey there, I'm running into a similar issue and am trying to debug some
ingestion tasks. Would be very helpful for me if there was a way to get the
full stack trace on error.
ilamhs opened a new issue, #14545:
URL: https://github.com/apache/pinot/issues/14545
This is an enhancement and complementary to the current [SumPrecision
aggregate function that is
supported](https://github.com/pinot-contrib/pinot-docs/blob/archive/master/configuration-reference/functions/
lnbest0707-uber closed pull request #14097: [SchemaConformingTransformer]Add
one more json_data field
URL: https://github.com/apache/pinot/pull/14097
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
hpvd commented on PR #14115:
URL: https://github.com/apache/pinot/pull/14115#issuecomment-2501304571
since this cancelled update to Pulsar 4.0.0 preview, there was the final
release of Pulsar 4.0.0
shouldn t dependabot pick this up automatically?
(and why does it suggest preview ve
mqliang closed pull request #14536: Enhance SegmentStatusChecker to honor
no-queryable servers and instance assignment config
URL: https://github.com/apache/pinot/pull/14536
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
swaminathanmanish commented on code in PR #14373:
URL: https://github.com/apache/pinot/pull/14373#discussion_r1858615471
##
pinot-core/src/main/java/org/apache/pinot/core/segment/processing/aggregator/DistinctCountCPCSketchAggregator.java:
##
@@ -30,7 +31,7 @@ public DistinctCou
Jackie-Jiang commented on code in PR #14348:
URL: https://github.com/apache/pinot/pull/14348#discussion_r1859092813
##
docker/images/pinot/etc/jmx_prometheus_javaagent/configs/broker.yml:
##
@@ -1,206 +1,13 @@
rules:
-- pattern:
"\"org\\.apache\\.pinot\\.common\\.metrics\"<>(\
codecov-commenter commented on PR #14546:
URL: https://github.com/apache/pinot/pull/14546#issuecomment-2502359146
##
[Codecov](https://app.codecov.io/gh/apache/pinot/pull/14546?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u
Jackie-Jiang opened a new pull request, #14547:
URL: https://github.com/apache/pinot/pull/14547
The concept is similar to #13572, which added a config to differentiate
empty array and `null`.
This PR makes this the default behavior (reverted the added config), and
extend the behavior to
lnbest0707-uber opened a new pull request, #14546:
URL: https://github.com/apache/pinot/pull/14546
`feature``bugfix` `backward-incompat`
This PR will converge the open source SchemaConformingTransformerV2 with
Uber internal's version. The later one has been running in real production
env
KKcorps commented on code in PR #14547:
URL: https://github.com/apache/pinot/pull/14547#discussion_r1859979124
##
pinot-plugins/pinot-input-format/pinot-parquet/src/main/java/org/apache/pinot/plugin/inputformat/parquet/ParquetNativeRecordExtractor.java:
##
@@ -209,79 +207,26 @@
mqliang commented on code in PR #14536:
URL: https://github.com/apache/pinot/pull/14536#discussion_r1859811521
##
pinot-controller/src/main/java/org/apache/pinot/controller/util/ServerInfoFetcher.java:
##
@@ -53,7 +53,7 @@ private ServerInfo getServerInfoOndemand(String instance
mqliang commented on code in PR #14536:
URL: https://github.com/apache/pinot/pull/14536#discussion_r1859811521
##
pinot-controller/src/main/java/org/apache/pinot/controller/util/ServerInfoFetcher.java:
##
@@ -53,7 +53,7 @@ private ServerInfo getServerInfoOndemand(String instance
mqliang commented on code in PR #14536:
URL: https://github.com/apache/pinot/pull/14536#discussion_r1859819708
##
pinot-integration-test-base/src/test/java/org/apache/pinot/integration/tests/ClusterTest.java:
##
@@ -259,7 +259,9 @@ protected void startServers(int numServers)
mqliang commented on PR #14536:
URL: https://github.com/apache/pinot/pull/14536#issuecomment-2502801529
`KafkaConfluentSchemaRegistryAvroMessageDecoderRealtimeClusterIntegrationTest`
failed due to pulling docker image issue. It's not related to the change
```
org.testcontainers.co
mqliang commented on code in PR #14536:
URL: https://github.com/apache/pinot/pull/14536#discussion_r1859830621
##
pinot-integration-test-base/src/test/java/org/apache/pinot/integration/tests/ClusterTest.java:
##
@@ -259,7 +259,9 @@ protected void startServers(int numServers)
mqliang commented on code in PR #14536:
URL: https://github.com/apache/pinot/pull/14536#discussion_r1859819708
##
pinot-integration-test-base/src/test/java/org/apache/pinot/integration/tests/ClusterTest.java:
##
@@ -259,7 +259,9 @@ protected void startServers(int numServers)
mqliang commented on code in PR #14536:
URL: https://github.com/apache/pinot/pull/14536#discussion_r1859811521
##
pinot-controller/src/main/java/org/apache/pinot/controller/util/ServerInfoFetcher.java:
##
@@ -53,7 +53,7 @@ private ServerInfo getServerInfoOndemand(String instance
lnbest0707-uber commented on PR #13790:
URL: https://github.com/apache/pinot/pull/13790#issuecomment-2502421050
Thanks @itschrispeck for identifying a edge case issue and proposing the fix
in the commit
https://github.com/apache/pinot/pull/13790/commits/6bd1307c9249ce73232865cfe4edcc967b058
codecov-commenter commented on PR #14547:
URL: https://github.com/apache/pinot/pull/14547#issuecomment-2502424648
##
[Codecov](https://app.codecov.io/gh/apache/pinot/pull/14547?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u
raghavagrawal opened a new issue, #14548:
URL: https://github.com/apache/pinot/issues/14548
We need support for aggregation of raw KLL sketch in minion merge/rollup
tasks. For this we will add new aggregator in Pinot. We have a use-case where
we need to merge war KLL sketches to get specifi
KKcorps commented on code in PR #14547:
URL: https://github.com/apache/pinot/pull/14547#discussion_r1859968921
##
pinot-plugins/pinot-input-format/pinot-json/src/main/java/org/apache/pinot/plugin/inputformat/json/JSONRecordExtractor.java:
##
@@ -40,9 +38,9 @@ public class JSONRe
tibrewalpratik17 commented on code in PR #14506:
URL: https://github.com/apache/pinot/pull/14506#discussion_r1857995417
##
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/realtime/PinotLLCRealtimeSegmentManager.java:
##
@@ -1593,6 +1599,16 @@ public void up
tibrewalpratik17 commented on code in PR #14506:
URL: https://github.com/apache/pinot/pull/14506#discussion_r1857998127
##
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/realtime/PinotLLCRealtimeSegmentManager.java:
##
@@ -1557,6 +1558,7 @@ public void upl
Harnoor7 commented on code in PR #14503:
URL: https://github.com/apache/pinot/pull/14503#discussion_r1858224111
##
pinot-controller/src/test/java/org/apache/pinot/controller/api/resources/PinotSegmentUploadDownloadRestletResourceTest.java:
##
@@ -56,20 +66,27 @@ public class Pin
Harnoor7 commented on code in PR #14503:
URL: https://github.com/apache/pinot/pull/14503#discussion_r1858232713
##
pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/ControllerFilePathProvider.java:
##
@@ -126,14 +128,38 @@ public URI getDataDirURI() {
}
bziobrowski commented on code in PR #14405:
URL: https://github.com/apache/pinot/pull/14405#discussion_r1858268466
##
pinot-core/src/main/java/org/apache/pinot/core/geospatial/transform/function/ConstructFromGeoJsonFunction.java:
##
@@ -0,0 +1,94 @@
+/**
+ * Licensed to the Apac
shounakmk219 commented on code in PR #14503:
URL: https://github.com/apache/pinot/pull/14503#discussion_r1858276325
##
pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/ControllerFilePathProvider.java:
##
@@ -126,14 +126,17 @@ public URI getDataDirURI() {
Harnoor7 commented on code in PR #14503:
URL: https://github.com/apache/pinot/pull/14503#discussion_r1858233136
##
pinot-controller/src/test/java/org/apache/pinot/controller/api/resources/PinotSegmentUploadDownloadRestletResourceTest.java:
##
@@ -158,7 +175,8 @@ public void test
Harnoor7 commented on PR #14503:
URL: https://github.com/apache/pinot/pull/14503#issuecomment-2500263492
> I suppose this error only occurs in tests not production right?
We faced this issue on production
--
This is an automated message from the Apache Git Service.
To respond to the
Harnoor7 commented on code in PR #14503:
URL: https://github.com/apache/pinot/pull/14503#discussion_r1858234529
##
pinot-controller/src/test/java/org/apache/pinot/controller/api/resources/PinotSegmentUploadDownloadRestletResourceTest.java:
##
@@ -249,4 +267,58 @@ public void tes
Harnoor7 commented on code in PR #14503:
URL: https://github.com/apache/pinot/pull/14503#discussion_r1858232043
##
pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/ControllerFilePathProvider.java:
##
@@ -126,14 +128,38 @@ public URI getDataDirURI() {
}
Harnoor7 commented on code in PR #14479:
URL: https://github.com/apache/pinot/pull/14479#discussion_r1858257147
##
pinot-segment-local/src/test/java/org/apache/pinot/segment/local/indexsegment/mutable/MutableSegmentImplTestUtils.java:
##
@@ -82,22 +82,22 @@ public static Mutable
Harnoor7 commented on code in PR #14479:
URL: https://github.com/apache/pinot/pull/14479#discussion_r1858294143
##
pinot-spi/src/main/java/org/apache/pinot/spi/config/table/IndexingConfig.java:
##
@@ -410,6 +411,14 @@ public void setSegmentNameGeneratorType(String
segmentNameGe
shounakmk219 commented on code in PR #14503:
URL: https://github.com/apache/pinot/pull/14503#discussion_r1858333654
##
pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/ControllerFilePathProvider.java:
##
@@ -126,14 +126,17 @@ public URI getDataDirURI() {
dependabot[bot] opened a new pull request, #14540:
URL: https://github.com/apache/pinot/pull/14540
Bumps [com.dynatrace.hash4j:hash4j](https://github.com/dynatrace-oss/hash4j)
from 0.18.0 to 0.19.0.
Release notes
Sourced from https://github.com/dynatrace-oss/hash4j/releases";>com.d
dependabot[bot] opened a new pull request, #14541:
URL: https://github.com/apache/pinot/pull/14541
Bumps software.amazon.awssdk:bom from 2.29.20 to 2.29.21.
Most Recent Ignore Conditions Applied to This Pull Request
| Dependency Name | Ignore Conditions |
| --- | --- |
This is an automated email from the ASF dual-hosted git repository.
github-bot pushed a change to branch
dependabot/maven/software.amazon.awssdk-bom-2.29.21
in repository https://gitbox.apache.org/repos/asf/pinot.git
at 0275ec7bbe Bump software.amazon.awssdk:bom from 2.29.20 to 2.29.21
N
Harnoor7 commented on code in PR #14503:
URL: https://github.com/apache/pinot/pull/14503#discussion_r1858330562
##
pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/ControllerFilePathProvider.java:
##
@@ -126,14 +126,17 @@ public URI getDataDirURI() {
}
tibrewalpratik17 merged PR #14541:
URL: https://github.com/apache/pinot/pull/14541
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@p
This is an automated email from the ASF dual-hosted git repository.
pratik pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
The following commit(s) were added to refs/heads/master by this push:
new e5493fd3c8 Bump software.amazon.awssdk:bom from 2
This is an automated email from the ASF dual-hosted git repository.
pratik pushed a change to branch
dependabot/maven/software.amazon.awssdk-bom-2.29.21
in repository https://gitbox.apache.org/repos/asf/pinot.git
was 0275ec7bbe Bump software.amazon.awssdk:bom from 2.29.20 to 2.29.21
The r
78 matches
Mail list logo
