tibrewalpratik17 commented on code in PR #14506:
URL: https://github.com/apache/pinot/pull/14506#discussion_r1857998127
##########
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/realtime/PinotLLCRealtimeSegmentManager.java:
##########
@@ -1557,6 +1558,7 @@ public void uploadToDeepStoreIfMissing(TableConfig
tableConfig, List<SegmentZKMe
// Randomly ask one server to upload
URI uri =
peerSegmentURIs.get(RANDOM.nextInt(peerSegmentURIs.size()));
+ String crcFromServer = getSegmentCrcFromServer(realtimeTableName,
segmentName, uri.toString());
Review Comment:
> enhance the server upload API to return both segment location (i.e.
tempSegmentDownloadUrl) and also crc.
This change would require implementing a new server API, as users might be
directly utilizing the existing API, making the modification
backward-incompatible. If introducing a new API is acceptable, I can proceed
with its implementation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
