mqliang commented on code in PR #14536: URL: https://github.com/apache/pinot/pull/14536#discussion_r1859811521
########## pinot-controller/src/main/java/org/apache/pinot/controller/util/ServerInfoFetcher.java: ########## @@ -53,7 +53,7 @@ private ServerInfo getServerInfoOndemand(String instanceId) { List<String> tags = instanceConfig.getTags(); ZNRecord record = instanceConfig.getRecord(); boolean helixEnabled = record.getBooleanField( - InstanceConfig.InstanceConfigProperty.HELIX_ENABLED.name(), false); + InstanceConfig.InstanceConfigProperty.HELIX_ENABLED.name(), true); Review Comment: @sajjad-moradi @jasperjiaguo The default value of `HELIX_ENABLED` must be `true`. Otherwise `ControllerPeriodicTasksIntegrationTest` will fail. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org