Jackie-Jiang commented on code in PR #14415: URL: https://github.com/apache/pinot/pull/14415#discussion_r1859156847
########## pinot-plugins/pinot-batch-ingestion/pinot-batch-ingestion-spark-2.4/src/main/java/org/apache/pinot/plugin/ingestion/batch/spark/SparkSegmentMetadataPushJobRunner.java: ########## @@ -43,8 +36,8 @@ import org.apache.spark.api.java.function.VoidFunction; -public class SparkSegmentMetadataPushJobRunner implements IngestionJobRunner, Serializable { - private SegmentGenerationJobSpec _spec; + Review Comment: (minor, format) Too many empty lines ########## pinot-plugins/pinot-batch-ingestion/pinot-batch-ingestion-spark-2.4/pom.xml: ########## @@ -108,6 +108,12 @@ <groupId>org.codehaus.woodstox</groupId> <artifactId>stax2-api</artifactId> </dependency> + <dependency> + <groupId>org.apache.pinot</groupId> + <artifactId>pinot-batch-ingestion-spark-base</artifactId> Review Comment: You may replace `pinot-batch-ingestion-common` with `pinot-batch-ingestion-spark-base` in the above dependency. No need to specify version or scope explicitly ########## pinot-plugins/pinot-batch-ingestion/pinot-batch-ingestion-spark-base/src/main/java/org/apache/pinot/plugin/ingestion/batch/spark/common/AbstractSparkSegmentMetadataPushJobRunner.java: ########## @@ -0,0 +1,115 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.pinot.plugin.ingestion.batch.spark.common; + +import java.io.File; +import java.io.IOException; +import java.io.Serializable; +import java.net.URI; +import java.net.URISyntaxException; +import java.util.ArrayList; +import java.util.List; +import org.apache.pinot.segment.local.utils.SegmentPushUtils; +import org.apache.pinot.spi.env.PinotConfiguration; +import org.apache.pinot.spi.filesystem.PinotFS; +import org.apache.pinot.spi.filesystem.PinotFSFactory; +import org.apache.pinot.spi.ingestion.batch.runner.IngestionJobRunner; +import org.apache.pinot.spi.ingestion.batch.spec.Constants; +import org.apache.pinot.spi.ingestion.batch.spec.PinotFSSpec; +import org.apache.pinot.spi.ingestion.batch.spec.SegmentGenerationJobSpec; +import org.apache.pinot.spi.utils.retry.AttemptsExceededException; +import org.apache.pinot.spi.utils.retry.RetriableOperationException; + + +public abstract class AbstractSparkSegmentMetadataPushJobRunner implements IngestionJobRunner, Serializable { Review Comment: Suggest calling these abstract classes `BaseSpark...` ########## pinot-plugins/pinot-batch-ingestion/pinot-batch-ingestion-spark-base/pom.xml: ########## @@ -0,0 +1,53 @@ +<?xml version="1.0" encoding="UTF-8"?> +<!-- + + Licensed to the Apache Software Foundation (ASF) under one + or more contributor license agreements. See the NOTICE file + distributed with this work for additional information + regarding copyright ownership. The ASF licenses this file + to you under the Apache License, Version 2.0 (the + "License"); you may not use this file except in compliance + with the License. You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + + Unless required by applicable law or agreed to in writing, + software distributed under the License is distributed on an + "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + KIND, either express or implied. See the License for the + specific language governing permissions and limitations + under the License. + +--> +<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd"> + <modelVersion>4.0.0</modelVersion> + <parent> + <artifactId>pinot-batch-ingestion</artifactId> + <groupId>org.apache.pinot</groupId> + <version>1.3.0-SNAPSHOT</version> + </parent> + + <artifactId>pinot-batch-ingestion-spark-base</artifactId> + <name>Pinot Batch Ingestion Spark Base</name> + <url>https://pinot.apache.org/</url> + <properties> + <pinot.root>${basedir}/../../..</pinot.root> + <shade.phase.prop>package</shade.phase.prop> + </properties> + + <dependencies> + <dependency> + <groupId>org.apache.pinot</groupId> + <artifactId>pinot-batch-ingestion-common</artifactId> + </dependency> + </dependencies> + + <profiles> + <profile> + <id>pinot-fastdev</id> + <properties> + <shade.phase.prop>none</shade.phase.prop> + </properties> + </profile> + </profiles> +</project> Review Comment: (minor) Add an empty line -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org