Jackie-Jiang closed issue #8182: Very Old Segments of a Deleted Table Still
Present in Servers
URL: https://github.com/apache/pinot/issues/8182
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the sp
Jackie-Jiang commented on PR #11378:
URL: https://github.com/apache/pinot/pull/11378#issuecomment-1683487786
The custom test suite is not run at all..
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
Jackie-Jiang commented on PR #11376:
URL: https://github.com/apache/pinot/pull/11376#issuecomment-1683492912
I don't follow the difference by reading the stack overflow. The lines are
similar, but the coverage is dropped significantly. Is that expected?
--
This is an automated message fro
Jackie-Jiang commented on code in PR #11374:
URL: https://github.com/apache/pinot/pull/11374#discussion_r1298121563
##
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/index/loader/ForwardIndexHandler.java:
##
@@ -219,6 +219,11 @@ Map>
computeOperations(
Jackie-Jiang commented on code in PR #11354:
URL: https://github.com/apache/pinot/pull/11354#discussion_r1298132140
##
pinot-segment-spi/src/main/java/org/apache/pinot/segment/spi/index/TextIndexConfig.java:
##
@@ -99,6 +123,8 @@ public static abstract class AbstractBuilder {
Jackie-Jiang commented on code in PR #7908:
URL: https://github.com/apache/pinot/pull/7908#discussion_r1298138761
##
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/utils/TableConfigUtils.java:
##
@@ -1253,6 +1254,25 @@ public static void verifyHybridTableConfig
gortiz commented on PR #11376:
URL: https://github.com/apache/pinot/pull/11376#issuecomment-1683553753
The issue we have is that `report-aggregate`, by default, does only consider
coverage by dependencies. That means that if project A depends on project B,
lines covered by tests defined on
KKcorps commented on PR #11380:
URL: https://github.com/apache/pinot/pull/11380#issuecomment-1683578831
This looks good! One scenario we might need to check for is creating a table
just after it is deleted. We ran into this problem before.
https://github.com/apache/pinot/assets/555970
KKcorps commented on PR #11380:
URL: https://github.com/apache/pinot/pull/11380#issuecomment-1683582256
I still think though that having a `stop` or a `preShutDown` method would be
great
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
This is an automated email from the ASF dual-hosted git repository.
saurabhd336 pushed a change to branch release-1.0.0-rc
in repository https://gitbox.apache.org/repos/asf/pinot.git
discard b6478ca91f [maven-release-plugin] prepare for next development
iteration
omit d2feb81e6b [maven-rel
This is an automated email from the ASF dual-hosted git repository.
saurabhd336 pushed a change to annotated tag release-1.0.0-rc0
in repository https://gitbox.apache.org/repos/asf/pinot.git
*** WARNING: tag release-1.0.0-rc0 was deleted! ***
tag was 7383f40b17
This change permanently disc
gortiz opened a new pull request, #11381:
URL: https://github.com/apache/pinot/pull/11381
This is POC
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail
gortiz opened a new issue, #11382:
URL: https://github.com/apache/pinot/issues/11382
# The issue
There are some maven module (like
[pinot-query-runtime](https://app.codecov.io/gh/apache/pinot/tree/master/pinot-query-runtime))
that look uncovered in Codecov while having tests (in fact
This is an automated email from the ASF dual-hosted git repository.
saurabhd336 pushed a commit to branch release-1.0.0-rc
in repository https://gitbox.apache.org/repos/asf/pinot.git
The following commit(s) were added to refs/heads/release-1.0.0-rc by this push:
new 4679fd75b9 [maven-releas
This is an automated email from the ASF dual-hosted git repository.
saurabhd336 pushed a change to annotated tag release-1.0.0-rc0
in repository https://gitbox.apache.org/repos/asf/pinot.git
*** WARNING: tag release-1.0.0-rc0 was modified! ***
from 4679fd75b9 (commit)
to d9098a559a (t
This is an automated email from the ASF dual-hosted git repository.
saurabhd336 pushed a commit to branch release-1.0.0-rc
in repository https://gitbox.apache.org/repos/asf/pinot.git
The following commit(s) were added to refs/heads/release-1.0.0-rc by this push:
new 687a9b45dc [maven-releas
codecov-commenter commented on PR #11381:
URL: https://github.com/apache/pinot/pull/11381#issuecomment-1683670027
##
[Codecov](https://app.codecov.io/gh/apache/pinot/pull/11381?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
R
xiangfu0 opened a new pull request, #11383:
URL: https://github.com/apache/pinot/pull/11383
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-m
codecov-commenter commented on PR #11383:
URL: https://github.com/apache/pinot/pull/11383#issuecomment-1683754596
##
[Codecov](https://app.codecov.io/gh/apache/pinot/pull/11383?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
R
This is an automated email from the ASF dual-hosted git repository.
saurabhd336 pushed a change to branch masterPomBump
in repository https://gitbox.apache.org/repos/asf/pinot.git
discard a1ffd912f8 [maven-release-plugin] prepare for next development
iteration
add 0addf8138e Add instrumen
This is an automated email from the ASF dual-hosted git repository.
saurabhd336 pushed a commit to branch masterPomBump
in repository https://gitbox.apache.org/repos/asf/pinot.git
commit 6a112fbbb6148427d1633666b783f0d525db22ae
Author: Saurabh Dubey
AuthorDate: Thu Aug 10 22:58:37 2023 +0530
saurabhd336 opened a new pull request, #11384:
URL: https://github.com/apache/pinot/pull/11384
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe,
abhioncbr commented on PR #11384:
URL: https://github.com/apache/pinot/pull/11384#issuecomment-1683833800
Question, have we already released 0.13 version? Or we are making it as 1.1?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Gi
This is an automated email from the ASF dual-hosted git repository.
saurabhd336 pushed a change to annotated tag release-1.0.0-rc0
in repository https://gitbox.apache.org/repos/asf/pinot.git
*** WARNING: tag release-1.0.0-rc0 was deleted! ***
tag was d9098a559a
The revisions that were on t
This is an automated email from the ASF dual-hosted git repository.
saurabhd336 pushed a change to branch release-1.0.0-rc
in repository https://gitbox.apache.org/repos/asf/pinot.git
discard 687a9b45dc [maven-release-plugin] prepare for next development
iteration
discard 4679fd75b9 [maven-rel
codecov-commenter commented on PR #11384:
URL: https://github.com/apache/pinot/pull/11384#issuecomment-1683873487
##
[Codecov](https://app.codecov.io/gh/apache/pinot/pull/11384?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
R
This is an automated email from the ASF dual-hosted git repository.
saurabhd336 pushed a commit to branch release-1.0.0-rc
in repository https://gitbox.apache.org/repos/asf/pinot.git
The following commit(s) were added to refs/heads/release-1.0.0-rc by this push:
new f29f33b710 [maven-releas
This is an automated email from the ASF dual-hosted git repository.
saurabhd336 pushed a change to annotated tag release-1.0.0-rc0
in repository https://gitbox.apache.org/repos/asf/pinot.git
*** WARNING: tag release-1.0.0-rc0 was modified! ***
from f29f33b710 (commit)
to eafce06a72 (t
This is an automated email from the ASF dual-hosted git repository.
saurabhd336 pushed a commit to branch release-1.0.0-rc
in repository https://gitbox.apache.org/repos/asf/pinot.git
The following commit(s) were added to refs/heads/release-1.0.0-rc by this push:
new d26cf0c480 [maven-releas
ege-st commented on PR #11381:
URL: https://github.com/apache/pinot/pull/11381#issuecomment-1683953983
It looks like this test has worked?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spec
ege-st commented on issue #11382:
URL: https://github.com/apache/pinot/issues/11382#issuecomment-1683959437
Great explanation. It looks like using the `includeCurrentProject` flag
worked in the POC PR, would you say that's the best solution?
Side question, it looks like parallelizing
gortiz commented on PR #11205:
URL: https://github.com/apache/pinot/pull/11205#issuecomment-1683963385
I've decided to follow the approach suggested by @Jackie-Jiang on
MailboxSendOperator. Now when always fail if the buffer is full. But that
breaks the following tests, which verifies that
gortiz commented on issue #11382:
URL: https://github.com/apache/pinot/issues/11382#issuecomment-1683970732
> Side question, it looks like parallelizing the tests gave us a 30%
improvement in time to run tests. Do you think we could split tests into 4 sets
and get further improvement on tes
gortiz commented on issue #11382:
URL: https://github.com/apache/pinot/issues/11382#issuecomment-1683971590
> Great explanation. It looks like using the includeCurrentProject flag
worked in the POC PR, would you say that's the best solution?
I think it is the way we should go. But let
gortiz commented on PR #11381:
URL: https://github.com/apache/pinot/pull/11381#issuecomment-1683973594
Yeah, it looks to be the most promising. TBH I don't know why the coverage
in Java 17 and 20 is lower than expected and I also don't know why integration
tests report 0 coverage. But I don
ege-st commented on PR #11381:
URL: https://github.com/apache/pinot/pull/11381#issuecomment-1683977412
>
Yes, that is odd and I agree it's probably unrelated to this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
Author: saurabhd336
Date: Fri Aug 18 15:26:00 2023
New Revision: 63503
Log:
Update apache-pinot-1.0.0-rc0
Added:
dev/pinot/apache-pinot-1.0.0-rc0/
dev/pinot/apache-pinot-1.0.0-rc0/apache-pinot-1.0.0-bin.tar.gz (with
props)
dev/pinot/apache-pinot-1.0.0-rc0/apache-pinot-1.0.0-bin.tar
Jackie-Jiang commented on PR #11380:
URL: https://github.com/apache/pinot/pull/11380#issuecomment-1684240370
> This looks good! One scenario we might need to check for is creating a
table just after it is deleted. We ran into this problem before.
>
> https://user-images.githubusercont
zhtaoxiang commented on issue #11382:
URL: https://github.com/apache/pinot/issues/11382#issuecomment-1684319560
> ## Use `report` instead of `report-aggregate`
> I've tried that in #11376. Coverage seems to be worse (I don't exactly
know why) but `pinot-query-runtime` looks covered in [co
Jackie-Jiang commented on code in PR #11383:
URL: https://github.com/apache/pinot/pull/11383#discussion_r1298791276
##
pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/MultiStageEngineIntegrationTest.java:
##
@@ -101,6 +101,23 @@ public void testHardcoded
itschrispeck commented on code in PR #11354:
URL: https://github.com/apache/pinot/pull/11354#discussion_r1298837945
##
pinot-segment-spi/src/main/java/org/apache/pinot/segment/spi/index/TextIndexConfig.java:
##
@@ -32,15 +32,20 @@
public class TextIndexConfig extends IndexC
shenyu0127 opened a new pull request, #11385:
URL: https://github.com/apache/pinot/pull/11385
- Make the `transformToBigDecimalValuesSV` and `transformToStringValuesSV`
methods return the NULL placeholder when the scalar function returns NULL.
- Removes the redundant `_resultType == Pinot
xiangfu0 commented on code in PR #11383:
URL: https://github.com/apache/pinot/pull/11383#discussion_r1298906395
##
pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/MultiStageEngineIntegrationTest.java:
##
@@ -101,6 +101,23 @@ public void testHardcodedQuer
Jackie-Jiang closed issue #11251: Create a separated query endpoint for
multi-stage query engine
URL: https://github.com/apache/pinot/issues/11251
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
codecov-commenter commented on PR #11385:
URL: https://github.com/apache/pinot/pull/11385#issuecomment-1684547599
##
[Codecov](https://app.codecov.io/gh/apache/pinot/pull/11385?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
R
xiangfu0 merged PR #11383:
URL: https://github.com/apache/pinot/pull/11383
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apa
This is an automated email from the ASF dual-hosted git repository.
xiangfu pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
The following commit(s) were added to refs/heads/master by this push:
new 1c61e4cebf Adding rule to skip SINGLE_VALUE agg
Jackie-Jiang commented on PR #11380:
URL: https://github.com/apache/pinot/pull/11380#issuecomment-1684556779
Revised the code to also remove the table segment manager when EV becomes
empty. This can solve the problem of recreating segment within 1 second check
interval. In the worst case sc
Jackie-Jiang commented on issue #11382:
URL: https://github.com/apache/pinot/issues/11382#issuecomment-1684560768
Great analysis. I think `includeCurrentProject` is the correct solution.
As for the problem introduced in parallelized tests, I feel it is caused by
the second test overriding
Jackie-Jiang commented on PR #11205:
URL: https://github.com/apache/pinot/pull/11205#issuecomment-1684644041
Applied a commit to fix `MailboxSendOperatorTest`. Since we no longer need
to return no-op block, the old testing logic no longer apply
--
This is an automated message from the Apa
Jackie-Jiang merged PR #11380:
URL: https://github.com/apache/pinot/pull/11380
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot
This is an automated email from the ASF dual-hosted git repository.
jackie pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
The following commit(s) were added to refs/heads/master by this push:
new decc4eba2f Properly handle shutdown of TableDataM
Jackie-Jiang merged PR #11367:
URL: https://github.com/apache/pinot/pull/11367
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot
This is an automated email from the ASF dual-hosted git repository.
jackie pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
The following commit(s) were added to refs/heads/master by this push:
new 624478781d disable broker query killing test (#11
Jackie-Jiang commented on issue #11099:
URL: https://github.com/apache/pinot/issues/11099#issuecomment-1684666488
Temporarily disabled the test. Keeping the ticket open
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use t
Jackie-Jiang merged PR #11354:
URL: https://github.com/apache/pinot/pull/11354
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot
This is an automated email from the ASF dual-hosted git repository.
jackie pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
The following commit(s) were added to refs/heads/master by this push:
new c64040b017 add additional lucene index configs (#
Jackie-Jiang commented on PR #11354:
URL: https://github.com/apache/pinot/pull/11354#issuecomment-1684669436
Can you also help update the Pinot doc (this
[page](https://docs.pinot.apache.org/basics/indexing/text-search-support)) for
the new configs?
--
This is an automated message from
Jackie-Jiang merged PR #11205:
URL: https://github.com/apache/pinot/pull/11205
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot
This is an automated email from the ASF dual-hosted git repository.
jackie pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
from c64040b017 add additional lucene index configs (#11354)
add a5a1641e60 Remove noop (#11205)
No new revisions were
60 matches
Mail list logo
